From: Edward Cree <ecree.xilinx@gmail.com>
To: "Íñigo Huguet" <ihuguet@redhat.com>,
habetsm.xilinx@gmail.com, sshah@solarflare.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
Ma Yuying <yuma@redhat.com>
Subject: Re: [PATCH net] sfc: fix kernel panic when creating VF
Date: Wed, 13 Jul 2022 16:51:58 +0100 [thread overview]
Message-ID: <a29124d2-3bf0-4bf1-a231-5937dfcf96b6@gmail.com> (raw)
In-Reply-To: <20220713092116.21238-1-ihuguet@redhat.com>
On 13/07/2022 10:21, Íñigo Huguet wrote:
...> Fixes: d778819609a2 ("sfc: DMA the VF stats only when requested")
> Reported-by: Ma Yuying <yuma@redhat.com>
> Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
Really the whole locking thing around stats is ugly and we ought to
redesign it so as to fix things properly (AFAICT there's no reason
why the stats_lock needs to be taken by the caller rather than
within the nic_type->update_stats() method), but for the time being
this looks like the right minimal fix for 'net'.
-ed
next prev parent reply other threads:[~2022-07-13 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 9:21 [PATCH net] sfc: fix kernel panic when creating VF Íñigo Huguet
2022-07-13 15:51 ` Edward Cree [this message]
2022-07-14 11:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a29124d2-3bf0-4bf1-a231-5937dfcf96b6@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=ihuguet@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sshah@solarflare.com \
--cc=yuma@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.