From: Paolo Abeni <pabeni@redhat.com>
To: dullfire@yahoo.com, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Simon Horman <horms@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mostafa Saleh <smostafa@google.com>,
Marc Zyngier <maz@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI/MSI: Add MSIX option to write to ENTRY_DATA before any reads
Date: Thu, 21 Nov 2024 09:55:47 +0100 [thread overview]
Message-ID: <a292cdfe-e319-4bbd-bcc0-a74c16db9053@redhat.com> (raw)
In-Reply-To: <20241117234843.19236-2-dullfire@yahoo.com>
On 11/18/24 00:48, dullfire@yahoo.com wrote:
> From: Jonathan Currier <dullfire@yahoo.com>
>
> Commit 7d5ec3d36123 ("PCI/MSI: Mask all unused MSI-X entries")
> introduces a readl() from ENTRY_VECTOR_CTRL before the writel() to
> ENTRY_DATA. This is correct, however some hardware, like the Sun Neptune
> chips, the niu module, will cause an error and/or fatal trap if any MSIX
> table entry is read before the corresponding ENTRY_DATA field is written
> to. This patch adds an optional early writel() in msix_prepare_msi_desc().
Why the issue can't be addressed into the relevant device driver? It
looks like an H/W bug, a driver specific fix looks IMHO more fitting.
A cross subsystem series, like this one, gives some extra complication
to maintainers.
Thanks,
Paolo
next prev parent reply other threads:[~2024-11-21 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241117234843.19236-1-dullfire.ref@yahoo.com>
2024-11-17 23:48 ` [PATCH 0/2] Fix kernel panic on niu bind dullfire
2024-11-17 23:48 ` [PATCH 1/2] PCI/MSI: Add MSIX option to write to ENTRY_DATA before any reads dullfire
2024-11-21 8:55 ` Paolo Abeni [this message]
2024-11-21 9:22 ` Dullfire
2024-11-21 10:28 ` Paolo Abeni
2025-01-20 12:38 ` Dullfire
2025-04-14 16:22 ` Dullfire
2025-04-14 19:52 ` Thomas Gleixner
2025-04-15 6:36 ` [tip: irq/urgent] PCI/MSI: Add an option to write MSIX " tip-bot2 for Jonathan Currier
2024-11-17 23:48 ` [PATCH 2/2] net/niu: niu requires MSIX ENTRY_DATA fields touch before entry reads dullfire
2025-04-15 6:36 ` [tip: irq/urgent] net/niu: Niu " tip-bot2 for Jonathan Currier
[not found] <20241117233544.18227-1-dullfire@yahoo.com>
2024-11-17 23:35 ` [PATCH 1/2] PCI/MSI: Add MSIX option to write to ENTRY_DATA before any reads dullfire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a292cdfe-e319-4bbd-bcc0-a74c16db9053@redhat.com \
--to=pabeni@redhat.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=dullfire@yahoo.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=smostafa@google.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.