All of lore.kernel.org
 help / color / mirror / Atom feed
From: Derrick Stolee <derrickstolee@github.com>
To: "Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Patrick Steinhardt" <ps@pks.im>
Subject: ds/commit-graph-gen-v2-fixes (was Re: What's cooking in git.git (Feb 2022, #08; Mon, 28))
Date: Tue, 1 Mar 2022 09:26:51 -0500	[thread overview]
Message-ID: <a296c8fc-9701-15bd-4459-e49f157adb56@github.com> (raw)
In-Reply-To: <xmqqmti9ssah.fsf@gitster.g>

On 3/1/2022 8:42 AM, Junio C Hamano wrote:

> * ds/commit-graph-gen-v2-fixes (2022-02-28) 4 commits
>  - commit-graph: fix generation number v2 overflow values
>  - commit-graph: start parsing generation v2 (again)
>  - commit-graph: fix ordering bug in generation numbers
>  - test-read-graph: include extra post-parse info
> 
>  Fixes to the way generation number v2 in the commit-graph files are
>  (not) handled.
> 
>  Will merge to 'next'.
>  source: <pull.1163.v2.git.1646056423.gitgitgadget@gmail.com>

Please hold for a re-roll on this one. Ævar has some feedback
on these patches that merit a new version. His comments are
mainly about test structure, but they will help get extra
coverage in the 32-bit case.

Patrick also had some concerns about upgrading from older,
buggy versions of Git. I think this isn't an issue [1] because of
how those older versions would ignore existing corrected
commit dates, but it would be good to get a common understanding
of the scenario before merging this.

[1] https://lore.kernel.org/git/f50e74f0-9ffa-f4f2-4663-269801495ed3@github.com/

Thanks,
-Stolee



  reply	other threads:[~2022-03-01 14:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 13:42 What's cooking in git.git (Feb 2022, #08; Mon, 28) Junio C Hamano
2022-03-01 14:26 ` Derrick Stolee [this message]
2022-03-01 14:58   ` ds/commit-graph-gen-v2-fixes (was Re: What's cooking in git.git (Feb 2022, #08; Mon, 28)) Patrick Steinhardt
2022-03-01 18:07   ` Junio C Hamano
2022-03-01 22:55 ` js/scalar-diagnose, was Re: What's cooking in git.git (Feb 2022, #08; Mon, 28) Johannes Schindelin
2022-03-02  7:05   ` Junio C Hamano
2022-03-02  1:26 ` en/merge-tree (Was: Re: What's cooking in git.git (Feb 2022, #08; Mon, 28)) Elijah Newren
2022-03-07 16:31   ` Johannes Schindelin
2022-03-08  8:30     ` Elijah Newren
2022-03-09 11:46       ` Johannes Schindelin
2022-03-03 16:11 ` ab/object-file-api-updates (was: " Ævar Arnfjörð Bjarmason
2022-03-03 22:23   ` ab/object-file-api-updates Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a296c8fc-9701-15bd-4459-e49f157adb56@github.com \
    --to=derrickstolee@github.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.