From mboxrd@z Thu Jan 1 00:00:00 1970 From: maarten.lankhorst@linux.intel.com (Maarten Lankhorst) Date: Wed, 8 Jun 2016 16:14:38 +0200 Subject: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. In-Reply-To: <1465388359-8070-3-git-send-email-daniel.vetter@ffwll.ch> References: <1465388359-8070-1-git-send-email-daniel.vetter@ffwll.ch> <1465388359-8070-3-git-send-email-daniel.vetter@ffwll.ch> List-ID: Message-ID: To: linux-snps-arc@lists.infradead.org Op 08-06-16 om 14:18 schreef Daniel Vetter: > The drm core has a nice ready-made helper for exactly the simple case > where it should fire on the next vblank. > > Note that arming the vblank event in _begin is probably too early, and > might easily result in the vblank firing too early, before the new set > of planes are actually disabled. But that's kinda a minor issue > compared to just outright hanging userspace. > > v2: Be more robust and either arm, when the CRTC is on, or just send > the event out right away. > > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: linux-snps-arc at lists.infradead.org > Signed-off-by: Daniel Vetter Wouldn't it be better to do this in atomic_flush then? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. Date: Wed, 8 Jun 2016 16:14:38 +0200 Message-ID: References: <1465388359-8070-1-git-send-email-daniel.vetter@ffwll.ch> <1465388359-8070-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id D65E46EA18 for ; Wed, 8 Jun 2016 14:14:40 +0000 (UTC) In-Reply-To: <1465388359-8070-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , DRI Development Cc: Daniel Vetter , linux-snps-arc@lists.infradead.org, Alexey Brodkin , Carlos Palminha List-Id: dri-devel@lists.freedesktop.org T3AgMDgtMDYtMTYgb20gMTQ6MTggc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IFRoZSBkcm0gY29y ZSBoYXMgYSBuaWNlIHJlYWR5LW1hZGUgaGVscGVyIGZvciBleGFjdGx5IHRoZSBzaW1wbGUgY2Fz ZQo+IHdoZXJlIGl0IHNob3VsZCBmaXJlIG9uIHRoZSBuZXh0IHZibGFuay4KPgo+IE5vdGUgdGhh dCBhcm1pbmcgdGhlIHZibGFuayBldmVudCBpbiBfYmVnaW4gaXMgcHJvYmFibHkgdG9vIGVhcmx5 LCBhbmQKPiBtaWdodCBlYXNpbHkgcmVzdWx0IGluIHRoZSB2YmxhbmsgZmlyaW5nIHRvbyBlYXJs eSwgYmVmb3JlIHRoZSBuZXcgc2V0Cj4gb2YgcGxhbmVzIGFyZSBhY3R1YWxseSBkaXNhYmxlZC4g QnV0IHRoYXQncyBraW5kYSBhIG1pbm9yIGlzc3VlCj4gY29tcGFyZWQgdG8ganVzdCBvdXRyaWdo dCBoYW5naW5nIHVzZXJzcGFjZS4KPgo+IHYyOiBCZSBtb3JlIHJvYnVzdCBhbmQgZWl0aGVyIGFy bSwgd2hlbiB0aGUgQ1JUQyBpcyBvbiwgb3IganVzdCBzZW5kCj4gdGhlIGV2ZW50IG91dCByaWdo dCBhd2F5Lgo+Cj4gQ2M6IENhcmxvcyBQYWxtaW5oYSA8cGFsbWluaGFAc3lub3BzeXMuY29tPgo+ IENjOiBBbGV4ZXkgQnJvZGtpbiA8YWJyb2RraW5Ac3lub3BzeXMuY29tPgo+IENjOiBsaW51eC1z bnBzLWFyY0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+CldvdWxkbid0IGl0IGJlIGJldHRlciB0byBkbyB0 aGlzIGluIGF0b21pY19mbHVzaCB0aGVuPwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK