All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael-cy Lee (李峻宇)" <Michael-cy.Lee@mediatek.com>
To: "quic_adisi@quicinc.com" <quic_adisi@quicinc.com>,
	"pkshih@realtek.com" <pkshih@realtek.com>,
	"johannes@sipsolutions.net" <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ilan.peer@intel.com" <ilan.peer@intel.com>,
	"arend.vanspriel@broadcom.com" <arend.vanspriel@broadcom.com>,
	Ryder Lee <Ryder.Lee@mediatek.com>, "j@w1.fi" <j@w1.fi>,
	"quic_jjohnson@quicinc.com" <quic_jjohnson@quicinc.com>,
	"nbd@openwrt.org" <nbd@openwrt.org>
Subject: Re: [PATCH v8 4/5] wifi: mac80211: start and finalize channel switch on link basis
Date: Mon, 11 Mar 2024 06:20:28 +0000	[thread overview]
Message-ID: <a2a7ace267a309930882d3e6bcf58fa41d07d658.camel@mediatek.com> (raw)
In-Reply-To: <32b5e358f7b54f4921e0a9e44a71f3a791f0d0da.camel@sipsolutions.net>

On Wed, 2024-02-21 at 09:09 +0100, Johannes Berg wrote:
> 
> I guess that'd also apply to probe responses? Or does it not send
> those
> at all? But we discussed before that maybe we don't have to be
> perfect
> there, so I guess we can find some solution to that.
> 
> So we have, so far
> 
> Realtek:
>  - uses offset in beacon template to set partner counter,
>  - requires host to set CSA/ECSA elements
> 
> Qualcomm:
>  - copies and updates CSA/ECSA elements all by itself
>  - btw, not sure here about probe responses, does it do that too?
> 
> hwsim:
>  - personally, I'd prefer it works like Realtek, for less complexity
> 
> Intel:
>  - not implemented, probably not going to happen any time soon, but I
>    think we might prefer the Realtek way too if we ever do this
> 
> 
> Mediatek? Broadcom? Anyone else?
> 
> 
> I guess then for Qualcomm we'll need to just add an extended feature
> flag for "FW_HANDLES_PARTNER_LINK_CSA" and then hostapd can just not
> update the parter link templates, or so?
> 
> Thanks,

Hi,
 
Sorry for the late reply.
 
In summary, MediaTek firmware behaves similarly to Realtek's firmware,
so we agree on the conclusion of this thread.
 
By the way, this behavior does not apply to probe response in MediaTek
firmware. In other words, MediaTek firmware does not modify the probe
response and it requires hostapd to fill all CSA-related Elements.
I think this could be fixed if hostapd provides CSA offsets when
sending the probe response.
 
Best,
Michael
> johannes

  parent reply	other threads:[~2024-03-11  6:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 14:09 [PATCH v8 0/5] wifi: cfg80211/mac80211: add link_id handling in AP channel switch during Multi-Link Operation Aditya Kumar Singh
2024-01-30 14:09 ` [PATCH v8 1/5] wifi: cfg80211: send link id in channel_switch ops Aditya Kumar Singh
2024-01-30 14:09 ` [PATCH v8 2/5] wifi: mac80211: update beacon counters per link basis Aditya Kumar Singh
2024-01-30 14:09 ` [PATCH v8 3/5] wifi: mac80211: handle set csa/after_csa beacon on " Aditya Kumar Singh
2024-01-30 14:09 ` [PATCH v8 4/5] wifi: mac80211: start and finalize channel switch on " Aditya Kumar Singh
2024-02-08 13:48   ` Johannes Berg
2024-02-08 14:05     ` Johannes Berg
2024-02-12  6:40       ` Aditya Kumar Singh
2024-02-12  7:18         ` Aditya Kumar Singh
2024-02-12 14:46           ` Johannes Berg
2024-02-13  5:16             ` Aditya Kumar Singh
2024-02-13  8:42               ` Johannes Berg
2024-02-13  8:45                 ` Johannes Berg
2024-02-13 10:18                 ` Aditya Kumar Singh
2024-02-13 10:55                   ` Johannes Berg
2024-02-13 12:41                     ` Aditya Kumar Singh
2024-02-13 12:49                       ` Johannes Berg
2024-02-21  7:58                         ` Ping-Ke Shih
2024-02-21  8:09                           ` Johannes Berg
2024-02-21  8:19                             ` Ping-Ke Shih
2024-02-21  8:20                               ` Johannes Berg
2024-02-21  8:28                                 ` Ping-Ke Shih
2024-02-21  8:35                                   ` Johannes Berg
2024-02-21  8:57                                     ` Ping-Ke Shih
2024-02-21  8:59                                       ` Johannes Berg
2024-02-21  9:17                                         ` Ping-Ke Shih
2024-02-21  9:19                                           ` Johannes Berg
2024-02-21  9:29                                             ` Ping-Ke Shih
2024-02-21  9:42                             ` Johannes Berg
2024-02-21 12:19                               ` Aditya Kumar Singh
2024-02-21 12:21                               ` Aditya Kumar Singh
2024-02-21 12:52                             ` Aditya Kumar Singh
2024-02-21 13:08                               ` Johannes Berg
2024-02-21 13:22                                 ` Aditya Kumar Singh
2024-03-11  6:20                             ` Michael-cy Lee (李峻宇) [this message]
2024-01-30 14:09 ` [PATCH v8 5/5] wifi: mac80211: add support to call csa_finish on a link Aditya Kumar Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2a7ace267a309930882d3e6bcf58fa41d07d658.camel@mediatek.com \
    --to=michael-cy.lee@mediatek.com \
    --cc=Ryder.Lee@mediatek.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=ilan.peer@intel.com \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    --cc=pkshih@realtek.com \
    --cc=quic_adisi@quicinc.com \
    --cc=quic_jjohnson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.