From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8iwl-0005v8-U0 for qemu-devel@nongnu.org; Thu, 11 May 2017 03:55:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8iwh-000322-Rn for qemu-devel@nongnu.org; Thu, 11 May 2017 03:55:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46312) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8iwh-00031N-MN for qemu-devel@nongnu.org; Thu, 11 May 2017 03:55:35 -0400 References: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> <1494356693-13190-2-git-send-email-sstabellini@kernel.org> From: Paolo Bonzini Message-ID: Date: Thu, 11 May 2017 09:55:29 +0200 MIME-Version: 1.0 In-Reply-To: <1494356693-13190-2-git-send-email-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini , qemu-devel@nongnu.org Cc: xen-devel@lists.xen.org, groug@kaod.org, Eric Blake On 09/05/2017 21:04, Stefano Stabellini wrote: > Assert that the return value is not an error. This issue was found by > Coverity. > > CID: 1374831 > > Signed-off-by: Stefano Stabellini > CC: groug@kaod.org > CC: pbonzini@redhat.com > CC: Eric Blake Queued, thanks. Paolo > --- > util/oslib-posix.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/util/oslib-posix.c b/util/oslib-posix.c > index 4d9189e..16894ad 100644 > --- a/util/oslib-posix.c > +++ b/util/oslib-posix.c > @@ -182,7 +182,9 @@ void qemu_set_cloexec(int fd) > { > int f; > f = fcntl(fd, F_GETFD); > - fcntl(fd, F_SETFD, f | FD_CLOEXEC); > + assert(f != -1); > + f = fcntl(fd, F_SETFD, f | FD_CLOEXEC); > + assert(f != -1); > } > > /* > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec Date: Thu, 11 May 2017 09:55:29 +0200 Message-ID: References: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> <1494356693-13190-2-git-send-email-sstabellini@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1494356693-13190-2-git-send-email-sstabellini@kernel.org> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefano Stabellini , qemu-devel@nongnu.org Cc: Eric Blake , groug@kaod.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org CgpPbiAwOS8wNS8yMDE3IDIxOjA0LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6Cj4gQXNzZXJ0 IHRoYXQgdGhlIHJldHVybiB2YWx1ZSBpcyBub3QgYW4gZXJyb3IuIFRoaXMgaXNzdWUgd2FzIGZv dW5kIGJ5Cj4gQ292ZXJpdHkuCj4gCj4gQ0lEOiAxMzc0ODMxCj4gCj4gU2lnbmVkLW9mZi1ieTog U3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgo+IENDOiBncm91Z0Br YW9kLm9yZwo+IENDOiBwYm9uemluaUByZWRoYXQuY29tCj4gQ0M6IEVyaWMgQmxha2UgPGVibGFr ZUByZWRoYXQuY29tPgoKUXVldWVkLCB0aGFua3MuCgpQYW9sbwoKPiAtLS0KPiAgdXRpbC9vc2xp Yi1wb3NpeC5jIHwgNCArKystCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvdXRpbC9vc2xpYi1wb3NpeC5jIGIvdXRpbC9v c2xpYi1wb3NpeC5jCj4gaW5kZXggNGQ5MTg5ZS4uMTY4OTRhZCAxMDA2NDQKPiAtLS0gYS91dGls L29zbGliLXBvc2l4LmMKPiArKysgYi91dGlsL29zbGliLXBvc2l4LmMKPiBAQCAtMTgyLDcgKzE4 Miw5IEBAIHZvaWQgcWVtdV9zZXRfY2xvZXhlYyhpbnQgZmQpCj4gIHsKPiAgICAgIGludCBmOwo+ ICAgICAgZiA9IGZjbnRsKGZkLCBGX0dFVEZEKTsKPiAtICAgIGZjbnRsKGZkLCBGX1NFVEZELCBm IHwgRkRfQ0xPRVhFQyk7Cj4gKyAgICBhc3NlcnQoZiAhPSAtMSk7Cj4gKyAgICBmID0gZmNudGwo ZmQsIEZfU0VURkQsIGYgfCBGRF9DTE9FWEVDKTsKPiArICAgIGFzc2VydChmICE9IC0xKTsKPiAg fQo+ICAKPiAgLyoKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0 cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=