All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, dri-devel@lists.freedesktop.org
Cc: "Jani Nikula" <jani.nikula@intel.com>,
	"Arunpravin Paneer Selvam" <Arunpravin.PaneerSelvam@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/tests/buddy: fix build with unused prng
Date: Wed, 15 Jan 2025 13:40:23 +0100	[thread overview]
Message-ID: <a2cadd9da0eed757b1a6e4727d5c9bc3adeed768.camel@linux.intel.com> (raw)
In-Reply-To: <20250115123734.154243-2-matthew.auld@intel.com>

On Wed, 2025-01-15 at 12:37 +0000, Matthew Auld wrote:
> We no longer use the prng, which leads to the following warning:
> 
> drivers/gpu/drm/tests/drm_buddy_test.c: In function
> ‘drm_test_buddy_alloc_clear’:
> drivers/gpu/drm/tests/drm_buddy_test.c:264:23: error: unused variable
> ‘prng’ [-Werror=unused-variable]
>   264 |         DRM_RND_STATE(prng, random_seed);
> 
> Reported-by: Jani Nikula <jani.nikula@intel.com>
> Reported-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Fixes: 8cb3a1e2b350 ("drm/buddy: Add a testcase to verify the
> multiroot fini")
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
> Cc: Christian König <christian.koenig@amd.com>

Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

> ---
>  drivers/gpu/drm/tests/drm_buddy_test.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c
> b/drivers/gpu/drm/tests/drm_buddy_test.c
> index 4b5818f9f2a9..7a0e523651f0 100644
> --- a/drivers/gpu/drm/tests/drm_buddy_test.c
> +++ b/drivers/gpu/drm/tests/drm_buddy_test.c
> @@ -261,7 +261,6 @@ static void
> drm_test_buddy_alloc_range_bias(struct kunit *test)
>  static void drm_test_buddy_alloc_clear(struct kunit *test)
>  {
>  	unsigned long n_pages, total, i = 0;
> -	DRM_RND_STATE(prng, random_seed);
>  	const unsigned long ps = SZ_4K;
>  	struct drm_buddy_block *block;
>  	const int max_order = 12;


  reply	other threads:[~2025-01-15 12:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-15 12:37 [PATCH] drm/tests/buddy: fix build with unused prng Matthew Auld
2025-01-15 12:40 ` Thomas Hellström [this message]
2025-01-15 12:42   ` Thomas Hellström
2025-01-15 15:58 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2cadd9da0eed757b1a6e4727d5c9bc3adeed768.camel@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=Arunpravin.PaneerSelvam@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.