From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Vasut To: Eugeniu Rosca , Tom Rini , Simon Glass , Masahiro Yamada , Andrey Ryabinin , Andre Przywara , Igor Opaniuk , Rasmus Villemoes , Bryan O'Donoghue , Andy Shevchenko , Chris Packham , Alex Kiernan , Alexey Brodkin , Michal Simek , York Sun , "Derald D . Woods" , Miquel Raynal , Baruch Siach , Albert Aribaud , Stephen Warren , Alexander Graf , Rick Chen , Adam Ford , Simon Goldschmidt , Pantelis Antoniou , Marek Vasut , Takeshi Kihara , Bin Meng , Heinrich Schuchardt , Anatolij Gustschin , Jean-Jacques Hiblot , Jaehoon Chung , Peng Fan , Andy Yan , Philipp Tomsich , Nobuhiro Iwamatsu , Mario Six , Grygorii Strashko , Neil Armstrong , Joe Hershberger , Florian Fainelli , Stefan Roese , Zubair Lutfullah Kakakhel , Quentin Schulz References: <20180820000033.25519-1-erosca@de.adit-jv.com> <20180820000033.25519-5-erosca@de.adit-jv.com> Message-ID: Date: Mon, 20 Aug 2018 10:07:16 +0200 MIME-Version: 1.0 In-Reply-To: <20180820000033.25519-5-erosca@de.adit-jv.com> Content-Language: en-US Cc: Linux-Renesas , u-boot@lists.denx.de, Eugeniu Rosca Subject: Re: [U-Boot] [PATCH 4/8] pinctrl: renesas: Fix "left shift in type int" undefined behavior List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" List-ID: T24gMDgvMjAvMjAxOCAwMjowMCBBTSwgRXVnZW5pdSBSb3NjYSB3cm90ZToKPiBCb290aW5nIFIt Q2FyIEgzLVNhbHZhdG9yLVggKENPTkZJR19VQlNBTj15KSBjb25zaXN0ZW50bHkgcmVzdWx0cyBp bjoKPiAKPiA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KPiBVQlNBTjogVW5kZWZpbmVkIGJlaGF2aW91ciBpbiBkcml2 ZXJzL3BpbmN0cmwvcmVuZXNhcy9wZmMuYzo0MDI6NDAKPiBsZWZ0IHNoaWZ0IG9mIDEgYnkgMzEg cGxhY2VzIGNhbm5vdCBiZSByZXByZXNlbnRlZCBpbiB0eXBlICdpbnQnCj4gPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Cj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Cj4gVUJTQU46IFVuZGVmaW5lZCBiZWhhdmlvdXIgaW4gZHJpdmVycy9w aW5jdHJsL3JlbmVzYXMvcGZjLmM6NDEwOjM5Cj4gbGVmdCBzaGlmdCBvZiAxIGJ5IDMxIHBsYWNl cyBjYW5ub3QgYmUgcmVwcmVzZW50ZWQgaW4gdHlwZSAnaW50Jwo+ID09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQo+IAo+ IFdoaWxlIGZpeGluZyB0aGVzZSB3YXJuaW5ncywgY29udmVydCAqYWxsKiBTSF9QRkNfUElOX0NG R18qIGRlZmluaXRpb25zCj4gdG8gdXNlIHRoZSByZWNvbW1lbmRlZCBCSVQoKSBtYWNyby4KPiAK PiBGaXhlczogOTEwZGY0ZDA3ZTM3ICgicGluY3RybDogcm1vYmlsZTogQWRkIFJlbmVzYXMgUkNh ciBwaW5jb250cm9sIGRyaXZlciIpCj4gU2lnbmVkLW9mZi1ieTogRXVnZW5pdSBSb3NjYSA8ZXJv c2NhQGRlLmFkaXQtanYuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3BpbmN0cmwvcmVuZXNhcy9zaF9w ZmMuaCB8IDE0ICsrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMo KyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGluY3RybC9yZW5l c2FzL3NoX3BmYy5oIGIvZHJpdmVycy9waW5jdHJsL3JlbmVzYXMvc2hfcGZjLmgKPiBpbmRleCBi OThjMmYxODVkMjYuLmI1OGU1MmJiZmJiOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BpbmN0cmwv cmVuZXNhcy9zaF9wZmMuaAo+ICsrKyBiL2RyaXZlcnMvcGluY3RybC9yZW5lc2FzL3NoX3BmYy5o Cj4gQEAgLTIxLDEzICsyMSwxMyBAQCBlbnVtIHsKPiAgCVBJTk1VWF9UWVBFX0lOUFVULAo+ICB9 Owo+ICAKPiAtI2RlZmluZSBTSF9QRkNfUElOX0NGR19JTlBVVAkJKDEgPDwgMCkKPiAtI2RlZmlu ZSBTSF9QRkNfUElOX0NGR19PVVRQVVQJCSgxIDw8IDEpCj4gLSNkZWZpbmUgU0hfUEZDX1BJTl9D RkdfUFVMTF9VUAkJKDEgPDwgMikKPiAtI2RlZmluZSBTSF9QRkNfUElOX0NGR19QVUxMX0RPV04J KDEgPDwgMykKPiAtI2RlZmluZSBTSF9QRkNfUElOX0NGR19JT19WT0xUQUdFCSgxIDw8IDQpCj4g LSNkZWZpbmUgU0hfUEZDX1BJTl9DRkdfRFJJVkVfU1RSRU5HVEgJKDEgPDwgNSkKPiAtI2RlZmlu ZSBTSF9QRkNfUElOX0NGR19OT19HUElPCQkoMSA8PCAzMSkKPiArI2RlZmluZSBTSF9QRkNfUElO X0NGR19JTlBVVAkJQklUKDApCj4gKyNkZWZpbmUgU0hfUEZDX1BJTl9DRkdfT1VUUFVUCQlCSVQo MSkKPiArI2RlZmluZSBTSF9QRkNfUElOX0NGR19QVUxMX1VQCQlCSVQoMikKPiArI2RlZmluZSBT SF9QRkNfUElOX0NGR19QVUxMX0RPV04JQklUKDMpCj4gKyNkZWZpbmUgU0hfUEZDX1BJTl9DRkdf SU9fVk9MVEFHRQlCSVQoNCkKPiArI2RlZmluZSBTSF9QRkNfUElOX0NGR19EUklWRV9TVFJFTkdU SAlCSVQoNSkKPiArI2RlZmluZSBTSF9QRkNfUElOX0NGR19OT19HUElPCQlCSVQoMzEpCgpNaWdo dCBtYWtlIHNlbnNlIHRvIGFwcGx5IHRoZSBzYW1lIGZpeCBmb3IgTGludXggPwoKQWNrZWQtYnk6 IE1hcmVrIFZhc3V0IDxtYXJlay52YXN1dEBnbWFpbC5jb20+CgotLSAKQmVzdCByZWdhcmRzLApN YXJlayBWYXN1dApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpVLUJvb3QgbWFpbGluZyBsaXN0ClUtQm9vdEBsaXN0cy5kZW54LmRlCmh0dHBzOi8vbGlzdHMu ZGVueC5kZS9saXN0aW5mby91LWJvb3QK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 20 Aug 2018 10:07:16 +0200 Subject: [U-Boot] [PATCH 4/8] pinctrl: renesas: Fix "left shift in type int" undefined behavior In-Reply-To: <20180820000033.25519-5-erosca@de.adit-jv.com> References: <20180820000033.25519-1-erosca@de.adit-jv.com> <20180820000033.25519-5-erosca@de.adit-jv.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/20/2018 02:00 AM, Eugeniu Rosca wrote: > Booting R-Car H3-Salvator-X (CONFIG_UBSAN=y) consistently results in: > > ===================================================================== > UBSAN: Undefined behaviour in drivers/pinctrl/renesas/pfc.c:402:40 > left shift of 1 by 31 places cannot be represented in type 'int' > ===================================================================== > ===================================================================== > UBSAN: Undefined behaviour in drivers/pinctrl/renesas/pfc.c:410:39 > left shift of 1 by 31 places cannot be represented in type 'int' > ===================================================================== > > While fixing these warnings, convert *all* SH_PFC_PIN_CFG_* definitions > to use the recommended BIT() macro. > > Fixes: 910df4d07e37 ("pinctrl: rmobile: Add Renesas RCar pincontrol driver") > Signed-off-by: Eugeniu Rosca > --- > drivers/pinctrl/renesas/sh_pfc.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/pinctrl/renesas/sh_pfc.h b/drivers/pinctrl/renesas/sh_pfc.h > index b98c2f185d26..b58e52bbfbb9 100644 > --- a/drivers/pinctrl/renesas/sh_pfc.h > +++ b/drivers/pinctrl/renesas/sh_pfc.h > @@ -21,13 +21,13 @@ enum { > PINMUX_TYPE_INPUT, > }; > > -#define SH_PFC_PIN_CFG_INPUT (1 << 0) > -#define SH_PFC_PIN_CFG_OUTPUT (1 << 1) > -#define SH_PFC_PIN_CFG_PULL_UP (1 << 2) > -#define SH_PFC_PIN_CFG_PULL_DOWN (1 << 3) > -#define SH_PFC_PIN_CFG_IO_VOLTAGE (1 << 4) > -#define SH_PFC_PIN_CFG_DRIVE_STRENGTH (1 << 5) > -#define SH_PFC_PIN_CFG_NO_GPIO (1 << 31) > +#define SH_PFC_PIN_CFG_INPUT BIT(0) > +#define SH_PFC_PIN_CFG_OUTPUT BIT(1) > +#define SH_PFC_PIN_CFG_PULL_UP BIT(2) > +#define SH_PFC_PIN_CFG_PULL_DOWN BIT(3) > +#define SH_PFC_PIN_CFG_IO_VOLTAGE BIT(4) > +#define SH_PFC_PIN_CFG_DRIVE_STRENGTH BIT(5) > +#define SH_PFC_PIN_CFG_NO_GPIO BIT(31) Might make sense to apply the same fix for Linux ? Acked-by: Marek Vasut -- Best regards, Marek Vasut