Re: [PATCH 2/2] media: maxim-serdes: Disable test pattern generator for now

[Hans Verkuil <hverkuil+cisco@kernel.org>]

On 07/10/2026 22:41, Sakari Ailus wrote:
> Disable the test pattern generator that uses the INTERNAL pad flags for
> now.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/media/i2c/maxim-serdes/max_des.c | 3 +--
>  drivers/media/i2c/maxim-serdes/max_ser.c | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/i2c/maxim-serdes/max_des.c b/drivers/media/i2c/maxim-serdes/max_des.c
> index 1cbe4c3a3233..cb43edf7a9ae 100644
> --- a/drivers/media/i2c/maxim-serdes/max_des.c
> +++ b/drivers/media/i2c/maxim-serdes/max_des.c
> @@ -137,8 +137,7 @@ static inline unsigned int max_des_phy_to_pad(struct max_des *des,
>  
>  static inline unsigned int max_des_num_pads(struct max_des *des)
>  {
> -	return des->info->num_links + des->info->num_phys +
> -	       (des->ops->set_tpg ? 1 : 0);
> +	return des->info->num_links + des->info->num_phys;

I think you need to add a comment here and also in max_ser.c.

E.g. something like this:

static inline unsigned int max_des_num_pads(struct max_des *des)
{
	return des->info->num_links + des->info->num_phys;
	/*
	 * TODO: once MEDIA_PAD_FL_INTERNAL is enabled in the uAPI we
	 * can add the TPG pad:
	 * return des->info->num_links + des->info->num_phys +
	 *       (des->ops->set_tpg ? 1 : 0);
	 */
}

That way it is actually recorded in the source why the tpg pad is currently
not added and what to do to add it back.

Regards,

	Hans

>  }
>  
>  static struct max_des_phy *max_des_pad_to_phy(struct max_des *des, u32 pad)
> diff --git a/drivers/media/i2c/maxim-serdes/max_ser.c b/drivers/media/i2c/maxim-serdes/max_ser.c
> index e9bb722ea22f..c8dd5c3d352c 100644
> --- a/drivers/media/i2c/maxim-serdes/max_ser.c
> +++ b/drivers/media/i2c/maxim-serdes/max_ser.c
> @@ -90,8 +90,7 @@ static inline unsigned int max_ser_phy_to_pad(struct max_ser *ser,
>  
>  static inline unsigned int max_ser_num_pads(struct max_ser *ser)
>  {
> -	return ser->ops->num_phys + MAX_SER_NUM_LINKS +
> -	       (ser->ops->set_tpg ? 1 : 0);
> +	return ser->ops->num_phys + MAX_SER_NUM_LINKS;
>  }
>  
>  static struct max_ser_phy *max_ser_pad_to_phy(struct max_ser *ser, u32 pad)