From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6047D818; Fri, 22 Dec 2023 00:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gxBcCIzz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8C3EC433C8; Fri, 22 Dec 2023 00:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703206141; bh=1DA8bmTOYGPA5GbuB9k2g469eTAv0F3olwtXeYlHwR0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=gxBcCIzz0cbD3ugkonPp9VYh2HSxnLxa44GHnYR4IW6PW3J4Rgn6Pi+WryMmWt1u+ 5wnyPnVzVHb6DgT2GO27/QCOg4t+BvjuTcwizCAit096W6X13xq+4fB/fkm9xMJ+mV XzzXiN6P8tqW/3UKazKRBC1dyh6uQYainN29c7Cz5EVUloedh5VnVDqEwg5ox/ZTPE WAnKi/wnq12bdu9JOoLCsG2Hs1BtJrFNhXZ6TLM0u4y2mx2j+ug/sbSq8E3XmcfDh4 /mURGarpcdtNGvskvrtl4VatuZlGrDntmlitK3JCfTA5uqUMlr1JBBqsp/hc9VSEVz hmabHJBfCHumw== Message-ID: Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <21f758cb-ae25-4d74-905c-0d4820f00070@foss.st.com> References: <20231219130909.265091-1-gabriel.fernandez@foss.st.com> <20231219130909.265091-2-gabriel.fernandez@foss.st.com> <21f758cb-ae25-4d74-905c-0d4820f00070@foss.st.com> Subject: Re: [PATCH v7 1/2] clk: stm32: introduce clocks for STM32MP257 platform From: Stephen Boyd Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Alexandre Torgue , Conor Dooley , Gabriel FERNANDEZ , Krzysztof Kozlowski , Maxime Coquelin , Michael Turquette , Philipp Zabel , Rob Herring Date: Thu, 21 Dec 2023 16:48:59 -0800 User-Agent: alot/0.10 Quoting Gabriel FERNANDEZ (2023-12-21 02:31:53) >=20 > On 12/20/23 23:16, Stephen Boyd wrote: > > Quoting gabriel.fernandez@foss.st.com (2023-12-19 05:09:08) > >> diff --git a/drivers/clk/stm32/clk-stm32mp25.c b/drivers/clk/stm32/clk= -stm32mp25.c > >> new file mode 100644 > >> index 000000000000..313e022c6142 > >> --- /dev/null > >> +++ b/drivers/clk/stm32/clk-stm32mp25.c > >> @@ -0,0 +1,1826 @@ > >> +// SPDX-License-Identifier: GPL-2.0-only > >> +/* > >> + * Copyright (C) STMicroelectronics 2023 - All Rights Reserved > >> + * Author: Gabriel Fernandez for STMi= croelectronics. > >> + */ > >> + > >> +#include > >> +#include > >> +#include > >> + > >> +#include "clk-stm32-core.h" > >> +#include "reset-stm32.h" > >> +#include "stm32mp25_rcc.h" > >> + > >> +#include > >> +#include > >> + > >> +static const struct clk_parent_data adc12_src[] =3D { > >> + { .name =3D "ck_flexgen_46" }, > > This is a new driver. Don't use .name here. Instead use .index or .hw > > and if that can't work then use .fw_name. >=20 > These parent clocks are managed by a secure world and exposed through SCM= I. >=20 > If I use .index or .fw_name, do I have to expose 122 clocks in my DT node= ? >=20 > This will significantly increase the size of the DT file >=20 > =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 clock-names =3D= "hse", "hsi", ..., "ck_scmi_stm500"; > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 clocks =3D <&sc= mi_clk CK_SCMI_HSE>, <&scmi_clk CK_SCMI_HSI>,=C2=A0=20 > ... , =C2=A0 <&scmi_clk CK_SCMI_STM500>; >=20 Yes? We want DT to express the connections between device nodes, and if the clks managed by SCMI are consumed here then they need to be specified via the clocks property. >=20 > > > >> + { } > >> +}; > >> +MODULE_DEVICE_TABLE(of, stm32mp25_match_data); > >> + > >> +static int get_clock_deps(struct device *dev) > > What is the explanation for this function? >=20 > It 's to manage the dependency with the SCMI clock driver. Please elaborate. Are you making sure the SCMI clk driver has probed before this driver? Why? What's wrong with probing this driver first? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6D0CC46CCD for ; Fri, 22 Dec 2023 00:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GevjmPj37drYwDxc15ESVqKyRAig6bPl5CfsgsvI+Sw=; b=u/utJCP6LOSQC8 RqX2ARjK6gJ+yqeYBN+WrLe5Cn7FBRg8fgjGGdqw5TJ1rBb8QARwbhbZoJ5RSYHIscMgvLLLhQmnP fhCoQzUEhWna8mcZW6uinN89O2gJfYq8lGGtrs5qxgNyQIENvFYwVX2H6IFtirO5fAHvJ3kaVTlTQ Y50TH7i9O26We1kH+MZ11fVHPpdvufhJG0ui9dnIezTd14mccddYaF5wri9GkRQF+8gzKQIzwx7+N O6sjfmIVgsl/jT7ZR+/9Xn8qEiXvEck2yOTl7mASznXt2jsDbs2tSIFTdj1U3xjgoe/zS/TvfutMH aloa+McRiw9lfYaeqWWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rGTis-004Yba-0D; Fri, 22 Dec 2023 00:49:06 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rGTiq-004YaU-0g for linux-arm-kernel@lists.infradead.org; Fri, 22 Dec 2023 00:49:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3F78B61A97; Fri, 22 Dec 2023 00:49:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8C3EC433C8; Fri, 22 Dec 2023 00:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703206141; bh=1DA8bmTOYGPA5GbuB9k2g469eTAv0F3olwtXeYlHwR0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=gxBcCIzz0cbD3ugkonPp9VYh2HSxnLxa44GHnYR4IW6PW3J4Rgn6Pi+WryMmWt1u+ 5wnyPnVzVHb6DgT2GO27/QCOg4t+BvjuTcwizCAit096W6X13xq+4fB/fkm9xMJ+mV XzzXiN6P8tqW/3UKazKRBC1dyh6uQYainN29c7Cz5EVUloedh5VnVDqEwg5ox/ZTPE WAnKi/wnq12bdu9JOoLCsG2Hs1BtJrFNhXZ6TLM0u4y2mx2j+ug/sbSq8E3XmcfDh4 /mURGarpcdtNGvskvrtl4VatuZlGrDntmlitK3JCfTA5uqUMlr1JBBqsp/hc9VSEVz hmabHJBfCHumw== Message-ID: MIME-Version: 1.0 In-Reply-To: <21f758cb-ae25-4d74-905c-0d4820f00070@foss.st.com> References: <20231219130909.265091-1-gabriel.fernandez@foss.st.com> <20231219130909.265091-2-gabriel.fernandez@foss.st.com> <21f758cb-ae25-4d74-905c-0d4820f00070@foss.st.com> Subject: Re: [PATCH v7 1/2] clk: stm32: introduce clocks for STM32MP257 platform From: Stephen Boyd Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Alexandre Torgue , Conor Dooley , Gabriel FERNANDEZ , Krzysztof Kozlowski , Maxime Coquelin , Michael Turquette , Philipp Zabel , Rob Herring Date: Thu, 21 Dec 2023 16:48:59 -0800 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231221_164904_360270_552B0166 X-CRM114-Status: GOOD ( 19.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UXVvdGluZyBHYWJyaWVsIEZFUk5BTkRFWiAoMjAyMy0xMi0yMSAwMjozMTo1MykKPiAKPiBPbiAx Mi8yMC8yMyAyMzoxNiwgU3RlcGhlbiBCb3lkIHdyb3RlOgo+ID4gUXVvdGluZyBnYWJyaWVsLmZl cm5hbmRlekBmb3NzLnN0LmNvbSAoMjAyMy0xMi0xOSAwNTowOTowOCkKPiA+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9jbGsvc3RtMzIvY2xrLXN0bTMybXAyNS5jIGIvZHJpdmVycy9jbGsvc3RtMzIv Y2xrLXN0bTMybXAyNS5jCj4gPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+PiBpbmRleCAwMDAw MDAwMDAwMDAuLjMxM2UwMjJjNjE0Mgo+ID4+IC0tLSAvZGV2L251bGwKPiA+PiArKysgYi9kcml2 ZXJzL2Nsay9zdG0zMi9jbGstc3RtMzJtcDI1LmMKPiA+PiBAQCAtMCwwICsxLDE4MjYgQEAKPiA+ PiArLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seQo+ID4+ICsvKgo+ID4+ ICsgKiBDb3B5cmlnaHQgKEMpIFNUTWljcm9lbGVjdHJvbmljcyAyMDIzIC0gQWxsIFJpZ2h0cyBS ZXNlcnZlZAo+ID4+ICsgKiBBdXRob3I6IEdhYnJpZWwgRmVybmFuZGV6IDxnYWJyaWVsLmZlcm5h bmRlekBmb3NzLnN0LmNvbT4gZm9yIFNUTWljcm9lbGVjdHJvbmljcy4KPiA+PiArICovCj4gPj4g Kwo+ID4+ICsjaW5jbHVkZSA8bGludXgvY2xrLmg+Cj4gPj4gKyNpbmNsdWRlIDxsaW51eC9vZl9h ZGRyZXNzLmg+Cj4gPj4gKyNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kZXZpY2UuaD4KPiA+PiAr Cj4gPj4gKyNpbmNsdWRlICJjbGstc3RtMzItY29yZS5oIgo+ID4+ICsjaW5jbHVkZSAicmVzZXQt c3RtMzIuaCIKPiA+PiArI2luY2x1ZGUgInN0bTMybXAyNV9yY2MuaCIKPiA+PiArCj4gPj4gKyNp bmNsdWRlIDxkdC1iaW5kaW5ncy9jbG9jay9zdCxzdG0zMm1wMjUtcmNjLmg+Cj4gPj4gKyNpbmNs dWRlIDxkdC1iaW5kaW5ncy9yZXNldC9zdCxzdG0zMm1wMjUtcmNjLmg+Cj4gPj4gKwo+ID4+ICtz dGF0aWMgY29uc3Qgc3RydWN0IGNsa19wYXJlbnRfZGF0YSBhZGMxMl9zcmNbXSA9IHsKPiA+PiAr ICAgICAgIHsgLm5hbWUgPSAiY2tfZmxleGdlbl80NiIgfSwKPiA+IFRoaXMgaXMgYSBuZXcgZHJp dmVyLiBEb24ndCB1c2UgLm5hbWUgaGVyZS4gSW5zdGVhZCB1c2UgLmluZGV4IG9yIC5odwo+ID4g YW5kIGlmIHRoYXQgY2FuJ3Qgd29yayB0aGVuIHVzZSAuZndfbmFtZS4KPiAKPiBUaGVzZSBwYXJl bnQgY2xvY2tzIGFyZSBtYW5hZ2VkIGJ5IGEgc2VjdXJlIHdvcmxkIGFuZCBleHBvc2VkIHRocm91 Z2ggU0NNSS4KPiAKPiBJZiBJIHVzZSAuaW5kZXggb3IgLmZ3X25hbWUsIGRvIEkgaGF2ZSB0byBl eHBvc2UgMTIyIGNsb2NrcyBpbiBteSBEVCBub2RlID8KPiAKPiBUaGlzIHdpbGwgc2lnbmlmaWNh bnRseSBpbmNyZWFzZSB0aGUgc2l6ZSBvZiB0aGUgRFQgZmlsZQo+IAo+ICDCoMKgwqAgwqDCoMKg IMKgwqDCoCBjbG9jay1uYW1lcyA9ICJoc2UiLCAiaHNpIiwgLi4uLCAiY2tfc2NtaV9zdG01MDAi Owo+ICDCoMKgIMKgwqDCoMKgIMKgwqDCoCBjbG9ja3MgPSA8JnNjbWlfY2xrIENLX1NDTUlfSFNF PiwgPCZzY21pX2NsayBDS19TQ01JX0hTST4swqAgCj4gLi4uICwgwqAgPCZzY21pX2NsayBDS19T Q01JX1NUTTUwMD47Cj4gCgpZZXM/IFdlIHdhbnQgRFQgdG8gZXhwcmVzcyB0aGUgY29ubmVjdGlv bnMgYmV0d2VlbiBkZXZpY2Ugbm9kZXMsIGFuZCBpZgp0aGUgY2xrcyBtYW5hZ2VkIGJ5IFNDTUkg YXJlIGNvbnN1bWVkIGhlcmUgdGhlbiB0aGV5IG5lZWQgdG8gYmUKc3BlY2lmaWVkIHZpYSB0aGUg Y2xvY2tzIHByb3BlcnR5LgoKPiAKPiA+Cj4gPj4gKyAgICAgICB7IH0KPiA+PiArfTsKPiA+PiAr TU9EVUxFX0RFVklDRV9UQUJMRShvZiwgc3RtMzJtcDI1X21hdGNoX2RhdGEpOwo+ID4+ICsKPiA+ PiArc3RhdGljIGludCBnZXRfY2xvY2tfZGVwcyhzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPiBXaGF0 IGlzIHRoZSBleHBsYW5hdGlvbiBmb3IgdGhpcyBmdW5jdGlvbj8KPiAKPiBJdCAncyB0byBtYW5h Z2UgdGhlIGRlcGVuZGVuY3kgd2l0aCB0aGUgU0NNSSBjbG9jayBkcml2ZXIuCgpQbGVhc2UgZWxh Ym9yYXRlLiBBcmUgeW91IG1ha2luZyBzdXJlIHRoZSBTQ01JIGNsayBkcml2ZXIgaGFzIHByb2Jl ZApiZWZvcmUgdGhpcyBkcml2ZXI/IFdoeT8gV2hhdCdzIHdyb25nIHdpdGggcHJvYmluZyB0aGlz IGRyaXZlciBmaXJzdD8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK