From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 982BFEB64DD for ; Tue, 4 Jul 2023 19:12:10 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.558644.872943 (Exim 4.92) (envelope-from ) id 1qGlRK-0007ET-8Z; Tue, 04 Jul 2023 19:11:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558644.872943; Tue, 04 Jul 2023 19:11:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGlRK-0007EM-5f; Tue, 04 Jul 2023 19:11:54 +0000 Received: by outflank-mailman (input) for mailman id 558644; Tue, 04 Jul 2023 19:11:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGlRI-0007EE-RF for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 19:11:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGlRI-0000Fu-8Y; Tue, 04 Jul 2023 19:11:52 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.9.70]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qGlRI-0001Zf-15; Tue, 04 Jul 2023 19:11:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=d6N1UGkbglsq2JKcU1Nnq10Dfh0i87isXX7HujVXOMQ=; b=zL10TnoltrieqCn8slPBLAvisT L3+AvSFPVNSUjKVweXwqU1snt8qRHcDMWMlnWqQIYwGyJ8LSP6ODNKU4QBeuVGCFVgvPNsqSIayzD THRLhpj3s4ZHDRUjpShoMNz2jwzURQzarYnL5P+EZXldq3otQbOYiI4SMtL6NCJ5YRr0=; Message-ID: Date: Tue, 4 Jul 2023 20:11:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/2] tools: Fix ifdef for aarch64 that should include also arm Content-Language: en-US To: Luca Fancellu Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Andrew Cooper , Anthony PERARD References: <20230608135913.560413-1-luca.fancellu@arm.com> <66c3d183-460d-4f34-a331-01ac4d65fc9d@perard> From: Julien Grall In-Reply-To: <66c3d183-460d-4f34-a331-01ac4d65fc9d@perard> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Replying here because there is no cover letter (in the future please add one if you have more than two patches bundled together). On 04/07/2023 10:42, Anthony PERARD wrote: > On Thu, Jun 08, 2023 at 02:59:12PM +0100, Luca Fancellu wrote: >> Commit 56a7aaa16bfe introduced some SVE related code that is protected by >> '#if defined(__aarch64__)', the issue is that this doesn't take into >> consideration when the toolstack is compiled for an arm32 Dom0 running on >> an arm64 platform, it should be able to create SVE enabled guests but with >> the current code it's not. >> >> So fix the issue by compiling the code when the toolstack is compiled for >> both arm32 and arm64. >> >> Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for Arm") >> Signed-off-by: Luca Fancellu >> Reported-by: Andrew Cooper > > Acked-by: Anthony PERARD I have now committed the series. Cheers, -- Julien Grall