All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH v2 6/9] hw/mips: Include missing 'exec/tswap.h' header
Date: Wed, 11 Dec 2024 18:01:56 -0600	[thread overview]
Message-ID: <a2df2f59-0cd0-4e62-ba9b-3ad2cd4db3f3@linaro.org> (raw)
In-Reply-To: <20241211230357.97036-7-philmd@linaro.org>

On 12/11/24 17:03, Philippe Mathieu-Daudé wrote:
> Some files indirectly get "exec/tswap.h" declarations via
> "exec/cpu-all.h". Include it directly to be able to remove
> the former from the latter, otherwise we get:
> 
>    hw/mips/malta.c:674:22: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>      674 |                      tswap32((1 << 31) /* ConfigEn */
>          |                      ^
>    hw/mips/fuloong2e.c:89:23: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>       89 |     prom_buf[index] = tswap32(ENVP_VADDR + table_addr);
>          |                       ^
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   hw/mips/fuloong2e.c | 1 +
>   hw/mips/malta.c     | 1 +
>   2 files changed, 2 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

  reply	other threads:[~2024-12-12  0:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11 23:03 [PATCH v2 0/9] misc: Reduce 'exec/tswap.h' inclusions Philippe Mathieu-Daudé
2024-12-11 23:03 ` [PATCH v2 1/9] target/xtensa: Remove tswap() calls in semihosting simcall() helper Philippe Mathieu-Daudé
2024-12-11 23:08   ` Philippe Mathieu-Daudé
2024-12-11 23:44     ` Richard Henderson
2024-12-11 23:03 ` [PATCH v2 2/9] target/mips: Remove tswap() calls in semihosting uhi_fstat_cb() Philippe Mathieu-Daudé
2024-12-11 23:03 ` [PATCH v2 3/9] accel/tcg: Include missing 'exec/tswap.h' header in translator.c Philippe Mathieu-Daudé
2024-12-11 23:47   ` Richard Henderson
2024-12-11 23:03 ` [PATCH v2 4/9] hw/arm: Include missing 'exec/tswap.h' header Philippe Mathieu-Daudé
2024-12-11 23:53   ` Richard Henderson
2024-12-17 15:20     ` Philippe Mathieu-Daudé
2024-12-11 23:03 ` [PATCH v2 5/9] hw/ppc: " Philippe Mathieu-Daudé
2024-12-12  0:00   ` Richard Henderson
2024-12-11 23:03 ` [PATCH v2 6/9] hw/mips: " Philippe Mathieu-Daudé
2024-12-12  0:01   ` Richard Henderson [this message]
2024-12-11 23:03 ` [PATCH v2 7/9] hw/sh4/r2d: " Philippe Mathieu-Daudé
2024-12-12  0:02   ` Richard Henderson
2024-12-11 23:03 ` [PATCH v2 8/9] hw/xtensa: " Philippe Mathieu-Daudé
2024-12-12  0:02   ` Richard Henderson
2024-12-11 23:03 ` [PATCH v2 9/9] exec/cpu-all: Do not include " Philippe Mathieu-Daudé
2024-12-12  0:02   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2df2f59-0cd0-4e62-ba9b-3ad2cd4db3f3@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.