Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output

[Shuah Khan <shuah@kernel.org>]

On 10/25/2017 04:01 PM, Stafford Horne wrote:
> On Wed, Oct 25, 2017 at 09:51:32AM -0400, Prarit Bhargava wrote:
>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range
>> minimum CPU frequency range.  For example, on a 800MHz to 4.20GHz system
>> the command returns
>>
>> hardware limits: 800000 MHz - 4.200000 GHz
>>
>> The code that causes this error can be removed.  The next else if clause
>> will handle the output correctly such that
>>
>> hardware limits: 800.000 MHz - 4.200000 GHz
>>
>> is displayed correctly.
>>
>> [v2]: Remove two lines instead of fixing broken code.
>>
>> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
>> Cc: Thomas Renninger <trenn@suse.com>
>> Cc: Stafford Horne <shorne@gmail.com>
>> Cc: Shuah Khan <shuah@kernel.org>
> 
> Reviewed-by: Stafford Horne <shorne@gmail.com>

Thanks for the review.

-- Shuah

> 
>> ---
>>  tools/power/cpupower/utils/cpufreq-info.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c
>> index 3e701f0e9c14..df43cd45d810 100644
>> --- a/tools/power/cpupower/utils/cpufreq-info.c
>> +++ b/tools/power/cpupower/utils/cpufreq-info.c
>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed)
>>  		if (speed > 1000000)
>>  			printf("%u.%06u GHz", ((unsigned int) speed/1000000),
>>  				((unsigned int) speed%1000000));
>> -		else if (speed > 100000)
>> -			printf("%u MHz", (unsigned int) speed);
>>  		else if (speed > 1000)
>>  			printf("%u.%03u MHz", ((unsigned int) speed/1000),
>>  				(unsigned int) (speed%1000));
>> -- 
>> 2.15.0.rc0.39.g2f0e14e64
>>
> 
>