From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7842EB64D7 for ; Wed, 14 Jun 2023 01:19:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241956AbjFNBS7 (ORCPT ); Tue, 13 Jun 2023 21:18:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241935AbjFNBS6 (ORCPT ); Tue, 13 Jun 2023 21:18:58 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68510123; Tue, 13 Jun 2023 18:18:57 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-543d32eed7cso2730564a12.2; Tue, 13 Jun 2023 18:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686705537; x=1689297537; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8rlEEo9ikUJaK6kPNcD1MGYGJ2duYtePI073tq2+zWU=; b=oYEYcNMp5KxkPdf9UjssCKvX91RZnKPWQtliT4xkdMh6wUhLo/HgUtc6IEG9O9gWud UE7s6bBVjSDQlT34wkCTUrN+n4tVKq7ty2Lvo7KEklUuhSeFPp9Ielx4042MlB7ltx8m wVf3kkXSdv7HWSKG92NqsSa6cEQUbmxEfe1dI3b5QyY0K0ysT6cXzf2Sxi7Cr+/Uvh1n yRWpDwsckYZTY0Mnaro9ti9D6vBNc9RUDvgp+yCwURmT6cqhkU95SrugTV9UFJoJCjfL v9JwFKNBFcYVqynPfElCM7VG3G6b6bgXSQasb5wv+e5k6qDZ1ogVd6G+umOL1OBJsTSh fwYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686705537; x=1689297537; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8rlEEo9ikUJaK6kPNcD1MGYGJ2duYtePI073tq2+zWU=; b=SoJABvx8If0Rd14keRDrxBCXLtUHkIpKODzNVTaGtV7KYU+shYVcqHilsfJXLfeaaC i1SgCR1RspIhrRPo09IJWuY3xJ4RZ+1U/1g5lituTBz8SWYYvhLwQ5Dm+6mPJNwQTbfk G3MWp8DvDHGMU50iQTEhXfd4eMe2Oq68LH4wLiTMJ5o6Zvzyrbi394YOO6pOeqz4/6Nc YdawNshr7DSSlJISnJUdO0cZCcUQvKoUzxnz0TSkXo0IM1YT8xz9Za8UfZmig+4b4Cji xVAqhtHSS7a+F7DECyPYO7uJvs0//I7SP0aFJInPHos7S5zp2OywNI/kNiB9oIcwJD5C JMeg== X-Gm-Message-State: AC+VfDy2RyUq5imua9GcEQzeXbGryb7jnHMKGiXjHXzmJFAMMKJGjr5e 9/hlEg7ifQDr4KGRyMN8QuUURs24IWw= X-Google-Smtp-Source: ACHHUZ6ST5lfSynOfzFpFQetsY4B3xQufhNg6RfgeefKg/BKLEcPb8+yNElTpG47QCrMvPN+Efpjzg== X-Received: by 2002:a17:902:e74e:b0:1b3:8865:aaae with SMTP id p14-20020a170902e74e00b001b38865aaaemr13011364plf.53.1686705536763; Tue, 13 Jun 2023 18:18:56 -0700 (PDT) Received: from [172.19.1.47] (60-250-192-107.hinet-ip.hinet.net. [60.250.192.107]) by smtp.gmail.com with ESMTPSA id r21-20020a170902ea5500b001ac8e0ea157sm10804832plg.144.2023.06.13.18.18.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 18:18:56 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 09:18:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v14 1/1] tty: serial: Add Nuvoton ma35d1 serial driver support To: Greg KH Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, jirislaby@kernel.org, tmaimon77@gmail.com, catalin.marinas@arm.com, will@kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, arnd@arndb.de, soc@kernel.org, schung@nuvoton.com, mjchen@nuvoton.com, Jacky Huang References: <20230612025355.547871-1-ychuang570808@gmail.com> <20230612025355.547871-2-ychuang570808@gmail.com> <2023061325-distant-gaffe-8871@gregkh> <0e40cbe6-0e88-b300-3507-5fa92eadb46d@gmail.com> <2023061312-outsource-triumph-7dd6@gregkh> Content-Language: en-US From: Jacky Huang In-Reply-To: <2023061312-outsource-triumph-7dd6@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Dear Greg, On 2023/6/13 下午 10:48, Greg KH wrote: > On Tue, Jun 13, 2023 at 07:03:11PM +0800, Jacky Huang wrote: >> Dear Greg, >> >> >> On 2023/6/13 下午 06:29, Greg KH wrote: >>> On Mon, Jun 12, 2023 at 02:53:55AM +0000, Jacky Huang wrote: >>>> From: Jacky Huang >>>> >>>> This adds UART and console driver for Nuvoton ma35d1 Soc. >>>> It supports full-duplex communication, FIFO control, and >>>> hardware flow control. >>> You don't specify here what your tty device name is going to be, why? >>> >>> It's not written anywhere, is that intentional? >>> >>> Same for your tty major/minor, what numbers are you using that might >>> also be in use by a different device in the system? >>> >>> thanks, >>> >>> greg k-h >> I will add description about the tty name to the log. >> In practical testing, we specified in the u-boot parameters >> to use ttyNVT0 for the console, and it worked fine. > Where did you pick that name from? Why can't you use the "default" uart > name instead? > > I thought we had a list of tty names around somewhere, but I can't find > it right now... > > thanks, > > greg k-h Initially, we were using the well-known ttyS, but it is used by the 8250 driver. Since the MA35D1 UART is incompatible with the 8250 driver, Andr raised concerns about using ttyS. To differentiate this UART from the incompatible 8250, we defined ttyNVT. This name is specified in the driver's UART name and console name structure, and other serial drivers follow a similar approach. For example, we can find names like ttySA, ttySAC, ttySC, ttySIF, ttySTM, ttySUP, and so on. If you believe that this UART driver can use ttyS, I am more than willing to make the modification. After all, some applications and scripts default to using ttyS, and using ttyNVT can indeed cause some inconvenience in certain situations. Best regards, Jacky Huang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4128EEB64D7 for ; Wed, 14 Jun 2023 01:19:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tFMzP51YQd7Xau2He3AF12O3yLMiRjz3Zav7yzhCQY4=; b=XNzMjNuPRL12GR vaRHHzsjQxgiIEmQQYm0cMivgrG6VEPlYv3DpHRK8Ih2IJfEnp/Sq0AvrqxWE7hZPtVKI1/6u/qKM X452FPs+S5WrMjubcegNmftSJ9m0bLuBmZLCEFoHLdQbh8ilpx38RgtAD6W2U9c5OfqsFicaxCOZy sWAOs/VqRRq9jbsIFgcIqO7KAtppQNp4fjI4fjtumaZiCZVntoHxuau3mjq96FjnC7uEtkxKp34HF e2Z0ojRLh8H0+DjicwutHjirZ67CQrXP9gszb2+2GS0a4Orb9P9Bt27Nst61AVHc8kc+CcE6FpA3B YSisMTKgEiLHhOonbbtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9FA8-009bh3-12; Wed, 14 Jun 2023 01:19:04 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9FA1-009bfJ-34 for linux-arm-kernel@lists.infradead.org; Wed, 14 Jun 2023 01:19:03 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1b3b974fffeso24430475ad.1 for ; Tue, 13 Jun 2023 18:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686705537; x=1689297537; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8rlEEo9ikUJaK6kPNcD1MGYGJ2duYtePI073tq2+zWU=; b=oYEYcNMp5KxkPdf9UjssCKvX91RZnKPWQtliT4xkdMh6wUhLo/HgUtc6IEG9O9gWud UE7s6bBVjSDQlT34wkCTUrN+n4tVKq7ty2Lvo7KEklUuhSeFPp9Ielx4042MlB7ltx8m wVf3kkXSdv7HWSKG92NqsSa6cEQUbmxEfe1dI3b5QyY0K0ysT6cXzf2Sxi7Cr+/Uvh1n yRWpDwsckYZTY0Mnaro9ti9D6vBNc9RUDvgp+yCwURmT6cqhkU95SrugTV9UFJoJCjfL v9JwFKNBFcYVqynPfElCM7VG3G6b6bgXSQasb5wv+e5k6qDZ1ogVd6G+umOL1OBJsTSh fwYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686705537; x=1689297537; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8rlEEo9ikUJaK6kPNcD1MGYGJ2duYtePI073tq2+zWU=; b=KzinV2gJTJXCLKCF0CAhGSvKRhu2ORW1cgGKkG60kQKLOZ5PSC/8e65pQqIsiaVj6+ 7JePrdMZ/ON10E3eh4ouQucQeLT418/FmeuNPUp2wPvZ0XyOyqLFw3wPy+ID9NRaJb9o Nnt65auT491Q/5NeKcLHLtbY1O07FXgIB8kx4Uyjzv62LGaVrBcliunzafgMrMEkfQo1 vg9/cpXMjQsduEsMt9KdKbC92FIBb5g1pbbaSbdekyQGTgy3nl/lo3zbXlEX6XBLxwsb w0VHUNWDKvZ+j2hY2fFUxlttnIUUsQQb3bl4QtSeipl9pZ+DwCA98d0/YFg1W0c6KBna VY6g== X-Gm-Message-State: AC+VfDwZ56ZxtuAMric/Fd5EzA4yUWoJ1n1nJmXoAyjVy1zGyYLDloem i/eSO9p2U+dmUb8j0h+r0QM= X-Google-Smtp-Source: ACHHUZ6ST5lfSynOfzFpFQetsY4B3xQufhNg6RfgeefKg/BKLEcPb8+yNElTpG47QCrMvPN+Efpjzg== X-Received: by 2002:a17:902:e74e:b0:1b3:8865:aaae with SMTP id p14-20020a170902e74e00b001b38865aaaemr13011364plf.53.1686705536763; Tue, 13 Jun 2023 18:18:56 -0700 (PDT) Received: from [172.19.1.47] (60-250-192-107.hinet-ip.hinet.net. [60.250.192.107]) by smtp.gmail.com with ESMTPSA id r21-20020a170902ea5500b001ac8e0ea157sm10804832plg.144.2023.06.13.18.18.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 18:18:56 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 09:18:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v14 1/1] tty: serial: Add Nuvoton ma35d1 serial driver support To: Greg KH Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, jirislaby@kernel.org, tmaimon77@gmail.com, catalin.marinas@arm.com, will@kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, arnd@arndb.de, soc@kernel.org, schung@nuvoton.com, mjchen@nuvoton.com, Jacky Huang References: <20230612025355.547871-1-ychuang570808@gmail.com> <20230612025355.547871-2-ychuang570808@gmail.com> <2023061325-distant-gaffe-8871@gregkh> <0e40cbe6-0e88-b300-3507-5fa92eadb46d@gmail.com> <2023061312-outsource-triumph-7dd6@gregkh> Content-Language: en-US From: Jacky Huang In-Reply-To: <2023061312-outsource-triumph-7dd6@gregkh> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_181857_986046_F30E8CC6 X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RGVhciBHcmVnLAoKCk9uIDIwMjMvNi8xMyDkuIvljYggMTA6NDgsIEdyZWcgS0ggd3JvdGU6Cj4g T24gVHVlLCBKdW4gMTMsIDIwMjMgYXQgMDc6MDM6MTFQTSArMDgwMCwgSmFja3kgSHVhbmcgd3Jv dGU6Cj4+IERlYXIgR3JlZywKPj4KPj4KPj4gT24gMjAyMy82LzEzIOS4i+WNiCAwNjoyOSwgR3Jl ZyBLSCB3cm90ZToKPj4+IE9uIE1vbiwgSnVuIDEyLCAyMDIzIGF0IDAyOjUzOjU1QU0gKzAwMDAs IEphY2t5IEh1YW5nIHdyb3RlOgo+Pj4+IEZyb206IEphY2t5IEh1YW5nIDx5Y2h1YW5nM0BudXZv dG9uLmNvbT4KPj4+Pgo+Pj4+IFRoaXMgYWRkcyBVQVJUIGFuZCBjb25zb2xlIGRyaXZlciBmb3Ig TnV2b3RvbiBtYTM1ZDEgU29jLgo+Pj4+IEl0IHN1cHBvcnRzIGZ1bGwtZHVwbGV4IGNvbW11bmlj YXRpb24sIEZJRk8gY29udHJvbCwgYW5kCj4+Pj4gaGFyZHdhcmUgZmxvdyBjb250cm9sLgo+Pj4g WW91IGRvbid0IHNwZWNpZnkgaGVyZSB3aGF0IHlvdXIgdHR5IGRldmljZSBuYW1lIGlzIGdvaW5n IHRvIGJlLCB3aHk/Cj4+Pgo+Pj4gSXQncyBub3Qgd3JpdHRlbiBhbnl3aGVyZSwgaXMgdGhhdCBp bnRlbnRpb25hbD8KPj4+Cj4+PiBTYW1lIGZvciB5b3VyIHR0eSBtYWpvci9taW5vciwgd2hhdCBu dW1iZXJzIGFyZSB5b3UgdXNpbmcgdGhhdCBtaWdodAo+Pj4gYWxzbyBiZSBpbiB1c2UgYnkgYSBk aWZmZXJlbnQgZGV2aWNlIGluIHRoZSBzeXN0ZW0/Cj4+Pgo+Pj4gdGhhbmtzLAo+Pj4KPj4+IGdy ZWcgay1oCj4+IEkgd2lsbCBhZGQgZGVzY3JpcHRpb24gYWJvdXQgdGhlIHR0eSBuYW1lIHRvIHRo ZSBsb2cuCj4+IEluIHByYWN0aWNhbCB0ZXN0aW5nLCB3ZSBzcGVjaWZpZWQgaW4gdGhlIHUtYm9v dCBwYXJhbWV0ZXJzCj4+IHRvIHVzZSB0dHlOVlQwIGZvciB0aGUgY29uc29sZSwgYW5kIGl0IHdv cmtlZCBmaW5lLgo+IFdoZXJlIGRpZCB5b3UgcGljayB0aGF0IG5hbWUgZnJvbT8gIFdoeSBjYW4n dCB5b3UgdXNlIHRoZSAiZGVmYXVsdCIgdWFydAo+IG5hbWUgaW5zdGVhZD8KPgo+IEkgdGhvdWdo dCB3ZSBoYWQgYSBsaXN0IG9mIHR0eSBuYW1lcyBhcm91bmQgc29tZXdoZXJlLCBidXQgSSBjYW4n dCBmaW5kCj4gaXQgcmlnaHQgbm93Li4uCj4KPiB0aGFua3MsCj4KPiBncmVnIGstaAoKSW5pdGlh bGx5LCB3ZSB3ZXJlIHVzaW5nIHRoZSB3ZWxsLWtub3duIHR0eVMsIGJ1dCBpdCBpcyB1c2VkIGJ5 IHRoZSA4MjUwIApkcml2ZXIuClNpbmNlIHRoZSBNQTM1RDEgVUFSVCBpcyBpbmNvbXBhdGlibGUg d2l0aCB0aGUgODI1MCBkcml2ZXIsIEFuZHIgcmFpc2VkCmNvbmNlcm5zIGFib3V0IHVzaW5nIHR0 eVMuCgpUbyBkaWZmZXJlbnRpYXRlIHRoaXMgVUFSVCBmcm9tIHRoZSBpbmNvbXBhdGlibGUgODI1 MCwgd2UgZGVmaW5lZCB0dHlOVlQuClRoaXMgbmFtZSBpcyBzcGVjaWZpZWQgaW4gdGhlIGRyaXZl cidzIFVBUlQgbmFtZSBhbmQgY29uc29sZSBuYW1lCnN0cnVjdHVyZSwgYW5kIG90aGVyIHNlcmlh bCBkcml2ZXJzIGZvbGxvdyBhIHNpbWlsYXIgYXBwcm9hY2guIEZvciBleGFtcGxlLAp3ZSBjYW4g ZmluZCBuYW1lcyBsaWtlIHR0eVNBLCB0dHlTQUMsIHR0eVNDLCB0dHlTSUYsIHR0eVNUTSwgdHR5 U1VQLAphbmQgc28gb24uCgpJZiB5b3UgYmVsaWV2ZSB0aGF0IHRoaXMgVUFSVCBkcml2ZXIgY2Fu IHVzZSB0dHlTLCBJIGFtIG1vcmUgdGhhbiB3aWxsaW5nIHRvCm1ha2UgdGhlIG1vZGlmaWNhdGlv bi4gQWZ0ZXIgYWxsLCBzb21lIGFwcGxpY2F0aW9ucyBhbmQgc2NyaXB0cyBkZWZhdWx0IHRvCnVz aW5nIHR0eVMsIGFuZCB1c2luZyB0dHlOVlQgY2FuIGluZGVlZCBjYXVzZSBzb21lIGluY29udmVu aWVuY2UgaW4KY2VydGFpbiBzaXR1YXRpb25zLgoKQmVzdCByZWdhcmRzLApKYWNreSBIdWFuZwoK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==