From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7tbj-0000mh-Af for qemu-devel@nongnu.org; Thu, 26 Oct 2017 21:38:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7tbf-0005ee-E8 for qemu-devel@nongnu.org; Thu, 26 Oct 2017 21:38:47 -0400 Received: from mga07.intel.com ([134.134.136.100]:38285) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e7tbf-0005cp-3Q for qemu-devel@nongnu.org; Thu, 26 Oct 2017 21:38:43 -0400 References: <1502842933-8323-1-git-send-email-tianyu.lan@intel.com> <34042934-782b-6bcc-b9b2-de7a1816cfb7@redhat.com> <3ababa62-f055-5bbb-b9b9-c55ada8368dd@intel.com> <20170818163854.GY3108@localhost.localdomain> <471a4bdc-d381-4a70-0107-3150df6f5cf6@intel.com> <20171026121943.GB26955@localhost.localdomain> <20171026172631-mutt-send-email-mst@kernel.org> From: Lan Tianyu Message-ID: Date: Fri, 27 Oct 2017 09:30:59 +0800 MIME-Version: 1.0 In-Reply-To: <20171026172631-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Eduardo Habkost Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, anthony.perard@citrix.com, Paolo Bonzini , rth@twiddle.net On 2017年10月26日 22:27, Michael S. Tsirkin wrote: > On Thu, Oct 26, 2017 at 02:19:43PM +0200, Eduardo Habkost wrote: >> On Mon, Aug 21, 2017 at 10:22:15AM +0800, Lan Tianyu wrote: >>> On 2017年08月19日 00:38, Eduardo Habkost wrote: >>>> On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote: >>>>> On 2017年08月16日 19:21, Paolo Bonzini wrote: >>>>>> On 16/08/2017 02:22, Lan Tianyu wrote: >>>>>>> Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU >>>>>>> check for Xen here when vcpu number is more than 255. >>>>>> >>>>>> I think you still need to do a check for vIOMMU being enabled. >>>>> >>>>> Yes, this will be done in the Xen tool stack and Qemu doesn't have such >>>>> knowledge. Operations of create, destroy Xen vIOMMU will be done in the >>>>> Xen tool stack. >>>> >>>> Shouldn't we make QEMU have knowledge of the vIOMMU device, then? >>>> Won't QEMU need to know about it eventually? >>>> >>> >>> Hi Eduardo: >>> Thanks for your review. >>> Xen has some guest modes which doesn't use Qemu and we tried to >>> make Xen vIOMMU framework compatible with all guest modes. So far, we >>> are adding interrupt remapping function for Xen vIOMMU and find qemu >>> doesn't need to know Xen vIOMMU. The check of vcpu number > 255 here >>> will be done in Xen side and so skip the check in Qemu to avoid blocking >>> Xen creating >255 vcpus. >>> We may make Qemu have knowledge of the vIOMMU device if it's >>> necessary when adding new function. >> >> I was expecting it to go through the PC tree, but I will queue it >> on x86-next instead. > > I was waiting for an ack from you or Paolo as you participated in the > discussion. But sure, go ahead > > Acked-by: Michael S. Tsirkin > Great. Thanks. -- Best regards Tianyu Lan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lan Tianyu Subject: Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen Date: Fri, 27 Oct 2017 09:30:59 +0800 Message-ID: References: <1502842933-8323-1-git-send-email-tianyu.lan@intel.com> <34042934-782b-6bcc-b9b2-de7a1816cfb7@redhat.com> <3ababa62-f055-5bbb-b9b9-c55ada8368dd@intel.com> <20170818163854.GY3108@localhost.localdomain> <471a4bdc-d381-4a70-0107-3150df6f5cf6@intel.com> <20171026121943.GB26955@localhost.localdomain> <20171026172631-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7tbg-0005Xz-Rq for xen-devel@lists.xenproject.org; Fri, 27 Oct 2017 01:38:44 +0000 In-Reply-To: <20171026172631-mutt-send-email-mst@kernel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: "Michael S. Tsirkin" , Eduardo Habkost Cc: anthony.perard@citrix.com, xen-devel@lists.xenproject.org, rth@twiddle.net, qemu-devel@nongnu.org, Paolo Bonzini List-Id: xen-devel@lists.xenproject.org T24gMjAxN+W5tDEw5pyIMjbml6UgMjI6MjcsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90ZToKPiBP biBUaHUsIE9jdCAyNiwgMjAxNyBhdCAwMjoxOTo0M1BNICswMjAwLCBFZHVhcmRvIEhhYmtvc3Qg d3JvdGU6Cj4+IE9uIE1vbiwgQXVnIDIxLCAyMDE3IGF0IDEwOjIyOjE1QU0gKzA4MDAsIExhbiBU aWFueXUgd3JvdGU6Cj4+PiBPbiAyMDE35bm0MDjmnIgxOeaXpSAwMDozOCwgRWR1YXJkbyBIYWJr b3N0IHdyb3RlOgo+Pj4+IE9uIFRodSwgQXVnIDE3LCAyMDE3IGF0IDA5OjM3OjEwQU0gKzA4MDAs IExhbiBUaWFueXUgd3JvdGU6Cj4+Pj4+IE9uIDIwMTflubQwOOaciDE25pelIDE5OjIxLCBQYW9s byBCb256aW5pIHdyb3RlOgo+Pj4+Pj4gT24gMTYvMDgvMjAxNyAwMjoyMiwgTGFuIFRpYW55dSB3 cm90ZToKPj4+Pj4+PiBYZW4gdklPTU1VIGRldmljZSBtb2RlbCB3aWxsIGJlIGluIFhlbiBoeXBl cnZpc29yLiBTa2lwIHZJT01NVQo+Pj4+Pj4+IGNoZWNrIGZvciBYZW4gaGVyZSB3aGVuIHZjcHUg bnVtYmVyIGlzIG1vcmUgdGhhbiAyNTUuCj4+Pj4+Pgo+Pj4+Pj4gSSB0aGluayB5b3Ugc3RpbGwg bmVlZCB0byBkbyBhIGNoZWNrIGZvciB2SU9NTVUgYmVpbmcgZW5hYmxlZC4KPj4+Pj4KPj4+Pj4g WWVzLCB0aGlzIHdpbGwgYmUgZG9uZSBpbiB0aGUgWGVuIHRvb2wgc3RhY2sgYW5kIFFlbXUgZG9l c24ndCBoYXZlIHN1Y2gKPj4+Pj4ga25vd2xlZGdlLiBPcGVyYXRpb25zIG9mIGNyZWF0ZSwgZGVz dHJveSBYZW4gdklPTU1VIHdpbGwgYmUgZG9uZSBpbiB0aGUKPj4+Pj4gWGVuIHRvb2wgc3RhY2su Cj4+Pj4KPj4+PiBTaG91bGRuJ3Qgd2UgbWFrZSBRRU1VIGhhdmUga25vd2xlZGdlIG9mIHRoZSB2 SU9NTVUgZGV2aWNlLCB0aGVuPwo+Pj4+IFdvbid0IFFFTVUgbmVlZCB0byBrbm93IGFib3V0IGl0 IGV2ZW50dWFsbHk/Cj4+Pj4KPj4+Cj4+PiBIaSBFZHVhcmRvOgo+Pj4gICAgICBUaGFua3MgZm9y IHlvdXIgcmV2aWV3Lgo+Pj4gICAgICBYZW4gaGFzIHNvbWUgZ3Vlc3QgbW9kZXMgd2hpY2ggZG9l c24ndCB1c2UgUWVtdSBhbmQgd2UgdHJpZWQgdG8KPj4+IG1ha2UgWGVuIHZJT01NVSBmcmFtZXdv cmsgY29tcGF0aWJsZSB3aXRoIGFsbCBndWVzdCBtb2Rlcy4gU28gZmFyLCB3ZQo+Pj4gYXJlIGFk ZGluZyBpbnRlcnJ1cHQgcmVtYXBwaW5nIGZ1bmN0aW9uIGZvciBYZW4gdklPTU1VIGFuZCBmaW5k IHFlbXUKPj4+IGRvZXNuJ3QgbmVlZCB0byBrbm93IFhlbiB2SU9NTVUuIFRoZSBjaGVjayBvZiB2 Y3B1IG51bWJlciA+IDI1NSBoZXJlCj4+PiB3aWxsIGJlIGRvbmUgaW4gWGVuIHNpZGUgYW5kIHNv IHNraXAgdGhlIGNoZWNrIGluIFFlbXUgdG8gYXZvaWQgYmxvY2tpbmcKPj4+IFhlbiBjcmVhdGlu ZyA+MjU1IHZjcHVzLgo+Pj4gICAgICBXZSBtYXkgbWFrZSBRZW11IGhhdmUga25vd2xlZGdlIG9m IHRoZSB2SU9NTVUgZGV2aWNlIGlmIGl0J3MKPj4+IG5lY2Vzc2FyeSB3aGVuIGFkZGluZyBuZXcg ZnVuY3Rpb24uCj4+Cj4+IEkgd2FzIGV4cGVjdGluZyBpdCB0byBnbyB0aHJvdWdoIHRoZSBQQyB0 cmVlLCBidXQgSSB3aWxsIHF1ZXVlIGl0Cj4+IG9uIHg4Ni1uZXh0IGluc3RlYWQuCj4gCj4gSSB3 YXMgd2FpdGluZyBmb3IgYW4gYWNrIGZyb20geW91IG9yIFBhb2xvIGFzIHlvdSBwYXJ0aWNpcGF0 ZWQgaW4gdGhlCj4gZGlzY3Vzc2lvbi4gQnV0IHN1cmUsIGdvIGFoZWFkCj4gCj4gQWNrZWQtYnk6 IE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+Cj4gCgpHcmVhdC4gVGhhbmtzLgot LSAKQmVzdCByZWdhcmRzClRpYW55dSBMYW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3Rz Lnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=