From: Dave Jiang <dave.jiang@intel.com>
To: marc.herbert@linux.intel.com, linux-cxl@vger.kernel.org,
nvdimm@lists.linux.dev
Subject: Re: [PATCH] test/meson.build: add missing 'CXL=@0@'.format(cxl_tool.full_path()),
Date: Wed, 7 May 2025 15:41:12 -0700 [thread overview]
Message-ID: <a34e0710-eed9-4010-a7ae-89c6af233cc2@intel.com> (raw)
In-Reply-To: <20250507161547.204216-1-marc.herbert@linux.intel.com>
On 5/7/25 9:15 AM, marc.herbert@linux.intel.com wrote:
> From: Marc Herbert <marc.herbert@linux.intel.com>
>
> This fixes the ability to copy and paste the helpful meson output when a
> test fails, in order to re-run a failing test directly outside meson and
> from any current directory.
>
> meson never had that problem because it always switches to a constant
> directory before running the tests.
>
> Fixes commit ef85ab79e7a4 ("cxl/test: Add topology enumeration and
> hotplug test") which added the (failing) search for the cxl binary.
>
> Signed-off-by: Marc Herbert <marc.herbert@linux.intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> test/meson.build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/meson.build b/test/meson.build
> index d871e28e17ce..2fd7df5211dd 100644
> --- a/test/meson.build
> +++ b/test/meson.build
> @@ -255,6 +255,7 @@ foreach t : tests
> env : [
> 'NDCTL=@0@'.format(ndctl_tool.full_path()),
> 'DAXCTL=@0@'.format(daxctl_tool.full_path()),
> + 'CXL=@0@'.format(cxl_tool.full_path()),
> 'TEST_PATH=@0@'.format(meson.current_build_dir()),
> 'DATA_PATH=@0@'.format(meson.current_source_dir()),
> ],
next prev parent reply other threads:[~2025-05-07 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 16:15 [PATCH] test/meson.build: add missing 'CXL=@0@'.format(cxl_tool.full_path()), marc.herbert
2025-05-07 21:52 ` Dan Williams
2025-05-07 22:41 ` Dave Jiang [this message]
2025-05-08 2:14 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a34e0710-eed9-4010-a7ae-89c6af233cc2@intel.com \
--to=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=marc.herbert@linux.intel.com \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.