From: Frank Rowand <frowand.list@gmail.com>
To: Douglas Anderson <dianders@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Kees Cook <keescook@chromium.org>
Cc: linux-rockchip@lists.infradead.org, jwerner@chromium.org,
groeck@chromium.org, briannorris@chromium.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: Add dummy for of_node_is_root if not CONFIG_OF
Date: Tue, 7 May 2019 10:52:06 -0700 [thread overview]
Message-ID: <a3573253-e3de-0a82-8af3-6bacea20bd97@gmail.com> (raw)
In-Reply-To: <20190507044801.250396-1-dianders@chromium.org>
On 5/6/19 9:48 PM, Douglas Anderson wrote:
> We'll add a dummy to just return false.
A more complete explanation of why this is needed please.
My one guess would be compile testing of arch/sparc/kernel/prom_64.c
fails???
-Frank
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> include/linux/of.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 0cf857012f11..62ae5c1cafa5 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -653,6 +653,11 @@ static inline bool of_have_populated_dt(void)
> return false;
> }
>
> +static inline bool of_node_is_root(const struct device_node *node)
> +{
> + return false;
> +}
> +
> static inline struct device_node *of_get_compatible_child(const struct device_node *parent,
> const char *compatible)
> {
>
next prev parent reply other threads:[~2019-05-07 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 4:48 [PATCH] of: Add dummy for of_node_is_root if not CONFIG_OF Douglas Anderson
2019-05-07 14:52 ` Guenter Roeck
2019-05-07 17:52 ` Frank Rowand [this message]
2019-05-07 17:59 ` Doug Anderson
2019-05-07 21:15 ` Kees Cook
2019-05-07 22:17 ` Frank Rowand
2019-05-08 15:51 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3573253-e3de-0a82-8af3-6bacea20bd97@gmail.com \
--to=frowand.list@gmail.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=jwerner@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.