From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCFBCC433EF for ; Mon, 23 May 2022 13:20:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 93EB080544; Mon, 23 May 2022 15:20:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.b="qj3YODOg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1C70E83F63; Mon, 23 May 2022 15:20:00 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 52AEA802F4 for ; Mon, 23 May 2022 15:19:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=eajames@linux.ibm.com Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24NCRhqA027536; Mon, 23 May 2022 13:19:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=WrsAb0Z7T7Ros/IB7KlsXKuYTHmWZYaRKvJy5sj95Fk=; b=qj3YODOgMhb7XQKy6Jpxh5V8XmzV5Ok+TsuViY5ujwGM5X9zi/ouR5yc9WhfW+7Cub5i JP3lXRJUF1Y1rjl/BfmMLoBwFDFfkvBtl/jJn8udQU8n6WMbYp+QEr39wuAeqDz25a4n rl9H/wA/QFuUeie0BNOqQ1nJRECaaS/wIfG2rzffd4DXSpGywtsKCYb9Pt+z3oMVudLN 5QrRl1Dpe7NzATTjdemkUL4Ricwl0vpUiRkm12r3iQJb+5V0Hf7cLDMqQ3J0bGnYNNqR 09x3mMPSpXmH8B3FNmfrxvxuOip2s4e0vbetHwMylExsA26RBeMurmalhnQRw2MGkVSV mQ== Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g8a9y95yd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 May 2022 13:19:54 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24NDHqnf006325; Mon, 23 May 2022 13:19:53 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma03wdc.us.ibm.com with ESMTP id 3g6qq9g99m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 May 2022 13:19:53 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24NDJqxG63373738 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 May 2022 13:19:52 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9F295AC064; Mon, 23 May 2022 13:19:52 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5AEC9AC05E; Mon, 23 May 2022 13:19:52 +0000 (GMT) Received: from [9.211.85.51] (unknown [9.211.85.51]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 23 May 2022 13:19:52 +0000 (GMT) Message-ID: Date: Mon, 23 May 2022 08:19:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] tpm: add support for TPMv2.x I2C chips Content-Language: en-US To: Ilias Apalodimas Cc: u-boot@lists.denx.de References: <20220513183000.47392-1-eajames@linux.ibm.com> <20220513183000.47392-3-eajames@linux.ibm.com> From: Eddie James In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: TIzxevCsgFf0EzsdjPFcSFnHFXlBdtrx X-Proofpoint-ORIG-GUID: TIzxevCsgFf0EzsdjPFcSFnHFXlBdtrx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-23_06,2022-05-23_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205230073 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 5/23/22 01:12, Ilias Apalodimas wrote: > Hi Eddie, > > Thanks for the patch. > > [...] > >> +static const struct tpm_tis_chip_data tpm_tis_std_chip_data = { >> + .pcr_count = 24, >> + .pcr_select_min = 3, >> +}; >> + >> +static const struct udevice_id tpm_tis_i2c_ids[] = { >> + { >> + .compatible = "nuvoton,npct75x", >> + .data = (ulong)&tpm_tis_std_chip_data, >> + }, >> + { >> + .compatible = "tcg,tpm-tis-i2c", >> + .data = (ulong)&tpm_tis_std_chip_data, >> + }, >> + { } >> +}; >> + >> +U_BOOT_DRIVER(tpm_tis_i2c) = { >> + .name = "tpm_tis_i2c", >> + .id = UCLASS_TPM, >> + .of_match = tpm_tis_i2c_ids, >> + .ops = &tpm_tis_i2c_ops, >> + .probe = tpm_tis_i2c_probe, >> + .remove = tpm_tis_i2c_remove, >> + .priv_auto_alloc_size = sizeof(struct tpm_chip), > Shouldn't this be .priv_auto only? IIRC we got rid of the > .priv_auto_alloc_size a while back? If so I can fix this while merging Yes, I think so. I tested with an older u-boot (openbmc uses a modified v2019.04) with all the TPM core patches, and I think I missed this bit in rebasing. Thanks, Eddie > > Regards > /Ilias > >> +}; >> -- >> 2.27.0 >>