From: Ulrich Drepper <drepper@gmail.com>
To: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Subject: Re: [PATCH] fix xenU kernel crash in dmi_iterate
Date: Fri, 14 Jan 2005 14:03:04 -0800 [thread overview]
Message-ID: <a36005b50501141403395e8558@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0501141446010.2701@chimarrao.boston.redhat.com>
On Fri, 14 Jan 2005 14:49:10 -0500 (EST), Rik van Riel <riel@redhat.com> wrote:
> char __iomem *p, *q;
>
> for (p = q = ioremap(0xF0000, 0x10000); q < p + 0x10000; q += 16) {
> + if (p == NULL)
> + return -1;
> memcpy_fromio(buf, q, 15);
> if(memcmp(buf, "_DMI_", 5)==0 && dmi_checksum(buf))
> {
SInce p is not modified in the loop, this certainly should look like this
p = ioremap(0xF0000, 0x10000);
if (p == NULL)
return -1;
for (q = p; q < p + 0x10000; q += 16) {
memcpy_fromio(buf, q, 15);
...
prev parent reply other threads:[~2005-01-14 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-14 19:49 [PATCH] fix xenU kernel crash in dmi_iterate Rik van Riel
2005-01-14 22:03 ` Ulrich Drepper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a36005b50501141403395e8558@mail.gmail.com \
--to=drepper@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m+Ian.Pratt@cl.cam.ac.uk \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.