From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF Date: Mon, 3 Oct 2016 09:39:25 -0400 Message-ID: References: <1475115167-5898-1-git-send-email-okaya@codeaurora.org> <1475115167-5898-5-git-send-email-okaya@codeaurora.org> <20161001061710.GF2467@localhost> <20161003033851.GP2467@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161003033851.GP2467@localhost> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vinod Koul Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Dan Williams , Wei Yongjun , Andy Shevchenko , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On 10/2/2016 11:38 PM, Vinod Koul wrote: >> I followed the pattern in of_platform_device_create_pdata function. of_msi_configure does >> > nothing if MSI is not enabled as irq_find_matching_host returns NULL. It didn't have any >> > side effects on my testing either. > yeah later on I did look up the of_msi_configure() and I suspected this. I > think it would be worthwhile to document this assumption here. Sure, let me do that. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org (Sinan Kaya) Date: Mon, 3 Oct 2016 09:39:25 -0400 Subject: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF In-Reply-To: <20161003033851.GP2467@localhost> References: <1475115167-5898-1-git-send-email-okaya@codeaurora.org> <1475115167-5898-5-git-send-email-okaya@codeaurora.org> <20161001061710.GF2467@localhost> <20161003033851.GP2467@localhost> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/2/2016 11:38 PM, Vinod Koul wrote: >> I followed the pattern in of_platform_device_create_pdata function. of_msi_configure does >> > nothing if MSI is not enabled as irq_find_matching_host returns NULL. It didn't have any >> > side effects on my testing either. > yeah later on I did look up the of_msi_configure() and I suspected this. I > think it would be worthwhile to document this assumption here. Sure, let me do that. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbcJCNjk (ORCPT ); Mon, 3 Oct 2016 09:39:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49364 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbcJCNj3 (ORCPT ); Mon, 3 Oct 2016 09:39:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org CD5B761787 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF To: Vinod Koul References: <1475115167-5898-1-git-send-email-okaya@codeaurora.org> <1475115167-5898-5-git-send-email-okaya@codeaurora.org> <20161001061710.GF2467@localhost> <20161003033851.GP2467@localhost> Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com, agross@codeaurora.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dan Williams , Wei Yongjun , Andy Shevchenko , linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: Date: Mon, 3 Oct 2016 09:39:25 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161003033851.GP2467@localhost> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/2/2016 11:38 PM, Vinod Koul wrote: >> I followed the pattern in of_platform_device_create_pdata function. of_msi_configure does >> > nothing if MSI is not enabled as irq_find_matching_host returns NULL. It didn't have any >> > side effects on my testing either. > yeah later on I did look up the of_msi_configure() and I suspected this. I > think it would be worthwhile to document this assumption here. Sure, let me do that. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.