From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A84C2C433E1 for ; Wed, 19 Aug 2020 21:15:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5456C2063A for ; Wed, 19 Aug 2020 21:15:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ml4xzU82"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="e97zR/N5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5456C2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LZ+UIimeCnvQWgTyx72retERdyNkCPMDzx1fVgTKOao=; b=ml4xzU827tfTfjUjakvC09MYo SB0+eOouYzhYppUqSIxh2xDYwk30+JAAmqq0z5QwM4ycLXEps6pGFvS4tyT0D9WOc7w8qXyZg+vXz d0KxG6oBqMCYU3oTpb+zWt4btc/zA/jhu3vHWFWPw+F8ACzwZhUge2oth5JuA++3lxmtzn21KvGLk Q3wXe0q64wWw9a8ahdyA/IPVqUuixY/QPPwjHuu1dmySCAMWG0ijAN3sDPJ8815hLFi9nOQw88Uie Azj0Fsop7TZ0uZQXO1v04n0p6yzcm61SrDfFw8BOtooqc9mNDwmJ2n7UTHKb1nWAskWgRwC86ycQ+ R+OQpYvkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8VPn-0007nA-GN; Wed, 19 Aug 2020 21:14:35 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8VPk-0007l3-5S for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 21:14:34 +0000 Received: by mail-pg1-x544.google.com with SMTP id 128so87147pgd.5 for ; Wed, 19 Aug 2020 14:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6vl0Zr0QfPTPUxp3kmQVySN90fESLhsCVNDcmlPX5ao=; b=e97zR/N5o7Lz0AtqgugSva+F5lMAwSyEab6QESo7q2edZiuLdMYTgJcKlI35zU8Ytq AidBIz2PBjBlhHt6rTBvoAStn4NGEwn4iOia1EP0AooRUq6RxB+Ms1Dl6tGcqeSjOMVm p+5j4NMwCvNfiyWtmw+dXNpins8XGzW5Tz6lI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6vl0Zr0QfPTPUxp3kmQVySN90fESLhsCVNDcmlPX5ao=; b=AgUMzoaGOZMDlpKkQNgVHwikN0nsl56fOOtVBdHeqMxnuBNOLniWv+FDV2qzuiPKaz Uz1VVXOg6jYY+NuAhy11qtfYxME3YClfsOdvBHgMzg2cS7N+d56dd0BpTr4Xo95oSzHv b66/f4yV+rdHST2GSXHSWpRbuRWOPPofJVDI5o2PEBbWTDKFBXFdZa/7Dj3xJEJLqEQN V0ACcMZ8HBn9EXBL/X5HEBjlN0Z0Wk30H/ZZXCLcBUAUlOTkV6lw4IE3S0YDOjAKBRdj um/Sm80RpGY738NVssW+9j5amGE2XRUIs1If5eYWUYDw/zyunQMIK6ZIXodGi9w4SnUa 7INg== X-Gm-Message-State: AOAM530UsBW3nctYHQ9iFMU24JRCoLcGlW1hABf2x5wsFpv+O6xfoe1S NbSm5PL2SvEXaeDJCX5iNZWXnQ== X-Google-Smtp-Source: ABdhPJyIsZqKw66CYKr8tbkC1zsYXVMa5TLygt5HGOeUvNsPQA9V/AoHAd7Q3oSpC7rY7R5GYSzPMQ== X-Received: by 2002:a65:5849:: with SMTP id s9mr217988pgr.145.1597871667999; Wed, 19 Aug 2020 14:14:27 -0700 (PDT) Received: from [10.136.8.253] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id e20sm3981728pjr.28.2020.08.19.14.14.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2020 14:14:27 -0700 (PDT) Subject: Re: [PATCH] ARM: dts: BCM5301X: Fix pin controller node To: Florian Fainelli , Christian Lamparter , linux-arm-kernel@lists.infradead.org References: <20200819042308.19043-1-f.fainelli@gmail.com> <7501cb2f-ea5a-8339-40a0-6706fea32a06@gmail.com> <62f89d06-e6ef-9476-1797-bec153d8e6db@gmail.com> From: Ray Jui Message-ID: Date: Wed, 19 Aug 2020 14:14:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <62f89d06-e6ef-9476-1797-bec153d8e6db@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_171432_254525_B2EA3378 X-CRM114-Status: GOOD ( 22.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , open list , Rob Herring , "maintainer:BROADCOM BCM5301X ARM ARCHITECTURE" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA4LzE5LzIwMjAgMTo0OSBQTSwgRmxvcmlhbiBGYWluZWxsaSB3cm90ZToKPiBPbiA4LzE5 LzIwIDE6NDggUE0sIENocmlzdGlhbiBMYW1wYXJ0ZXIgd3JvdGU6Cj4+IE9uIDIwMjAtMDgtMTkg MDY6MjMsIEZsb3JpYW4gRmFpbmVsbGkgd3JvdGU6Cj4+PiBUaGUgcGluIGNvbnRyb2xsZXIgcmVz b3VyY2VzIHN0YXJ0IGF0IDB4YzAgZnJvbSB0aGUgQ1JVIGJhc2Ugd2hpY2ggaXMgYXQKPj4+IDB4 MTAwIGZyb20gdGggRE1VIGJhc2UsIGZvciBhIGZpbmFsIGFkZHJlc3Mgb2YgMHgxODAwX2MxYzAs IHdoZXJlYXMgd2UKPj4+IGFyZSBjdXJyZW50bHkgb2ZmIGJ5IDB4MTAwLiBUaGUgcmVzb3VyY2Ug c2l6ZSBvZiB0aGUgQ1JVIGlzIGFsc28KPj4+IGluY29ycmVjdCBhbmQgc2hvdWxkIGVuZCBhdCAw eDI0OCBieXRlcyBmcm9tIDB4MTAwIHdoaWNoIGlzIHRoZSBzdGFydAo+Pj4gYWRkcmVzcy4gRmlu YWxseSwgdGhlIGNvbXBhdGliaWxpdHkgc3RyaW5ncyBkZWZpbmVkIGZvciB0aGUKPj4+IHBpbi1j b250cm9sbGVyIG5vZGUgc2hvdWxkIHJlZmxlY3QgdGhlIFNvQyBiZWluZyB1c2VkLgo+Pj4KPj4+ IEZpeGVzOiA5OTk0MjQxYWM5N2MgKCJBUk06IGR0czogQkNNNTMwMVg6IERlc2NyaWJlIE5vcnRo c3RhciBwaW5zIG11eAo+Pj4gY29udHJvbGxlciIpCj4+PiBSZXBvcnRlZC1ieTogQ2hyaXN0aWFu IExhbXBhcnRlciA8Y2h1bmtlZXlAZ21haWwuY29tPgo+Pj4gU2lnbmVkLW9mZi1ieTogRmxvcmlh biBGYWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+Cj4+PiAtLS0KPj4+IENocmlzdGlhbiwg Y2FuIHlvdSB0ZXN0IHRoaXMgYXMgYSBwcmVsaW1pbmFyeSBwYXRjaCBmb3IgeW91ciBDaXNjbwo+ Pj4gTWVyYWtpIE1SMzIgc2VyaWVzPyBUaGFua3MhCj4+Cj4+IEhtLCBpdCBsb29rcyBsaWtlIHRo aXMgaXMgbW9yZSBjb21wbGljYXRlZCB0aGFuIHRoaXMuIFdlIHNob3VsZCBoYXZlCj4+IGxvb2tl ZCBhdCBwaW5jdHJsLW5zLmMncyBuc19waW5jdHJsX3Byb2JlKCkgWzBdIGJlZm9yZSBjYWxsaW5n IGl0Lgo+Pgo+PiB8wqDCoMKgIG5zX3BpbmN0cmwtPnJlZ21hcCA9IHN5c2Nvbl9ub2RlX3RvX3Jl Z21hcChvZl9nZXRfcGFyZW50KG5wKSk7Cj4+IHzCoMKgwqAgaWYgKElTX0VSUihuc19waW5jdHJs LT5yZWdtYXApKSB7Cj4+IHzCoMKgwqDCoMKgwqDCoCBpbnQgZXJyID0gUFRSX0VSUihuc19waW5j dHJsLT5yZWdtYXApOwo+PiB8Cj4+IHzCoMKgwqDCoMKgwqDCoCBkZXZfZXJyKGRldiwgIkZhaWxl ZCB0byBtYXAgcGluY3RybCByZWdzOiAlZFxuIiwgZXJyKTsKPj4gfAo+PiB8wqDCoMKgwqDCoMKg wqAgcmV0dXJuIGVycjsKPj4gfMKgwqDCoCB9Cj4+IHwKPj4gfMKgwqDCoCBpZiAob2ZfcHJvcGVy dHlfcmVhZF91MzIobnAsICJvZmZzZXQiLCAmbnNfcGluY3RybC0+b2Zmc2V0KSkgewo+PiB8wqDC oMKgwqDCoMKgwqAgZGV2X2VycihkZXYsICJGYWlsZWQgdG8gZ2V0IHJlZ2lzdGVyIG9mZnNldFxu Iik7Cj4+IHzCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVOT0VOVDsKPj4gfMKgwqDCoCB9Cj4+Cj4+ IFNvLCB0aGUgbnNfcGluY3RybF9wcm9iZSgpIHRha2VzIHRoZSBhZGRyZXNzIG9mIHRoZSBwYXJl bnQgbm9kZSAoY3J1KQo+PiBhbmQgdGhlbiBsb29rcyBmb3IgYSAib2Zmc2V0IiBwcm9wZXJ0eSB0 byBhZGQgdG8gdGhpcyAod2hpY2ggaXMgbWlzc2luZwo+PiBpbiB0aGUgYmNtNTMwMXguZHRzaSBb MV0pLgo+Pgo+PiBUaGluZyBpcywgZm9yIHRoaXMgdG8gd29yaywgdGhlIHBhcmVudC1ub2RlIHNo b3VsZCBiZSBhICJzaW1wbGUtbWZkIiAoc28KPj4gYSByZWdtYXAgaXMgY3JlYXRlZCBmb3IgdGhl IHJlZyksIHJpZ2h0PyBUaGlzIHdvdWxkIGFsc28gbWVhbiB0aGF0IHRoZQo+PiAicmVnIiBwcm9w ZXJ0eSBpbiB0aGUgcGluLWNvbnRyb2xsZXIgbm9kZSBpcyBqdXN0IGNvc21ldGljLgo+Pgo+PiBJ IGd1ZXNzIHRoZSByZWFzb24gd2h5IHRoaXMgc29ydC1vZi13b3JrcyBmb3IgbWUgaXMgYmVjYXVz ZSBJJ20gdXNpbmcKPj4gdGhpcyBNUjMyIHdpdGggT3BlbldydCAoUmFmYcWCIE1pxYJlY2tpIGlz IHByb2JhYmx5IHVzaW5nIGl0IHRvbyA7KSApLgo+Pgo+PiAoTm90ZTogV2Ugc2hvdWxkIG5vdCBm b3JnZXQgdG8gdXBkYXRlIHRoZSBiaW5kaW5nLWRvY3VtZW50YXRpb24gYXMgd2VsbCEpCj4+Cj4+ IEJUVzogSSdsbCByZXBseSBteSBmaW5kaW5ncyBmb3IgdGhlIGkyYyBpc3N1ZSB3aXRoIHRoZSBN UjMyIGluIHRoZSBvdGhlcgo+PiBtYWlsLgo+IAo+IFJhZmFsLCBoYXMgdGhpcyBkcml2ZXIgZXZl ciB3b3JrZWQgdG8gYmVnaW4gd2l0aD8gTm9uZSBvZiB0aGlzIHNob3VsZCBiZQo+IG5lY2Vzc2Fy eSwgd2Ugc2hvdWxkIGp1c3QgYmUgdXNpbmcgYSBzaW1wbGUgcGxhdGZvcm0gZGV2aWNlIHJlc291 cmNlIGhlcmUuCj4gCgpGbG9yaWFuLCB3aGF0IGlmIENEUlUgaXMgYSBzaGFyZWQgcmVzb3VyY2Ug d2hvc2UgcmVnaXN0ZXJzIGFyZSBhY2Nlc3NlZAphbmQgc2hhcmVkIGJ5IG11bHRpcGxlIGJsb2Nr cyAoYW5kIHRoZXJlZm9yZSBkZXZpY2UgZHJpdmVycykgd2l0aGluIHRoZQpjaGlwPyBUaGVuIGFj Y2Vzc2luZyB0aGlzIHNoYXJlZCBDRFJVIHJlc291cmNlIHRocm91Z2ggc3lzY29uIG1ha2VzIHN1 cmUKdGhlcmUncyBubyByYWNlIGNvbmRpdGlvbiwgaXNuJ3QgaXQ/CgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8357DC433E1 for ; Wed, 19 Aug 2020 21:14:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 466E0207DE for ; Wed, 19 Aug 2020 21:14:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="e97zR/N5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726912AbgHSVO3 (ORCPT ); Wed, 19 Aug 2020 17:14:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726707AbgHSVO2 (ORCPT ); Wed, 19 Aug 2020 17:14:28 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6085C061757 for ; Wed, 19 Aug 2020 14:14:28 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id h12so82326pgm.7 for ; Wed, 19 Aug 2020 14:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6vl0Zr0QfPTPUxp3kmQVySN90fESLhsCVNDcmlPX5ao=; b=e97zR/N5o7Lz0AtqgugSva+F5lMAwSyEab6QESo7q2edZiuLdMYTgJcKlI35zU8Ytq AidBIz2PBjBlhHt6rTBvoAStn4NGEwn4iOia1EP0AooRUq6RxB+Ms1Dl6tGcqeSjOMVm p+5j4NMwCvNfiyWtmw+dXNpins8XGzW5Tz6lI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6vl0Zr0QfPTPUxp3kmQVySN90fESLhsCVNDcmlPX5ao=; b=svaw84cBNQbNiGkdZqRmQ1GblvpvObr81VBC8efv1n9yk9Q/iFOQPILTlmvwHFNxO3 jZztozeX+w+hT0FtUPFXqRIWPzLeR0d9KoUev5MyE7G9ynSdBTMIyobY1odpJZaKRM6b 26oSkjVo6x/9VXwDp8ZMJBi8Kl4/SvUVJnG2DdLyrzCZ0yOYm0PhNZg7lOi4SLUjZW2z PFWD9JKLuPgmBkMyO+UQjVuKjkBhUFj83/zvPdoBhOlYEid+cPWxVF3MRCrxp3nZf/Ez 1vRmij/iyxGvza13xj5IojD15xEColCXx2i1j5VnO4D8hkaWsuQHkIh1VHhjZdibwrug w5AQ== X-Gm-Message-State: AOAM533Ved9DMoZAHDgnWVcVUkaB53XxAjxAQhzXJiD4st9Go3TpKYyl R/B6q5c/PoqmoCGEKAlTGG7h0w== X-Google-Smtp-Source: ABdhPJyIsZqKw66CYKr8tbkC1zsYXVMa5TLygt5HGOeUvNsPQA9V/AoHAd7Q3oSpC7rY7R5GYSzPMQ== X-Received: by 2002:a65:5849:: with SMTP id s9mr217988pgr.145.1597871667999; Wed, 19 Aug 2020 14:14:27 -0700 (PDT) Received: from [10.136.8.253] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id e20sm3981728pjr.28.2020.08.19.14.14.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2020 14:14:27 -0700 (PDT) Subject: Re: [PATCH] ARM: dts: BCM5301X: Fix pin controller node To: Florian Fainelli , Christian Lamparter , linux-arm-kernel@lists.infradead.org Cc: Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "maintainer:BROADCOM BCM5301X ARM ARCHITECTURE" , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20200819042308.19043-1-f.fainelli@gmail.com> <7501cb2f-ea5a-8339-40a0-6706fea32a06@gmail.com> <62f89d06-e6ef-9476-1797-bec153d8e6db@gmail.com> From: Ray Jui Message-ID: Date: Wed, 19 Aug 2020 14:14:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <62f89d06-e6ef-9476-1797-bec153d8e6db@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 8/19/2020 1:49 PM, Florian Fainelli wrote: > On 8/19/20 1:48 PM, Christian Lamparter wrote: >> On 2020-08-19 06:23, Florian Fainelli wrote: >>> The pin controller resources start at 0xc0 from the CRU base which is at >>> 0x100 from th DMU base, for a final address of 0x1800_c1c0, whereas we >>> are currently off by 0x100. The resource size of the CRU is also >>> incorrect and should end at 0x248 bytes from 0x100 which is the start >>> address. Finally, the compatibility strings defined for the >>> pin-controller node should reflect the SoC being used. >>> >>> Fixes: 9994241ac97c ("ARM: dts: BCM5301X: Describe Northstar pins mux >>> controller") >>> Reported-by: Christian Lamparter >>> Signed-off-by: Florian Fainelli >>> --- >>> Christian, can you test this as a preliminary patch for your Cisco >>> Meraki MR32 series? Thanks! >> >> Hm, it looks like this is more complicated than this. We should have >> looked at pinctrl-ns.c's ns_pinctrl_probe() [0] before calling it. >> >> |    ns_pinctrl->regmap = syscon_node_to_regmap(of_get_parent(np)); >> |    if (IS_ERR(ns_pinctrl->regmap)) { >> |        int err = PTR_ERR(ns_pinctrl->regmap); >> | >> |        dev_err(dev, "Failed to map pinctrl regs: %d\n", err); >> | >> |        return err; >> |    } >> | >> |    if (of_property_read_u32(np, "offset", &ns_pinctrl->offset)) { >> |        dev_err(dev, "Failed to get register offset\n"); >> |        return -ENOENT; >> |    } >> >> So, the ns_pinctrl_probe() takes the address of the parent node (cru) >> and then looks for a "offset" property to add to this (which is missing >> in the bcm5301x.dtsi [1]). >> >> Thing is, for this to work, the parent-node should be a "simple-mfd" (so >> a regmap is created for the reg), right? This would also mean that the >> "reg" property in the pin-controller node is just cosmetic. >> >> I guess the reason why this sort-of-works for me is because I'm using >> this MR32 with OpenWrt (Rafał Miłecki is probably using it too ;) ). >> >> (Note: We should not forget to update the binding-documentation as well!) >> >> BTW: I'll reply my findings for the i2c issue with the MR32 in the other >> mail. > > Rafal, has this driver ever worked to begin with? None of this should be > necessary, we should just be using a simple platform device resource here. > Florian, what if CDRU is a shared resource whose registers are accessed and shared by multiple blocks (and therefore device drivers) within the chip? Then accessing this shared CDRU resource through syscon makes sure there's no race condition, isn't it?