From: Nicolai Buchwitz <nb@tipi-net.de>
To: Divyanshu Jha <divyanshuj2006@gmail.com>
Cc: Oliver Neukum <oliver@neukum.org>,
netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: usb: cdc_ncm: add Apple Silicon MacBook Air (05ac:1903) device ID
Date: Fri, 23 Oct 2026 10:57:32 +0200 [thread overview]
Message-ID: <a386789d3d2d6709cc5e9c8b2b05a283@tipi-net.de> (raw)
In-Reply-To: <20261023070419.235361-1-divyanshuj2006@gmail.com>
Hi Divyanshu
On 23.10.2026 09:04, Divyanshu Jha wrote:
> The Apple Silicon MacBook Air exposes a CDC-NCM interface (05ac:1903)
> when connected host-to-host over USB-C.
Which model and chip? a5148bc2fa27 says the MacBook Air shows up as
0x1905, and the Mac PIDs so far (0x1901/0x1902/0x1905) seem to follow
the SoC generation, not the product line?
Please add the lsusb -v or ioreg output for 0x1903 and the dmesg lines
you saw, like the 0x1902 commit did.
>
> Like other Apple CDC-NCM peripherals (0x1902 and 0x1905), Apple's
> firmware omits the CDC status interrupt endpoint. This causes the
> standard cdc_ncm probe to fail with a missing endpoint error.
>
> Add device ID 05ac:1903 to cdc_ncm_devs binding to
nit: cdc_ncm_devs -> cdc_devs
> apple_private_interface_info so the driver bypasses the interrupt
> check and initializes host-to-host networking successfully.
>
> Signed-off-by: Divyanshu Jha <divyanshuj2006@gmail.com>
> ---
> drivers/net/usb/cdc_ncm.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
> index 35db38cb3..6848b9421 100644
> --- a/drivers/net/usb/cdc_ncm.c
> +++ b/drivers/net/usb/cdc_ncm.c
> @@ -2019,6 +2019,12 @@ static const struct usb_device_id cdc_devs[] = {
> { USB_DEVICE_INTERFACE_NUMBER(0x05ac, 0x1902, 2),
> .driver_info = (unsigned long)&apple_private_interface_info,
> },
> + { USB_DEVICE_INTERFACE_NUMBER(0x05ac, 0x1903, 0),
> + .driver_info = (unsigned long)&apple_private_interface_info,
> + },
> + { USB_DEVICE_INTERFACE_NUMBER(0x05ac, 0x1903, 2),
> + .driver_info = (unsigned long)&apple_private_interface_info,
> + },
> { USB_DEVICE_INTERFACE_NUMBER(0x05ac, 0x1905, 0),
> .driver_info = (unsigned long)&apple_private_interface_info,
> },
Please note that net-next is closed during the 7.4 merge window [1].
So please wait until it's open again, before you re-spin.
[1] https://netdev.bots.linux.dev/net-next.html
Thanks,
Nicolai
next prev parent reply other threads:[~2026-10-23 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 7:04 [PATCH net-next] net: usb: cdc_ncm: add Apple Silicon MacBook Air (05ac:1903) device ID Divyanshu Jha
2026-10-23 7:09 ` sashiko-bot
2026-10-23 8:57 ` Nicolai Buchwitz [this message]
[not found] ` <CAGg1W3gd_nyRs6BrAOV=ysKJsQMQTOskv+DpeP=kf+C-o3JXdA@mail.gmail.com>
2026-10-23 14:01 ` Nicolai Buchwitz
2026-10-23 20:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a386789d3d2d6709cc5e9c8b2b05a283@tipi-net.de \
--to=nb@tipi-net.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=divyanshuj2006@gmail.com \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.