From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>
Cc: linux-pm@vger.kernel.org,
Tobias Jordan <Tobias.Jordan@elektrobit.com>,
"4 . 3+" <stable@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / OPP: Add missing of_node_put(np)
Date: Wed, 4 Oct 2017 09:42:05 -0700 [thread overview]
Message-ID: <a3dd282e-220d-5a10-7a0e-10c1acaee737@codeaurora.org> (raw)
In-Reply-To: <3a82b2d3311e16f0f638de18bf0ee803540014a3.1507096875.git.viresh.kumar@linaro.org>
On 10/03/2017 11:05 PM, Viresh Kumar wrote:
> From: Tobias Jordan <Tobias.Jordan@elektrobit.com>
>
> The for_each_available_child_of_node() loop in _of_add_opp_table_v2()
> doesn't drop the reference to "np" on errors. Fix that.
>
> Fixes: 274659029c9d ("PM / OPP: Add support to parse "operating-points-v2" bindings")
> Cc: 4.3+ <stable@vger.kernel.org> # 4.3+
> Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
> [ VK: Improved commit log. ]
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Looks like that opp_table->np = opp_np assignment in this function needs
to do an of_node_get() because the caller of this function puts the
pointer unconditionally.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-10-04 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 6:05 [PATCH] PM / OPP: Add missing of_node_put(np) Viresh Kumar
2017-10-04 16:42 ` Stephen Boyd [this message]
2017-10-05 4:43 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3dd282e-220d-5a10-7a0e-10c1acaee737@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Tobias.Jordan@elektrobit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=stable@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.