Re: [PATCH i-g-t 1/2] lib/amdgpu: add oversized invalid packet length error handling

[vitaly prosyak <vprosyak@amd.com>]

LGTM both patches

Reviewed-by: Vitaly Prosyak <vitaly.prosyak@amd.com>

On 2026-04-07 22:47, Jesse Zhang wrote:
> Add a dedicated cmd error type for oversized packet length and handle
> it in gfx_ring_bad_write_linear().
>
> - add CMD_STREAM_EXEC_INVALID_PACKET_LENGTH_OVERSIZE to cmd_error_type
> - in gfx_ring_bad_write_linear(), map this error to:
>   stream_length = ring_context->write_length * 2
> - keep existing invalid-short-length path unchanged
>
> Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
> ---
>  lib/amdgpu/amd_ip_blocks.c | 2 ++
>  lib/amdgpu/amd_ip_blocks.h | 1 +
>  2 files changed, 3 insertions(+)
>
> diff --git a/lib/amdgpu/amd_ip_blocks.c b/lib/amdgpu/amd_ip_blocks.c
> index f0376a3e7..80aa5569c 100644
> --- a/lib/amdgpu/amd_ip_blocks.c
> +++ b/lib/amdgpu/amd_ip_blocks.c
> @@ -284,6 +284,8 @@ gfx_ring_bad_write_linear(const struct amdgpu_ip_funcs *func,
>  	  */
>  	if (cmd_error == CMD_STREAM_EXEC_INVALID_PACKET_LENGTH)
>  		stream_length = ring_context->write_length / 16;
> +	else if (cmd_error == CMD_STREAM_EXEC_INVALID_PACKET_LENGTH_OVERSIZE)
> +		stream_length = ring_context->write_length * 2;
>  	else
>  		stream_length = ring_context->write_length;
>  
> diff --git a/lib/amdgpu/amd_ip_blocks.h b/lib/amdgpu/amd_ip_blocks.h
> index 6bc8c3706..eb118c68a 100644
> --- a/lib/amdgpu/amd_ip_blocks.h
> +++ b/lib/amdgpu/amd_ip_blocks.h
> @@ -146,6 +146,7 @@ enum  cmd_error_type {
>  	CMD_STREAM_EXEC_SUCCESS,
>  	CMD_STREAM_EXEC_INVALID_OPCODE,
>  	CMD_STREAM_EXEC_INVALID_PACKET_LENGTH,
> +	CMD_STREAM_EXEC_INVALID_PACKET_LENGTH_OVERSIZE,
>  	CMD_STREAM_EXEC_INVALID_PACKET_EOP_QUEUE,
>  	CMD_STREAM_TRANS_BAD_REG_ADDRESS,
>  	CMD_STREAM_TRANS_BAD_MEM_ADDRESS,