From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jaroslav Kysela <perex@perex.cz>,
ALSA development <alsa-devel@alsa-project.org>
Cc: Takashi Iwai <tiwai@suse.de>,
Cezary Rojewski <cezary.rojewski@intel.com>
Subject: Re: [alsa-devel] [PATCH] ALSA: hda: add Intel DSP configuration / probe code
Date: Wed, 2 Oct 2019 11:55:23 -0500 [thread overview]
Message-ID: <a3ffaba6-30ea-32f4-8ca6-68ca91d9d138@linux.intel.com> (raw)
In-Reply-To: <3f7aabee-afac-c83e-e529-29e6abc8c104@perex.cz>
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_COMETLAKE_LP)
>>> + 0x02c8, /* Cometlake-LP */
>>> +#endif
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_COMETLAKE_H)
>>> + 0x06c8, /* Cometlake-H */
>>> +#endif
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_GEMINILAKE)
>>> + 0x3198, /* Geminilake */
>>> +#endif
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_APOLLOLAKE)
>>> + 0x5a98, /* Broxton-P (Appololake) */
>>> +#endif
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_CANNONLAKE)
>>> + 0x9dc8, /* Cannonlake */
>>> +#endif
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_COFFEELAKE)
>>> + 0xa348, /* Coffelake */
>>> +#endif
>>
>> What about all the other PCI IDs that SOF handles, e.g. TigerLake, etc?
>
> There is no PCI ID clash, only one driver will call the DSP probe and
> SND_INTEL_DSP_DRIVER_ANY will be returned in this case.
If we are talking about conflicts between the HDaudio legacy driver and
SOF, I think all PCI IDs should be there. Not every OEM, or even all
skews from a single OEM, will transition to DMICs and DSP enabled, and
the legacy driver will still be required for many years.
>
>> Also how do you deal with SKL/KBL cases with DMICs? They would need to
>> use the SST driver (for Chromebooks mainly)
>
> As I noted in the comment, we can add dmi quirks on top. I just do not have
> enough information - can I take the hints from the pull request (your code)
> you already mentioned?
Sure. They should cover the main conflicts.
>> Even for APL, the 'official' driver is still SST for Chromebooks. SOF
>> should work but there will probably be missing firmware/topology files.
>
> I can rework this part of course. I'll send v2 patch.
I see it now, will comment on the v2.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-02 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 11:35 [alsa-devel] [PATCH] ALSA: hda: add Intel DSP configuration / probe code Jaroslav Kysela
2019-10-02 16:00 ` Pierre-Louis Bossart
2019-10-02 16:39 ` Jaroslav Kysela
2019-10-02 16:55 ` Pierre-Louis Bossart [this message]
2019-10-02 16:07 ` kbuild test robot
2019-10-02 16:07 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3ffaba6-30ea-32f4-8ca6-68ca91d9d138@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=cezary.rojewski@intel.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.