From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: "Patrick Ohly" <patrick.ohly@intel.com>,
"Aníbal Limón" <anibal.limon@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] qemu: Upgrade to 2.7.1
Date: Fri, 20 Jan 2017 13:48:02 +0200 [thread overview]
Message-ID: <a40ee70f-311e-c0db-e672-3a66bf1af5b6@linux.intel.com> (raw)
In-Reply-To: <1484912118.23233.113.camel@intel.com>
On 01/20/2017 01:35 PM, Patrick Ohly wrote:
> On Thu, 2017-01-19 at 16:46 -0600, Aníbal Limón wrote:
>> SRC_URI_prepend = "http://wiki.qemu-project.org/download/${BP}.tar.bz2"
>> -SRC_URI[md5sum] = "08d4d06d1cb598efecd796137f4844ab"
>> -SRC_URI[sha256sum] = "326e739506ba690daf69fc17bd3913a6c313d9928d743bd8eddb82f403f81e53"
>> +SRC_URI[md5sum] = "a315bc51ed443a08d2cf1416d76b9ab4"
>> +SRC_URI[sha256sum] = "68636788eb69bcb0b44ba220b32b50495d6bd5712a934c282217831c4822958f"
>
> _prepend without trailing space is broken. It just happens to work
> because the SRC_URI it prepends to usually has a leading space.
>
> I just ran into a situation where it didn't (due to some _remove
> operation being interposed, which did a split/join, see YOCTO #10945).
>
> I was about to send a fix, but it would just conflict with your version
> update. Can you include a fix by revising your proposal, perhaps by
> turning it into a patch series with two changes?
>
> IMHO SRC_URI =+ "http://wiki.qemu-project.org/download/${BP}.tar.bz2"
> should be fine. There's no need for the more complex _prepend.
Actually, this line should be simply moved to qemu.inc and placed
together with other SRC_URI entries. There is nothing version-specific
in it. All these prepends, appends and +='s are best avoided if possible.
Alex
prev parent reply other threads:[~2017-01-20 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 22:46 [PATCH] qemu: Upgrade to 2.7.1 Aníbal Limón
2017-01-20 11:35 ` Patrick Ohly
2017-01-20 11:48 ` Alexander Kanavin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a40ee70f-311e-c0db-e672-3a66bf1af5b6@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=anibal.limon@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=patrick.ohly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.