From: Matthieu Baerts <matttbe@kernel.org>
To: "Maxime Chevallier (Netdev Foundation)" <maxime.chevallier@bootlin.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, linux-kselftest@vger.kernel.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>
Subject: Re: [PATCH net-next 2/2] selftests: drv-net: Use cross-compilation environment for the io_uring check
Date: Tue, 1 Sep 2026 19:24:07 +0200 [thread overview]
Message-ID: <a42cdc44-efaf-44ff-9ace-f08e0c3b9856@kernel.org> (raw)
In-Reply-To: <20260901164200.1124343-3-maxime.chevallier@bootlin.com>
Hi Maxime,
Thank you for looking at that.
On 01/09/2026 18:41, Maxime Chevallier (Netdev Foundation) wrote:
> To test for the presence of zerocopy support in the available liburing,
> a small check program is compiled.
>
> The CC value used for the io_uring library check defaults to the host
> compiler, which will fail in cross-compiling environments.
>
> Normally the CC for cross-compile is set in lib.mk, but this also
> requires the test list to be set when we include it, and this check
> needs to run first.
>
> Note that this doesn't cover the LLVM cross-compiling case though.
Maybe it is enough to just check if LLVM is set?
> Signed-off-by: Maxime Chevallier (Netdev Foundation) <maxime.chevallier@bootlin.com>
> ---
> tools/testing/selftests/drivers/net/hw/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/hw/Makefile b/tools/testing/selftests/drivers/net/hw/Makefile
> index 78bb0169350b..0ebb4767cd57 100644
> --- a/tools/testing/selftests/drivers/net/hw/Makefile
> +++ b/tools/testing/selftests/drivers/net/hw/Makefile
> @@ -1,5 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0+ OR MIT
>
> +# Set CC for the io_uring check
> +CC := $(CROSS_COMPILE)gcc
Could we have something similar to
tools/testing/selftests/riscv/cfi/Makefile:
# Set CC for the io_uring check done before including lib.mk
ifeq ($(LLVM)$(CC),cc)
CC := $(CROSS_COMPILE)gcc
endif
WDYT?
But that's possibly not needed for this simple check? I guess if gcc can
find liburing.h, clang should look at the same places.
> # Check if io_uring supports zero-copy receive
> HAS_IOURING_ZCRX := $(shell \
> echo -e '#include <liburing.h>\n' \
Cheers,
Matt
next prev parent reply other threads:[~2026-09-01 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 16:41 [PATCH net-next 0/2] selftests: drv-net: Allow cross-compiling the hardware tests Maxime Chevallier (Netdev Foundation)
2026-09-01 16:41 ` [PATCH net-next 1/2] selftests: drv-net: ynl: Allow cross-compiling ynl and associated tools Maxime Chevallier (Netdev Foundation)
2026-09-01 22:42 ` Jakub Kicinski
2026-09-01 16:41 ` [PATCH net-next 2/2] selftests: drv-net: Use cross-compilation environment for the io_uring check Maxime Chevallier (Netdev Foundation)
2026-09-01 17:24 ` Matthieu Baerts [this message]
2026-09-01 20:45 ` Maxime Chevallier
2026-09-01 22:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a42cdc44-efaf-44ff-9ace-f08e0c3b9856@kernel.org \
--to=matttbe@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.