From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E9E8C433EF for ; Thu, 20 Jan 2022 07:12:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6267E304D; Thu, 20 Jan 2022 08:12:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6267E304D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1642662770; bh=KGLVQi6QQGNSvXeEuE3AZqdmrA7eAbBtnVk/70VhHcM=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Q97YsIrH2VRpCmBxQwk87AO5NUKcYpZ5rJ+rqvj78UIoGkh/RRvwgVkY4iAjG4Fmt vIi0hvy13lVtBZafiEDtEU+VdT2neEHyHLCF9LmkSNh5p1dH7+RN+6hPqtr1sdvzjx YVNfKO0CvE5id0eOvfqkRu6lrAjFgiQMuZYDvsCg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2CDDEF805DA; Thu, 20 Jan 2022 08:03:54 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DC745F801F7; Wed, 19 Jan 2022 12:42:19 +0100 (CET) Received: from mxout04.lancloud.ru (mxout04.lancloud.ru [45.84.86.114]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 09863F80100 for ; Wed, 19 Jan 2022 12:42:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 09863F80100 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru 385F120D1C64 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 14:42:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) X-Mailman-Approved-At: Thu, 20 Jan 2022 08:03:35 +0100 Cc: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , kvm@vger.kernel.org, "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , alsa-devel@alsa-project.org, Guenter Roeck , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Miquel Raynal , linux-phy@lists.infradead.org, Lee Jones , linux-kernel@vger.kernel.org, "David S. Miller" , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Kamal Dasu , Jiri Slaby , Bartosz Golaszewski , Daniel Lezcano , Kishon Vijay Abraham I , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Jakub Kicinski , Zhang Rui , platform-driver-x86@vger.kernel.org, linux-pwm@vger.kernel.org, Robert Richter , Saravanan Sekar , Corey Minyard , linux-pm@vger.kernel.org, Liam Girdwood , Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , Hans de Goede , Alex Williamson , Mark Brown , Borislav Petkov , Eric Auger , Takashi Iwai , Matthias Brugger , openipmi-developer@lists.sourceforge.net, Andy Shevchenko , Benson Leung , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, Tony Luck , Richard Weinberger , Mun Yew Tham , linux-gpio@vger.kernel.org, Greg Kroah-Hartman , Yoshihiro Shimoda , Cornelia Huck , linux-mmc@vger.kernel.org, Joakim Zhang , linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , netdev@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 1/19/22 2:33 PM, Uwe Kleine-König wrote: [...] >>>>> A possible compromise: We can have both. We rename >>>>> platform_get_irq_optional() to platform_get_irq_silent() (or >>>>> platform_get_irq_silently() if this is preferred) and once all users are >>>>> are changed (which can be done mechanically), we reintroduce a >>>>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>>>> return 0 on not-found, no error message printking). >>>> >>>> Please do not do that as anyone trying to forward-port an old driver >>>> will miss the abi change of functionality and get confused. Make >>>> build-breaking changes, if the way a function currently works is >>>> changed in order to give people a chance. >>> >>> Fine for me. I assume this is a Nack for Sergey's patch? >> >> Which patch do you mean? I'm starting to get really muddled... :-( > > I'm talking about "[PATCH 1/2] platform: make > platform_get_irq_optional() optional" I thought GregKH was talking about your renaming patch... :-/ > because "trying to forward-port an > old driver will miss the abi" applies to it. Mhm... why not tell me right from the start? Jr even tell that to Andy instead of merging his patch, so I wouldn't get sucked into this work? I wouldn't bother with v2 and it would have saved a lot of time spent on email... :-( Do we also remember that "the stable API is a nonsense" thing? :-) > Best regards > Uwe MBR, Sergey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40822C433EF for ; Wed, 19 Jan 2022 11:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354271AbiASLmU (ORCPT ); Wed, 19 Jan 2022 06:42:20 -0500 Received: from mxout03.lancloud.ru ([45.84.86.113]:32826 "EHLO mxout03.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236274AbiASLmT (ORCPT ); Wed, 19 Jan 2022 06:42:19 -0500 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru 3B47720D46BF Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= CC: Greg Kroah-Hartman , Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , , "Rafael J. Wysocki" , , Linus Walleij , Amit Kucheria , , Andy Shevchenko , Joakim Zhang , Guenter Roeck , Thierry Reding , , , Miquel Raynal , , , Lee Jones , , "Khuong Dinh" , Florian Fainelli , Matthias Schiffer , Kamal Dasu , "Jiri Slaby" , Bartosz Golaszewski , "Daniel Lezcano" , Kishon Vijay Abraham I , , , Jakub Kicinski , Zhang Rui , "Jaroslav Kysela" , , Hans de Goede , Robert Richter , Saravanan Sekar , Corey Minyard , , Mauro Carvalho Chehab , "John Garry" , Peter Korsgaard , "William Breathitt Gray" , Mark Gross , , Alex Williamson , Mark Brown , Borislav Petkov , "Sebastian Reichel" , Matthias Brugger , "Takashi Iwai" , , Benson Leung , , , Tony Luck , Mun Yew Tham , Eric Auger , , Yoshihiro Shimoda , Cornelia Huck , , Liam Girdwood , , , "Vinod Koul" , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , , "Brian Norris" , "David S. Miller" References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 14:42:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On 1/19/22 2:33 PM, Uwe Kleine-König wrote: [...] >>>>> A possible compromise: We can have both. We rename >>>>> platform_get_irq_optional() to platform_get_irq_silent() (or >>>>> platform_get_irq_silently() if this is preferred) and once all users are >>>>> are changed (which can be done mechanically), we reintroduce a >>>>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>>>> return 0 on not-found, no error message printking). >>>> >>>> Please do not do that as anyone trying to forward-port an old driver >>>> will miss the abi change of functionality and get confused. Make >>>> build-breaking changes, if the way a function currently works is >>>> changed in order to give people a chance. >>> >>> Fine for me. I assume this is a Nack for Sergey's patch? >> >> Which patch do you mean? I'm starting to get really muddled... :-( > > I'm talking about "[PATCH 1/2] platform: make > platform_get_irq_optional() optional" I thought GregKH was talking about your renaming patch... :-/ > because "trying to forward-port an > old driver will miss the abi" applies to it. Mhm... why not tell me right from the start? Jr even tell that to Andy instead of merging his patch, so I wouldn't get sucked into this work? I wouldn't bother with v2 and it would have saved a lot of time spent on email... :-( Do we also remember that "the stable API is a nonsense" thing? :-) > Best regards > Uwe MBR, Sergey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42EE3C433FE for ; Wed, 19 Jan 2022 11:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=/fpyREmZdFHWym5jZU6/pGaaRXO3q5WDWfTEIJft4+4=; b=rkyydBzSP2ayEOdW9kcQQ7mb5c lR5Gjw+3gnr02cKGsWx/Gr8ZYh9erYIo+tYzqTf56WBIHH4JektmmJuB/3+1naFnPwVnDp/4XtkCP HzifcP/ZyIObW+124l3gJNAZuetTQ9onUbA7qQvMH8SruW+z8Fqm3pZ18uq2RnGRrmkAvrdwF/47R 7GwZXABst0qRAY8+o9EhQwG/JSeTWUqrmV5xahHl0djHT/ZCM6Bni6OLrhtTIcVcooK6E8c1QUXs+ v6jkOZb06EJYj15kY2h8Ser6eElMR+/onLMX0NtVXZnquT1IeWIAI6OT9CooL+H1YqyhjXTtVu54f U5zfb79g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA9M5-005DCj-Ln; Wed, 19 Jan 2022 11:42:21 +0000 Received: from mxout04.lancloud.ru ([45.84.86.114]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA9M1-005DBc-PI; Wed, 19 Jan 2022 11:42:19 +0000 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru 385F120D1C64 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= CC: Greg Kroah-Hartman , Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , , "Rafael J. Wysocki" , , Linus Walleij , Amit Kucheria , , Andy Shevchenko , Joakim Zhang , Guenter Roeck , Thierry Reding , , , Miquel Raynal , , , Lee Jones , , "Khuong Dinh" , Florian Fainelli , Matthias Schiffer , Kamal Dasu , "Jiri Slaby" , Bartosz Golaszewski , "Daniel Lezcano" , Kishon Vijay Abraham I , , , Jakub Kicinski , Zhang Rui , "Jaroslav Kysela" , , Hans de Goede , Robert Richter , Saravanan Sekar , Corey Minyard , , Mauro Carvalho Chehab , "John Garry" , Peter Korsgaard , "William Breathitt Gray" , Mark Gross , , Alex Williamson , Mark Brown , Borislav Petkov , "Sebastian Reichel" , Matthias Brugger , "Takashi Iwai" , , Benson Leung , , , Tony Luck , Mun Yew Tham , Eric Auger , , Yoshihiro Shimoda , Cornelia Huck , , Liam Girdwood , , , "Vinod Koul" , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , , "Brian Norris" , "David S. Miller" References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 14:42:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> Content-Language: en-US X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_034218_207935_79A26F05 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 1/19/22 2:33 PM, Uwe Kleine-K=F6nig wrote: [...] >>>>> A possible compromise: We can have both. We rename >>>>> platform_get_irq_optional() to platform_get_irq_silent() (or >>>>> platform_get_irq_silently() if this is preferred) and once all users = are >>>>> are changed (which can be done mechanically), we reintroduce a >>>>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>>>> return 0 on not-found, no error message printking). >>>> >>>> Please do not do that as anyone trying to forward-port an old driver >>>> will miss the abi change of functionality and get confused. Make >>>> build-breaking changes, if the way a function currently works is >>>> changed in order to give people a chance. >>> >>> Fine for me. I assume this is a Nack for Sergey's patch? >> >> Which patch do you mean? I'm starting to get really muddled... :-( > = > I'm talking about "[PATCH 1/2] platform: make > platform_get_irq_optional() optional" I thought GregKH was talking about your renaming patch... :-/ > because "trying to forward-port an > old driver will miss the abi" applies to it. Mhm... why not tell me right from the start? Jr even tell that to Andy instead of merging his patch, so I wouldn't get sucked into this work? = I wouldn't bother with v2 and it would have saved a lot of time spent on email... :-( Do we also remember that "the stable API is a nonsense" thing? :-) > Best regards > Uwe MBR, Sergey _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7944DC433F5 for ; Wed, 19 Jan 2022 11:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=t+ns+tujv0cM1k1IEzIe5Z4QO4VctHLCz7DWS0Pojqs=; b=ud9/aQwa+a+kXbzoQxvszeEHZ3 MirHCnUbQgWbw/gj/7FpQ9eXRmxbVgiKbdhZDxnvg+1539J83Un3UycxVLgwEFdy55jSp3TOsnq6K 4angGjoNzd+xXu9aEzQUeg0vIgiOUGhdXda9ZZjIOrGDCT8fU21CvP//5lyHvQImsfNrQGdRq3HCw uWlkVXzxA1OgW7vOzTHsPaIZB5OnZ3sn7WV1KPMpPMnZJTAusKtcX0GukZ7WpVb/7EaT5KZLGlIAA SnBVU+bfKTaHIGng0oNV05dyzyTHuuPzQ19p0QIhMApOrCxsw9vEqqTREnEL4voEb6E8uXDoQqG/s 5/Ipr85A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA9M6-005DCt-Sz; Wed, 19 Jan 2022 11:42:22 +0000 Received: from mxout04.lancloud.ru ([45.84.86.114]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA9M1-005DBc-PI; Wed, 19 Jan 2022 11:42:19 +0000 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru 385F120D1C64 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= CC: Greg Kroah-Hartman , Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , , "Rafael J. Wysocki" , , Linus Walleij , Amit Kucheria , , Andy Shevchenko , Joakim Zhang , Guenter Roeck , Thierry Reding , , , Miquel Raynal , , , Lee Jones , , "Khuong Dinh" , Florian Fainelli , Matthias Schiffer , Kamal Dasu , "Jiri Slaby" , Bartosz Golaszewski , "Daniel Lezcano" , Kishon Vijay Abraham I , , , Jakub Kicinski , Zhang Rui , "Jaroslav Kysela" , , Hans de Goede , Robert Richter , Saravanan Sekar , Corey Minyard , , Mauro Carvalho Chehab , "John Garry" , Peter Korsgaard , "William Breathitt Gray" , Mark Gross , , Alex Williamson , Mark Brown , Borislav Petkov , "Sebastian Reichel" , Matthias Brugger , "Takashi Iwai" , , Benson Leung , , , Tony Luck , Mun Yew Tham , Eric Auger , , Yoshihiro Shimoda , Cornelia Huck , , Liam Girdwood , , , "Vinod Koul" , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , , "Brian Norris" , "David S. Miller" References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 14:42:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> Content-Language: en-US X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_034218_207935_79A26F05 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 1/19/22 2:33 PM, Uwe Kleine-K=F6nig wrote: [...] >>>>> A possible compromise: We can have both. We rename >>>>> platform_get_irq_optional() to platform_get_irq_silent() (or >>>>> platform_get_irq_silently() if this is preferred) and once all users = are >>>>> are changed (which can be done mechanically), we reintroduce a >>>>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>>>> return 0 on not-found, no error message printking). >>>> >>>> Please do not do that as anyone trying to forward-port an old driver >>>> will miss the abi change of functionality and get confused. Make >>>> build-breaking changes, if the way a function currently works is >>>> changed in order to give people a chance. >>> >>> Fine for me. I assume this is a Nack for Sergey's patch? >> >> Which patch do you mean? I'm starting to get really muddled... :-( > = > I'm talking about "[PATCH 1/2] platform: make > platform_get_irq_optional() optional" I thought GregKH was talking about your renaming patch... :-/ > because "trying to forward-port an > old driver will miss the abi" applies to it. Mhm... why not tell me right from the start? Jr even tell that to Andy instead of merging his patch, so I wouldn't get sucked into this work? = I wouldn't bother with v2 and it would have saved a lot of time spent on email... :-( Do we also remember that "the stable API is a nonsense" thing? :-) > Best regards > Uwe MBR, Sergey ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85ED2C433EF for ; Wed, 19 Jan 2022 11:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=r+RPRe5gSw8GcSYBwoEuANNnu9rdeW0irrtX04ysDbE=; b=mM7QQbAZXs0FSywwtYriFpYKKl f7Crta5QcukWtnp39pRLsYwxZzziO6IOGPWuoq6CEU7SWQeKkpMNEZ6TlEuo7MyEdm7Z2jEX03RUq py+5Hl/CmG+ggNGSW9Yk8cGycchNl26WPv5LEe/UjelqGGseDY3FddXLBcA7cak80cgUzdY3Uc2De oWcLH9Fbh9hfBmC9ySbmN+uQwjGKucbtZ4B6dPEYiCUjU26CcJPUqZDA2kA+NLLwsZgqHPyPIE4aU j9W2mU4rzRXHhhns+1JBJGT4c6ZLVerZOd09UF6kvQ6vArhS8wuz0LV1uFBV7lhgatF+5ngz/9kJL xVTUYCyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA9MJ-005DHZ-St; Wed, 19 Jan 2022 11:42:35 +0000 Received: from mxout04.lancloud.ru ([45.84.86.114]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA9M1-005DBc-PI; Wed, 19 Jan 2022 11:42:19 +0000 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru 385F120D1C64 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= CC: Greg Kroah-Hartman , Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , , "Rafael J. Wysocki" , , Linus Walleij , Amit Kucheria , , Andy Shevchenko , Joakim Zhang , Guenter Roeck , Thierry Reding , , , Miquel Raynal , , , Lee Jones , , "Khuong Dinh" , Florian Fainelli , Matthias Schiffer , Kamal Dasu , "Jiri Slaby" , Bartosz Golaszewski , "Daniel Lezcano" , Kishon Vijay Abraham I , , , Jakub Kicinski , Zhang Rui , "Jaroslav Kysela" , , Hans de Goede , Robert Richter , Saravanan Sekar , Corey Minyard , , Mauro Carvalho Chehab , "John Garry" , Peter Korsgaard , "William Breathitt Gray" , Mark Gross , , Alex Williamson , Mark Brown , Borislav Petkov , "Sebastian Reichel" , Matthias Brugger , "Takashi Iwai" , , Benson Leung , , , Tony Luck , Mun Yew Tham , Eric Auger , , Yoshihiro Shimoda , Cornelia Huck , , Liam Girdwood , , , "Vinod Koul" , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , , "Brian Norris" , "David S. Miller" References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 14:42:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> Content-Language: en-US X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_034218_207935_79A26F05 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 1/19/22 2:33 PM, Uwe Kleine-K=F6nig wrote: [...] >>>>> A possible compromise: We can have both. We rename >>>>> platform_get_irq_optional() to platform_get_irq_silent() (or >>>>> platform_get_irq_silently() if this is preferred) and once all users = are >>>>> are changed (which can be done mechanically), we reintroduce a >>>>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>>>> return 0 on not-found, no error message printking). >>>> >>>> Please do not do that as anyone trying to forward-port an old driver >>>> will miss the abi change of functionality and get confused. Make >>>> build-breaking changes, if the way a function currently works is >>>> changed in order to give people a chance. >>> >>> Fine for me. I assume this is a Nack for Sergey's patch? >> >> Which patch do you mean? I'm starting to get really muddled... :-( > = > I'm talking about "[PATCH 1/2] platform: make > platform_get_irq_optional() optional" I thought GregKH was talking about your renaming patch... :-/ > because "trying to forward-port an > old driver will miss the abi" applies to it. Mhm... why not tell me right from the start? Jr even tell that to Andy instead of merging his patch, so I wouldn't get sucked into this work? = I wouldn't bother with v2 and it would have saved a lot of time spent on email... :-( Do we also remember that "the stable API is a nonsense" thing? :-) > Best regards > Uwe MBR, Sergey -- = linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy