All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 18/38] mips: Make u-boot-mips.h a private header
Date: Wed, 17 May 2017 21:27:53 +0200	[thread overview]
Message-ID: <a43ea7da-bb43-dbb6-e91a-14bb972c3fde@gmail.com> (raw)
In-Reply-To: <20170517142311.29484-19-sjg@chromium.org>



Am 17.05.2017 um 16:22 schrieb Simon Glass:
> Rather than including this arch-specific header file in common.h, include
> it from within mips's u-boot.h header.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>

> ---
> 
>  arch/mips/include/asm/u-boot.h | 1 +
>  include/common.h               | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/u-boot.h b/arch/mips/include/asm/u-boot.h
> index af03e8d5be..68985af4b9 100644
> --- a/arch/mips/include/asm/u-boot.h
> +++ b/arch/mips/include/asm/u-boot.h
> @@ -17,6 +17,7 @@
>  
>  /* Use the generic board which requires a unified bd_info */
>  #include <asm-generic/u-boot.h>
> +#include <asm/u-boot-mips.h>
>  
>  /* For image.h:image_check_target_arch() */
>  #define IH_ARCH_DEFAULT IH_ARCH_MIPS
> diff --git a/include/common.h b/include/common.h
> index fe396c5705..f36fed3843 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -442,7 +442,7 @@ static inline int setenv_addr(const char *varname, const void *addr)
>  # include <asm/u-boot-nds32.h>
>  #endif /* CONFIG_NDS32 */
>  #ifdef CONFIG_MIPS
> -# include <asm/u-boot-mips.h>
> +# include <asm/u-boot.h>
>  #endif /* CONFIG_MIPS */

you could also remove the #ifdef CONFIG_MIPS in this patch and drop
patch 21/38

>  #ifdef CONFIG_ARC
>  # include <asm/u-boot.h>
> 

-- 
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170517/6d996fe4/attachment.sig>

  reply	other threads:[~2017-05-17 19:27 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 14:22 [U-Boot] [PATCH 00/38] common: Reduce size of common.h Simon Glass
2017-05-17 14:22 ` [U-Boot] [PATCH 01/38] common: Drop inclusion of pci.h Simon Glass
2017-06-06  0:17   ` [U-Boot] [U-Boot,01/38] " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 02/38] common: Drop pci_pre_init() and is_pci_host() Simon Glass
2017-06-06  0:17   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 03/38] common: Move pci_target_init() to PPC header Simon Glass
2017-06-06  0:17   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 04/38] common: Drop pci_master_init() Simon Glass
2017-06-06  0:17   ` [U-Boot] [U-Boot,04/38] " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 05/38] common: Move pcie_setup_hoses() to PPC header Simon Glass
2017-06-06  0:17   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 06/38] common: Move get_OPB_freq() and get_PCI_freq() " Simon Glass
2017-06-06  0:17   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 07/38] api: Add a header for api_init() Simon Glass
2017-06-06  0:17   ` [U-Boot] [U-Boot,07/38] " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 08/38] gpio: samsung: Drop s3c2440_gpio driver Simon Glass
2017-06-06  0:18   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 09/38] samsung: Drop s3c24x0 arch-specific code Simon Glass
     [not found]   ` <CALrBrZ2SqS55_hV39B_sijFKEt4E0kb__y34RO9+7+wW9G5wsg@mail.gmail.com>
2017-05-22  2:07     ` Minkyu Kang
2017-06-06  0:18   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 10/38] samsung: mmc: Drop s3c_sdi driver Simon Glass
2017-05-22  2:08   ` Minkyu Kang
2017-05-26  2:20   ` Jaehoon Chung
2017-06-06  0:18   ` [U-Boot] [U-Boot,10/38] " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 11/38] samsung: usb: Drop ohci-s3c24xx driver Simon Glass
     [not found]   ` <CALrBrZ3_833sZmpswnL-dSx_yRXUkVJAU06ZhWR1WBAGC1C66A@mail.gmail.com>
2017-05-22  2:08     ` Minkyu Kang
2017-06-06  0:18   ` [U-Boot] [U-Boot,11/38] " Tom Rini
2017-06-06  0:44     ` Marek Vasut
2017-05-17 14:22 ` [U-Boot] [PATCH 12/38] samsung: nand: Drop s3c2410_nand driver Simon Glass
2017-05-22  2:05   ` Minkyu Kang
2017-06-06  0:18   ` [U-Boot] [U-Boot, " Tom Rini
2017-06-06  0:18   ` Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 13/38] samsung: Drop more references fo s3c24x0 Simon Glass
2017-05-22  2:06   ` Minkyu Kang
2017-06-06  0:18   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 14/38] arc: Make u-boot-arc.h a private header Simon Glass
2017-06-06  0:18   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 15/38] sandbox: Make u-boot-sandbox.h " Simon Glass
2017-06-06  0:18   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 16/38] x86: Make u-boot-x86.h " Simon Glass
2017-06-06  0:18   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 17/38] arm: Make u-boot-arm.h " Simon Glass
2017-06-06  0:18   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 18/38] mips: Make u-boot-mips.h " Simon Glass
2017-05-17 19:27   ` Daniel Schwierzeck [this message]
2017-06-01  3:10     ` Simon Glass
2017-06-06  0:19   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 19/38] nds32: Make u-boot-nds32.h " Simon Glass
2017-06-06  0:19   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 20/38] arc: Don't include asm/u-boot.h in common Simon Glass
2017-06-06  0:19   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 21/38] mips: " Simon Glass
2017-05-17 19:28   ` Daniel Schwierzeck
2017-06-06  0:19   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 22/38] sandbox: " Simon Glass
2017-06-06  0:19   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 23/38] x86: " Simon Glass
2017-06-06  0:19   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 24/38] nds32: Remove include files from common.h Simon Glass
2017-06-06  0:19   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 25/38] arm: Add explicit include of <asm/mach-types.h> Simon Glass
2017-05-17 21:24   ` Tom Rini
2017-05-17 14:22 ` [U-Boot] [PATCH 26/38] arm: Add declarations to avoid needing to include headers Simon Glass
2017-06-06  0:19   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 27/38] arm: Include asm/setup.h explictly Simon Glass
2017-06-06  0:19   ` [U-Boot] [U-Boot,27/38] " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 28/38] arm: Remove include files from common.h Simon Glass
2017-05-17 21:31   ` Tom Rini
2017-06-06  0:19   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 29/38] common: Drop cpu_init_f() declarations Simon Glass
2017-06-06  0:19   ` [U-Boot] [U-Boot,29/38] " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 30/38] common: Drop determine_sysper() and determine_pci_clock_per() Simon Glass
2017-06-06  0:19   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 31/38] common: Move PPC4xx_SYS_INFO() et al to arch-specific header Simon Glass
2017-06-06  0:20   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 32/38] common: powerpc: Move arch-specific headers Simon Glass
2017-06-06  0:20   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 33/38] common: freescale: Move arch-specific declarations Simon Glass
2017-06-06  0:20   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 34/38] common: freescale: Move arch-specific imx code to arch-imx Simon Glass
2017-06-06  0:20   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 35/38] common: ep93xx: Move arch-specific declarations out of common Simon Glass
2017-06-06  0:20   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 36/38] common: arm: davinci: Move header file " Simon Glass
2017-05-17 21:33   ` Tom Rini
2017-05-18 15:55     ` Simon Glass
2017-05-18 15:57       ` Tom Rini
2017-06-06  0:20   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 37/38] common: arm: freescale: layerscape: Move header files out of common.h Simon Glass
2017-06-06  0:20   ` [U-Boot] [U-Boot, " Tom Rini
2017-05-17 14:23 ` [U-Boot] [PATCH 38/38] common: microblaze: Drop arch-specific declarations Simon Glass
2017-06-06  0:20   ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a43ea7da-bb43-dbb6-e91a-14bb972c3fde@gmail.com \
    --to=daniel.schwierzeck@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.