From: Stephen Boyd <sboyd@kernel.org>
To: "Simek, Michal" <michal.simek@amd.com>,
"Thangaraj, Senthil Nathan" <SenthilNathan.Thangaraj@amd.com>,
"Trivedi Manojbhai, Naman" <Naman.TrivediManojbhai@amd.com>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
mturquette@baylibre.com
Cc: linux-kernel@ <"vger.kernel.org linux-kernel"@vger.kernel.org>
Subject: RE: [PATCH V2] drivers: clk: zynqmp: remove clock name dependency
Date: Thu, 21 Nov 2024 15:03:05 -0800 [thread overview]
Message-ID: <a45e4e8d5ec8be3ef659969a2fb3b6c0.sboyd@kernel.org> (raw)
In-Reply-To: <SN7PR12MB7276EE2CA7208EBF7391F2858A222@SN7PR12MB7276.namprd12.prod.outlook.com>
Quoting Trivedi Manojbhai, Naman (2024-11-21 03:49:46)
> Hi Stephen,
>
> While debugging further, I found that, CCF registers the clock by their node name if the clock is present in DT. This was causing issue when the clock node name is changed. By adding clock-output-names property in the clock provider nodes in DT, it ensures output clock name is not changed. This DT change is sufficient to fix the issue.
>
> I have submitted a patch - https://lkml.org/lkml/2024/11/21/412 to fix the same in DT. So, the driver changes which are part of this thread is not required.
>
Ok. Sounds bad still. It would be better to remove any string usage to
describe clk tree topology in this driver.
prev parent reply other threads:[~2024-11-21 23:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 12:19 [PATCH V2] drivers: clk: zynqmp: remove clock name dependency Naman Trivedi
2024-08-08 22:48 ` Stephen Boyd
2024-08-12 12:57 ` Trivedi Manojbhai, Naman
2024-08-12 18:10 ` Stephen Boyd
2024-08-29 5:54 ` Trivedi Manojbhai, Naman
2024-08-29 19:02 ` Stephen Boyd
2024-09-06 9:43 ` Trivedi Manojbhai, Naman
2024-11-21 11:49 ` Trivedi Manojbhai, Naman
2024-11-21 23:03 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a45e4e8d5ec8be3ef659969a2fb3b6c0.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=Naman.TrivediManojbhai@amd.com \
--cc=SenthilNathan.Thangaraj@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.