From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FCBDC02180 for ; Wed, 15 Jan 2025 12:42:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C4BA010E671; Wed, 15 Jan 2025 12:42:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="LJV+UApZ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id F14C610E671 for ; Wed, 15 Jan 2025 12:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736944929; x=1768480929; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=2fYtcgRqFifDv9S3LhZevfTHGbkLpNbkV/10jzoNMQs=; b=LJV+UApZ78qgcTivVCLZfF9MXI1DWVbWnOO5IDkJaszCPp6nya1xIuXV O7cPCIv4x1L2uOxrhjXRsCiz5ZE/cHX9AoDMm/WvwArsPIReNKtRdO0xW R9NfDHqYz4LHeeX1QOHHN/Aex48iZQ6W7vCy77cHTe0Zc389Kxh+JtPDZ 5toKmDZBQFzBoRAgC7YLMTiB97VrmDsu5qx1uvw9i8AFYlgBcDrWa08/o vTSUaAfD0hmxGiIipvZg05r56Ysl07VOSCSdnkhhwNXEbf2Oxoynpuh1U gDoYylt9VHKpANnyu4hmzibBmAnX1Pd4JBW3N0ZHnNh7j5kMpSsAhUps6 A==; X-CSE-ConnectionGUID: hDoyCHbgT7yngbu/4J/AdQ== X-CSE-MsgGUID: oVv4ksydSOSh+Uo6pxO67Q== X-IronPort-AV: E=McAfee;i="6700,10204,11314"; a="48689331" X-IronPort-AV: E=Sophos;i="6.12,310,1728975600"; d="scan'208";a="48689331" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2025 04:42:09 -0800 X-CSE-ConnectionGUID: Qb1DcjH5R4WNxvS3KBawOA== X-CSE-MsgGUID: 6Pfj51xdSaS18wlXOrxdEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="105992114" Received: from bergbenj-mobl1.ger.corp.intel.com (HELO [10.245.246.51]) ([10.245.246.51]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2025 04:42:06 -0800 Message-ID: Subject: Re: [PATCH] drm/tests/buddy: fix build with unused prng From: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= To: Matthew Auld , dri-devel@lists.freedesktop.org Cc: Jani Nikula , Arunpravin Paneer Selvam , Christian =?ISO-8859-1?Q?K=F6nig?= Date: Wed, 15 Jan 2025 13:42:03 +0100 In-Reply-To: References: <20250115123734.154243-2-matthew.auld@intel.com> Organization: Intel Sweden AB, Registration Number: 556189-6027 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.2 (3.54.2-1.fc41) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 2025-01-15 at 13:40 +0100, Thomas Hellstr=C3=B6m wrote: > On Wed, 2025-01-15 at 12:37 +0000, Matthew Auld wrote: > > We no longer use the prng, which leads to the following warning: > >=20 > > drivers/gpu/drm/tests/drm_buddy_test.c: In function > > =E2=80=98drm_test_buddy_alloc_clear=E2=80=99: > > drivers/gpu/drm/tests/drm_buddy_test.c:264:23: error: unused > > variable > > =E2=80=98prng=E2=80=99 [-Werror=3Dunused-variable] > > =C2=A0 264 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DRM_RND_ST= ATE(prng, random_seed); > >=20 > > Reported-by: Jani Nikula > > Reported-by: Thomas Hellstr=C3=B6m > > Fixes: 8cb3a1e2b350 ("drm/buddy: Add a testcase to verify the > > multiroot fini") > > Signed-off-by: Matthew Auld > > Cc: Arunpravin Paneer Selvam > > Cc: Christian K=C3=B6nig >=20 > Reviewed-by: Thomas Hellstr=C3=B6m Oh, checkpatch.pl might complain about some missing tags, though, like Closes: or Link: /Thomas >=20 > > --- > > =C2=A0drivers/gpu/drm/tests/drm_buddy_test.c | 1 - > > =C2=A01 file changed, 1 deletion(-) > >=20 > > diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c > > b/drivers/gpu/drm/tests/drm_buddy_test.c > > index 4b5818f9f2a9..7a0e523651f0 100644 > > --- a/drivers/gpu/drm/tests/drm_buddy_test.c > > +++ b/drivers/gpu/drm/tests/drm_buddy_test.c > > @@ -261,7 +261,6 @@ static void > > drm_test_buddy_alloc_range_bias(struct kunit *test) > > =C2=A0static void drm_test_buddy_alloc_clear(struct kunit *test) > > =C2=A0{ > > =C2=A0 unsigned long n_pages, total, i =3D 0; > > - DRM_RND_STATE(prng, random_seed); > > =C2=A0 const unsigned long ps =3D SZ_4K; > > =C2=A0 struct drm_buddy_block *block; > > =C2=A0 const int max_order =3D 12; >=20