From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Hannes Reinecke <hare@kernel.org>, Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvmet: do not return 'reserved' for empty TSAS values
Date: Fri, 14 Jun 2024 23:42:29 +0000 [thread overview]
Message-ID: <a4b4cab1-4eee-469f-a336-6b0f79cdc4db@nvidia.com> (raw)
In-Reply-To: <20240614104423.103215-1-hare@kernel.org>
On 6/14/24 03:44, Hannes Reinecke wrote:
> The 'TSAS' value is only defined for TCP and RDMA, but returning
> 'reserved' for undefined values tricked nvmetcli to try to write
> 'reserved' when restoring from a config file. This caused an error
> and the configuration would not be applied.
>
> Fixes: 3f123494db72 ("nvmet: make TCP sectype settable via configfs")
>
> Signed-off-by: Hannes Reinecke<hare@kernel.org>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
prev parent reply other threads:[~2024-06-14 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 10:44 [PATCH] nvmet: do not return 'reserved' for empty TSAS values Hannes Reinecke
2024-06-14 16:48 ` Christoph Hellwig
2024-06-14 23:42 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4b4cab1-4eee-469f-a336-6b0f79cdc4db@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.