From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD86B3BF696 for ; Tue, 30 Jun 2026 19:24:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.13 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782847444; cv=fail; b=fpEU3Mp4wUUzNT9Q/tXUBYnNTfZ1Qoesv+tCP5Pcg1/yQfq8oRoKbp0gLrrahYjDOVXPuyrj7GJYt2NJTuHjaj3wozXFA+YP5RS1wn6/XMbzbe0nB/InkBId3XvQ0l5VE8N/JchyYOOp2ynNDsMqsw0JLIYtINBoiUiyUCONP2s= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782847444; c=relaxed/simple; bh=ZVxVTI4Cq17BpbnU9dmGue5j0WyIcaCD8ufIBuP9G+M=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=snIJi9KSV6cEsYRlM90fm/z6Hj7I8NtIyCA5W0N5h8Kr81hBnMg3ygSlPFLOpoJsulDg7wrtD5vdJY4nOIUzK0GNzVYMo6U4zx+LdGKW6cpHIX7+Zcpa7cqCD2L2/ZH1sq02hKu/Qbw5nTf5NADjo+WUuaHS4Z1XEJ8mU3Y9rdg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NWct69oy; arc=fail smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NWct69oy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782847443; x=1814383443; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ZVxVTI4Cq17BpbnU9dmGue5j0WyIcaCD8ufIBuP9G+M=; b=NWct69oyHqdtqa2/0v2wo5Fvb+1MO5yxKRUZl5332qWaQXu0aceCky1j rwW3xKWBVGOhGB7bGscoIfqFnW8OYM6adgx3TMsLxN3G+5745wSIItp+C eTx0cujGDhuclqlfBJUqo17NbXGO6jLPdMa+DO+Bw1wp+qGYUfC3tSUHE lOdhtoTosRCMpZxLbkCaLI/XcslB7z0a8dKeH3FxbHeMmy5Ly6nA/YxCn 0uUq8+PMN1nxOP+RxE9eCbJfLnN2naGOjlA42obuwDQLoOlZZV8crZH32 NR9MdUAZLy1B13IIMiJvC9OJfR/eYHCI5BTcso6Eo6+n7yB3FH1vqrlAf Q==; X-CSE-ConnectionGUID: KYjUDoGXSxya1jUSJG9ExQ== X-CSE-MsgGUID: 4zb8KBcbT7OWkODryQvldg== X-IronPort-AV: E=McAfee;i="6800,10657,11833"; a="94721897" X-IronPort-AV: E=Sophos;i="6.24,234,1774335600"; d="scan'208";a="94721897" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2026 12:24:03 -0700 X-CSE-ConnectionGUID: wVb/m//ITSyeVnUHP3CazA== X-CSE-MsgGUID: CaDCIK4qTIGXsiStgN2kvQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,234,1774335600"; d="scan'208";a="248986757" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2026 12:24:03 -0700 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Tue, 30 Jun 2026 12:24:03 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43 via Frontend Transport; Tue, 30 Jun 2026 12:24:03 -0700 Received: from CY3PR05CU001.outbound.protection.outlook.com (40.93.201.68) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Tue, 30 Jun 2026 12:24:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zRnkfZDX6FUFYwur2S+xHrYdsqCaLZknjZuh9uLayH7B9WmGtWONuRtx4XuRPFmDrJ2W1CzKeFwnvi8MVpAH1w0iWSbtDwaANqOiZBY5Om8mu68QUzgiMrnesLMwUSuHGQXIXrg5dK6OC3Ds6TupCLsPD/pOEmDypBWuu0vrAYfCxVdUAg6l5zlfCncDrrNLeLNud0imVGICqbtdrbo5MCUHep8npk+bii6GEupuRFzhx8L273uesdV7iCTjj2YpqKrR2HeLCkKOKnOF28MtE/tB/+H1aBBBwQdWfn2/88+jA7IlCzaTZI6d+uBeo49jjYtwaKoxMgoe7RYGXCvGPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g/G+XkLXq77qazo/Iy7F4KyahDjqP8gmiTi6hXiwM1s=; b=rG2mY6P3PU+V3QD4gu+bd6lWlZIm+rpdnTNJHboBYGlMcGVMxitMCGJHekIZ7si0kdAFL8ck/d6iC/aG081qxgtN8hXGSqh3qBTAPXJt7WubhGVnjDrv3zRiCKz8x8DW95yUI5sHGNft+XBMBp5KARioFzBKDY303QqzUl52QaH0sRIT0Ov4A8aixDKgd4e0DX+vBYduXMuGwcJGKbwj/HrL2hIJ86YS8PPmiRJ8lBa1ehWmGlX557TlNdX+A7JuV6UrV1JaMTO6MUUsU2jv2q/IJ5dAhx/e/ax4WO2RcyYyN8dI4sWuTmizTmtYMLQ+0JfPCemxp4sqvep/BOcslw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7925.namprd11.prod.outlook.com (2603:10b6:8:f8::18) by MW4PR11MB6715.namprd11.prod.outlook.com (2603:10b6:303:20e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Tue, 30 Jun 2026 19:24:00 +0000 Received: from DS0PR11MB7925.namprd11.prod.outlook.com ([fe80::60af:89a0:65dc:9c84]) by DS0PR11MB7925.namprd11.prod.outlook.com ([fe80::60af:89a0:65dc:9c84%3]) with mapi id 15.21.0159.018; Tue, 30 Jun 2026 19:24:00 +0000 Message-ID: Date: Tue, 30 Jun 2026 12:23:59 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/10] x86/fpu: Allow restoring signal frames with larger xstate_size To: Andrei Vagin , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov CC: , , Dave Hansen , , "H. Peter Anvin" References: <20260615193716.1843340-1-avagin@google.com> <20260615193716.1843340-10-avagin@google.com> Content-Language: en-US From: "Chang S. Bae" In-Reply-To: <20260615193716.1843340-10-avagin@google.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY3PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:217::11) To DS0PR11MB7925.namprd11.prod.outlook.com (2603:10b6:8:f8::18) Precedence: bulk X-Mailing-List: criu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7925:EE_|MW4PR11MB6715:EE_ X-MS-Office365-Filtering-Correlation-Id: dcb16951-8fe8-4ff7-146f-08ded6dd2351 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|366016|56012099006|11063799006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 9kXMpeSb7t0R2mpZsO9wujX0yXVBnS/mH7L3dA1N6uBqiKlnA2LsuuLzoLV4PMvtsj8ioteZHPR/wwzuqNRRfr+l0muQDmAtAMfFyjXc+hoWoM0c6unSB0Zvf0L/wDp/0/X5u6uy+E4jVhZ+GKQJdZ6UmUsXkraj2ROld8V2o2cWRMchio/ePaTKmiTX9cOWhP9p2J8Wk5P+wjjeeo+1s0ykyHVcOQigstzSrxrPCsIY/V8t8Q3bmPfa0k+bTdDx76jcPWICwNjhLM3UxmxHPPiMGk5r3K61BvD8BelsimGzAuP1HMjYcOtwyaVZ7bTNdr9AlFDlGNfW63oEvjyN01dI0Ppve4lWxBB1iIxHy/JttAMmKcWpr8iAphtRRB8q4pnR22am7JBqdU5EXCW0X1x73O3HQKXFyVUTeF9iJeea9t/iUHlnaXsHrCeYLw6Yj0Oq7n02K6LTVq6xqPDtt7tR253S/6PaZjoUitvQDgG8iuhjFeHLCVGYBnmFR9jcXv5+uX/oxQzgaBEL/jJSx2I0YL5GdZG0XAvEc8e2O4dCRRFclzS+V9K42xkj3glkrLNg97lJgCeCLvje2H08CLSCGg7hH7HWD0K0sEDgl21qsGWlZqbG9bhiGON51qjcjQ2fpOzNzF7yjf33CNK8a9lUOhINkWVxSZUotWYA/i8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB7925.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(56012099006)(11063799006)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3NKc0ZidkZvRUdCaFQvZEdOeG1Cczl1Wjd5LzE5ZU9NeGU0RzV2TnNFWDlK?= =?utf-8?B?aVhQckZKdGFHVlRzdlFFYVdhc3ROTm1HbzZTTFcxWDg0MHJCcVB2bjBEcXl4?= =?utf-8?B?dzJIUlR3d1pFQTgvRzcvRUUreDRBdWhHbzB1R2xzNk5QWVhuNEdzc3VOK0hh?= =?utf-8?B?WE9FVk9wcjc5WExrc01xNmN2b1I2SW9rWXQ0c05ZV2JUNVlLdGxRV2llanRJ?= =?utf-8?B?MGZRVVFLNWxrcUNwSTFyMm5OZnFRWlpUMFZBUXU3aFZxSWVwVGNYZUZ2ZTl6?= =?utf-8?B?S0xqTWRpL3I0TnBPNXV2TldENFZhMVNVTXdTWFYrSHVBQzVoVGJFTHFTc1lI?= =?utf-8?B?QVRqcmhMODlFY1JnQklxZnJ0WVA5VCtBS0dkdUt5U25NR1RDNGpiY013TjUx?= =?utf-8?B?WXEvd1BSaElGMExxR2FqeHdGbjlKeDdBNVNFUFBwNUQxTU51MmdQWElrZnU0?= =?utf-8?B?QmFqTnNjUFViT05mL1BIL1d3bS9NdzVQd1NVVWFVQW1Qc2pxS28zVE1UQ20v?= =?utf-8?B?TXBDSDg5ZUtjYzlmeUJseXBzRml0NWx4TUtmbHhSbjlyaFZZMXU2QUF6NEkx?= =?utf-8?B?WWs2eWpLbGpTczV5ZEJud3NWMDF1T2hpRHBtZHZVWStiTWJsTCtpT25ZRmdP?= =?utf-8?B?M1VGcy9RdmdOaU84ZVVTMWxuVnpablF4NFJ3dVlHZ0VyMW5mU1YybHJ1U3B6?= =?utf-8?B?ZEhVZXJXMDVYN2thNUVJNk5LeVZEUGxycTEwZ2JhMlB0MC9RSzJoZlBuOUlp?= =?utf-8?B?TGZYQkJIcU10ci96cUZ6c3d5VGU1Qkp4ZUgreUlWcjgzZGgxOGtyV09POEVx?= =?utf-8?B?U3RFZHNyamtGVzdxemNOU1Z0MkxDR2taZm04WER3aVFRRzhtcW5USWdCNS9P?= =?utf-8?B?cFhjNjBsZTE5czlwNytwTkN1ZmhzdmJKZFpIcitrbDNMVzlVTW5rek9NbmVw?= =?utf-8?B?VnVMZ2dmSTd4dEUwWGJEUjZCNTJrTnRhVHE2OUMrUHdRNEcxbmljdEM5M1BP?= =?utf-8?B?VXlibGFHOXhCK1NsT0JGa3A2dmU1WmdNdEkzSjdKck5EV1dvaExvZlJ3T2Z1?= =?utf-8?B?WFZ5SWZJSDJOelRpNGg3YWI5UzhMTWFMTC9SallnQVdkQytYS1ZkaDF6bVR2?= =?utf-8?B?ZW9yU2RqbXNPT0UydE1lYWNDOXZzTmJSdnNGVXJ0Z2hoM1NOS2Zza1hCc3p6?= =?utf-8?B?UCtlMTAxVEpmRyt1MHhTNXI3ZlZNZ0ZDMVRiNjlOWXluWGk4UGg1dm11Q0VM?= =?utf-8?B?UzVkdTNiMERMN3BQRkZKeWJaOWxJd3NUcGhjU3pyQzNlRXk3ejNFVWEzM0d4?= =?utf-8?B?dnZSWWppMHBzOTEzQUlrVUFoOEhwQnlPUHM4WExFd09KWE9LTWJMMGNsYmp2?= =?utf-8?B?TlJjR3F3N2pNRC9uMHI1ZGkrMXovYUFzemxHditySHluVWs3OUJ2d3VpS245?= =?utf-8?B?VzZ2czFrcGNVWEIxSVNIM1BFQkRSVEpKSEh6UVZSNVJxdzNvbyswYXVFMWxF?= =?utf-8?B?RldRT2pVMndtc09SRTl5NEdmK0pTcVVnNFlnbDBQNHN0UUFTZWFjNEtlOUdw?= =?utf-8?B?RHIveEV3VDZnNTF6b2Z2YjJRdUE3QWorVUdzWmJ1eXAyUmxkWVhYeGpXNU5n?= =?utf-8?B?VmZkTmdOYzMvT2drTXRkZkVKQUVRd0ZySFpBcHJ3bjU3MFJwVVMvY1VqMEVS?= =?utf-8?B?czFXSGkvNVhFU3BFWm1DN201Mk96dDRhbFlUY1ppdkMycUJGV1pnUlc2K0oy?= =?utf-8?B?dFBTUkl6Z2VpV3FoVTNHUTFSUjI5b01OZkZjSmFlZmd4Ynpaa1ZKWXhjMUhR?= =?utf-8?B?bElOSEFaM0JRRTZjTmNObG5OKzJSTzVPb25pOExsRkplTUZSeUpJTktrL2F3?= =?utf-8?B?WHhPT1lKL2xheWV4aDhDODBHUUZJc1VLUVpScWtPcUJyT3djUCtYRzJJdXk5?= =?utf-8?B?THlRRk9FeUFBdEJkMEM0MERTQ2xMVi9jSENzbDR6aXFSNXhiSFdlbGVJbC8z?= =?utf-8?B?MWE5SDA1RUV3c0NyWWtmM3cyOFYxelRJRDNnRi83eG9NSVRUOWlySjVBczU2?= =?utf-8?B?NytRY01VVE94QUc0K1JUdnJ0dmhhNEdjM3JiMVNocTVaMGsra0F2SXlKQnZQ?= =?utf-8?B?Rk80d3h5cHF1V2NMT0I1WFNVMXJtZlRUNk02S3IzR01QeGRTclh3NURYSW01?= =?utf-8?B?aGh3UnhZbVlFSVpMWnFHc01tcmovRG9BY0F6TGdBZ0lrTlRISkdCeVRocEpm?= =?utf-8?B?N2o4b2hRd3E4OUw2eHBMa1JHZExSbzFLRXZsQTJ0WmVmOWlJWDFMU1A5NWZ6?= =?utf-8?B?ckRuTmRZY09tcU5tQ3piV29UMnl6UCsxT3BRWjR4WUx4WC9Gbk1wZz09?= X-Exchange-RoutingPolicyChecked: Vu9eW2UnCNc5oebOQmOpbVycmamMgEtDAzy3GWzBZmr4bCDYHisol7g4gDwIS3757ECFfKOFPaRKdz27rR1cYfd1QoHzmQzPlDPsTpmhJ/28tuxPmUBJhUNx4SDNlkTaQW88BkTjaAt5d9xZgj67SxNzUhV/8KOW28flF3q774KWXQgy8x4CbftGo2+qNZtVXm/OWYQneSReZTWA6O0c2EvBceGC7zAnxfxC9jpw4BWjjlJ40foGi9zzQZCNztlFFP8+s+w8kZ62smUnuEyXic8kbfoanaG1LPuoX4Dx3TWetC+Aw1lyR9bROtbezPwaazE1DKnEErDdZhYQtGqXfg== X-MS-Exchange-CrossTenant-Network-Message-Id: dcb16951-8fe8-4ff7-146f-08ded6dd2351 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7925.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2026 19:24:00.4238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: urzMAsP4crdI5Zw6HoTHrSKK4xwgu4nK6U4CAEpfXkZWcpx6CqQ5wmcj0h+k9YPVUbTRnSOEt9dWDkaaX5F4RcxkO+u89XsuSqlto0EDugA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6715 X-OriginatorOrg: intel.com On 6/15/2026 12:37 PM, Andrei Vagin wrote: > The kernel previously enforced that the xstate_size in the signal frame > must not exceed the current task's fpstate->user_size. This prevents > restoring signal frames that were saved on another CPU (in case of > container/process migration) with a different (larger) set of enabled > xstate features, even if the features to be restored are compatible. > > Relax this restriction by removing the strict check against user_size. > The previous commit introduced infrastructure to calculate the actual > required size based on the intersection of requested and supported > features. We now rely on that validation and only require that the > provided xstate_size is sufficient for the active features. I appreciate the effort to document the contract, add regression tests, and tighten the validation logic along with the revert fix so far in this series. But I'm wondering this bit of relaxing the checker is really necessary at this point. With APX, userspace can no longer assume that a higher XSTATE component number implies a higher offset within the XSAVE image. Going forward, migration software will likely need a more robust approach that interprets the layout and transforms the image when moving between machines with different layouts. With such translation, maybe further relaxing the kernel-side checker isn't that needed. Thanks, Chang