From: bankita@codeaurora.org
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jouni Malinen <jouni@codeaurora.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: Add per peer statistics to compute FCS error rate
Date: Thu, 04 Oct 2018 23:02:20 +0530 [thread overview]
Message-ID: <a4d0af139d550a248ecd280798bbdd2a@codeaurora.org> (raw)
In-Reply-To: <1538389142.3126.29.camel@sipsolutions.net>
On 2018-10-01 15:49, Johannes Berg wrote:
> On Thu, 2018-09-27 at 18:01 +0300, Jouni Malinen wrote:
>> From: Ankita Bajaj <bankita@codeaurora.org>
>>
>> Add support for drivers to report the total number of MPDUs received
>> and the number of MPDUs received with an FCS error from a specific
>> peer. These counters will be incremented only when the TA of the
>> frame matches the MAC address of the peer irrespective of FCS
>> error.
We do have rx_packets field but it is for MMPDUs and MSDUs which might
not reflect the number of MPDUs in all cases. Hence we introduced new
field for MPDU count.
> Hmm. The error one seems mostly reasonable, I guess, but do we really
> not having anything that's the total number of MPDUs already?
>
> And then, I guess, what exactly would you want there? We might not
> always even be able to provide that?
> I'm also left wondering what the application here is -
These two fields together will help to find bad rx link with a specific
peer. This information can be used for example to steer the client to a
different BSS.
Ankita
prev parent reply other threads:[~2018-10-04 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 15:01 [PATCH] nl80211: Add per peer statistics to compute FCS error rate Jouni Malinen
2018-10-01 10:19 ` Johannes Berg
2018-10-04 17:32 ` bankita [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4d0af139d550a248ecd280798bbdd2a@codeaurora.org \
--to=bankita@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=jouni@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.