From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08508CDE020 for ; Thu, 26 Sep 2024 16:16:06 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.805713.1216894 (Exim 4.92) (envelope-from ) id 1str9n-0000SB-QF; Thu, 26 Sep 2024 16:15:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 805713.1216894; Thu, 26 Sep 2024 16:15:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1str9n-0000S4-Nb; Thu, 26 Sep 2024 16:15:55 +0000 Received: by outflank-mailman (input) for mailman id 805713; Thu, 26 Sep 2024 16:15:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1str9m-0000Ry-86 for xen-devel@lists.xenproject.org; Thu, 26 Sep 2024 16:15:54 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98cb49fc-7c22-11ef-a0ba-8be0dac302b0; Thu, 26 Sep 2024 18:15:52 +0200 (CEST) Received: by mx.zohomail.com with SMTPS id 1727367342369981.0432054851354; Thu, 26 Sep 2024 09:15:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98cb49fc-7c22-11ef-a0ba-8be0dac302b0 ARC-Seal: i=1; a=rsa-sha256; t=1727367345; cv=none; d=zohomail.com; s=zohoarc; b=ke+40/2PyIXftExaHV3bQvulPITnjafqM6hU0NhoOQpY7vDruHuEIwZQhGBlC10X9iYWCPYOB1zOJoU/S17fMy/TIJ0lrGmNGhJNnEZ23ecp0eSdHWMJREz8GNe5ULyU/nmvrCYpsRcrpF9lhsNw9aFVO5IVfvaOZPQ6wUeDP/k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1727367345; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=3EAQu6pDQRb/Oty2zf7xDRxJkrZGmKoVbL1XyCh+9rg=; b=iuBp4YxGJZVAal/1rKiLMF1ec7Q/fyILExSH2cOg7JzqLiUl7XiYqzeOzbnVoDuIeAQB+hRs5Ut8uKfHmn16XhWJ4KUkysX5uTdTTgFeSP9YGd5EjUvKeZ2YdJSa8NnPLlLK3JMjGH0pz8opKql3ZupRndlRHndw3c+14vZtQa8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1727367345; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=3EAQu6pDQRb/Oty2zf7xDRxJkrZGmKoVbL1XyCh+9rg=; b=ZdeHytsx2rRhGCNBU0gnnTQqxsQIfSJfCTz2/WtVv2YzmgxRXQ+63P1k/k5Lve4n ULlTsbBeDHBthMnJufS0MTyGkBNVECVl5A9PELFgjlvdnJ64MWOGn8lh8Ic0203vn2O 6R+qtkjwB1qJ2RqAAmKqpDP7yZjUAsu0LYshThSQ= Message-ID: Date: Thu, 26 Sep 2024 12:15:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/44] x86/boot: convert consider_modules to struct boot_module Content-Language: en-US To: Andrew Cooper , Jan Beulich Cc: jason.andryuk@amd.com, christopher.w.clark@gmail.com, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org References: <20240830214730.1621-1-dpsmith@apertussolutions.com> <20240830214730.1621-7-dpsmith@apertussolutions.com> <9208e790-e772-4f42-8fdc-38fe1976dc34@citrix.com> From: "Daniel P. Smith" Autocrypt: addr=dpsmith@apertussolutions.com; keydata= xsJuBFYrueARCACPWL3r2bCSI6TrkIE/aRzj4ksFYPzLkJbWLZGBRlv7HQLvs6i/K4y/b4fs JDq5eL4e9BdfdnZm/b+K+Gweyc0Px2poDWwKVTFFRgxKWq9R7McwNnvuZ4nyXJBVn7PTEn/Z G7D08iZg94ZsnUdeXfgYdJrqmdiWA6iX9u84ARHUtb0K4r5WpLUMcQ8PVmnv1vVrs/3Wy/Rb foxebZNWxgUiSx+d02e3Ad0aEIur1SYXXv71mqKwyi/40CBSHq2jk9eF6zmEhaoFi5+MMMgX X0i+fcBkvmT0N88W4yCtHhHQds+RDbTPLGm8NBVJb7R5zbJmuQX7ADBVuNYIU8hx3dF3AQCm 601w0oZJ0jGOV1vXQgHqZYJGHg5wuImhzhZJCRESIwf+PJxik7TJOgBicko1hUVOxJBZxoe0 x+/SO6tn+s8wKlR1Yxy8gYN9ZRqV2I83JsWZbBXMG1kLzV0SAfk/wq0PAppA1VzrQ3JqXg7T MZ3tFgxvxkYqUP11tO2vrgys+InkZAfjBVMjqXWHokyQPpihUaW0a8mr40w9Qui6DoJj7+Gg DtDWDZ7Zcn2hoyrypuht88rUuh1JuGYD434Q6qwQjUDlY+4lgrUxKdMD8R7JJWt38MNlTWvy rMVscvZUNc7gxcmnFUn41NPSKqzp4DDRbmf37Iz/fL7i01y7IGFTXaYaF3nEACyIUTr/xxi+ MD1FVtEtJncZNkRn7WBcVFGKMAf+NEeaeQdGYQ6mGgk++i/vJZxkrC/a9ZXme7BhWRP485U5 sXpFoGjdpMn4VlC7TFk2qsnJi3yF0pXCKVRy1ukEls8o+4PF2JiKrtkCrWCimB6jxGPIG3lk 3SuKVS/din3RHz+7Sr1lXWFcGYDENmPd/jTwr1A1FiHrSj+u21hnJEHi8eTa9029F1KRfocp ig+k0zUEKmFPDabpanI323O5Tahsy7hwf2WOQwTDLvQ+eqQu40wbb6NocmCNFjtRhNZWGKJS b5GrGDGu/No5U6w73adighEuNcCSNBsLyUe48CE0uTO7eAL6Vd+2k28ezi6XY4Y0mgASJslb NwW54LzSSM0uRGFuaWVsIFAuIFNtaXRoIDxkcHNtaXRoQGFwZXJ0dXNzb2x1dGlvbnMuY29t PsJ6BBMRCAAiBQJWK7ngAhsjBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRBTc6WbYpR8 KrQ9AP94+xjtFfJ8gj5c7PVx06Zv9rcmFUqQspZ5wSEkvxOuQQEAg6qEsPYegI7iByLVzNEg 7B7fUG7pqWIfMqFwFghYhQzOwU0EViu54BAIAL6MXXNlrJ5tRUf+KMBtVz1LJQZRt/uxWrCb T06nZjnbp2UcceuYNbISOVHGXTzu38r55YzpkEA8eURQf+5hjtvlrOiHxvpD+Z6WcpV6rrMB kcAKWiZTQihW2HoGgVB3gwG9dCh+n0X5OzliAMiGK2a5iqnIZi3o0SeW6aME94bSkTkuj6/7 OmH9KAzK8UnlhfkoMg3tXW8L6/5CGn2VyrjbB/rcrbIR4mCQ+yCUlocuOjFCJhBd10AG1IcX OXUa/ux+/OAV9S5mkr5Fh3kQxYCTcTRt8RY7+of9RGBk10txi94dXiU2SjPbassvagvu/hEi twNHms8rpkSJIeeq0/cAAwUH/jV3tXpaYubwcL2tkk5ggL9Do+/Yo2WPzXmbp8vDiJPCvSJW rz2NrYkd/RoX+42DGqjfu8Y04F9XehN1zZAFmCDUqBMa4tEJ7kOT1FKJTqzNVcgeKNBGcT7q 27+wsqbAerM4A0X/F/ctjYcKwNtXck1Bmd/T8kiw2IgyeOC+cjyTOSwKJr2gCwZXGi5g+2V8 NhJ8n72ISPnOh5KCMoAJXmCF+SYaJ6hIIFARmnuessCIGw4ylCRIU/TiXK94soilx5aCqb1z ke943EIUts9CmFAHt8cNPYOPRd20pPu4VFNBuT4fv9Ys0iv0XGCEP+sos7/pgJ3gV3pCOric p15jV4PCYQQYEQgACQUCViu54AIbDAAKCRBTc6WbYpR8Khu7AP9NJrBUn94C/3PeNbtQlEGZ NV46Mx5HF0P27lH3sFpNrwD/dVdZ5PCnHQYBZ287ZxVfVr4Zuxjo5yJbRjT93Hl0vMY= In-Reply-To: <9208e790-e772-4f42-8fdc-38fe1976dc34@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 9/4/24 06:41, Andrew Cooper wrote: > On 04/09/2024 7:40 am, Jan Beulich wrote: >> On 30.08.2024 23:46, Daniel P. Smith wrote: >>> @@ -1447,7 +1447,7 @@ void asmlinkage __init noreturn __start_xen(unsigned long mbi_p) >>> { >>> /* Don't overlap with modules. */ >>> end = consider_modules(s, e, reloc_size + mask, >>> - mod, boot_info->nr_mods, -1); >>> + boot_info->mods, boot_info->nr_mods, -1); >>> end &= ~mask; >>> } >>> else >>> @@ -1482,7 +1482,7 @@ void asmlinkage __init noreturn __start_xen(unsigned long mbi_p) >>> continue; >>> >>> /* Don't overlap with other modules (or Xen itself). */ >>> - end = consider_modules(s, e, size, mod, >>> + end = consider_modules(s, e, size, boot_info->mods, >>> boot_info->nr_mods + relocated, j); >>> >>> if ( highmem_start && end > highmem_start ) >>> @@ -1509,7 +1509,7 @@ void asmlinkage __init noreturn __start_xen(unsigned long mbi_p) >>> while ( !kexec_crash_area.start ) >>> { >>> /* Don't overlap with modules (or Xen itself). */ >>> - e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), mod, >>> + e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), boot_info->mods, >>> boot_info->nr_mods + relocated, -1); >> All of these show a meaningful increase of line lengths, up to the point of >> ending up with too long a line here. I really wonder if the variable name >> "boot_info" isn't too long for something that's going to be used quite >> frequently. Just "bi" maybe? > > Actually I noticed that too. > > It's boot_info-> in setup.c, and bi-> everywhere else (with bm later too). > > We should just use "bi" uniformly even in setup.c  (Or some other name, > but I'm happy with bi here - it's very easily qualified by it's field > names.) Yes, I did make it "bi" as it was passed around, and will move setup.c to that as well. As for "bm", I will be moving the array into struct boot_info. When I do, is there a desire to see the element name to be "bm" or "bms"? v/r, dps