From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9716343B3F7 for ; Mon, 24 Aug 2026 14:30:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787581813; cv=none; b=rqRCWuK8WpVat5W3Zwx5u7DNGOhuzLmgJO+6fb+MQSt65RVl+w9CndZOXecjw5HAHP5OGXSy0et4KN0US3out10VqdZPJ6zLcHDMwqq0rT7x11ccAZOf5RSmjwhTkBvtmaWLoXFyDtKQ7Sa5CZ8Tj0jTi01RKylaor577G5SV9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787581813; c=relaxed/simple; bh=9DZojNp3mZvt3EkXO4hFRxVx3MJf/eYMKHBe+MyaBCs=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=QXPtfCSnOEsKDb3/fiMMH0Zx2mrWu7pqQ4XEHX9sE2nir7aThnO8wCgp63Xso+ICuVz51l9PIDDLyS+N1vXHAgf0N07zI9oydeH/SngIyVBauCo8FL7tXhyVnbBHJBc8cBpF4vRYZMgYL/vFjBMlr7gk9GGo4j+l4P6ncO/9TJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=c/BVKwms; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="c/BVKwms" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-84c4d4f68c7so38291327b3.2 for ; Mon, 24 Aug 2026 07:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787581810; x=1788186610; darn=vger.kernel.org; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jkA2C/lQgXcypv6Ly6gx3bJF+pwu7LTevogMVJJ14Qg=; b=c/BVKwmskUlMdRTYj31BuO49DkQnZEsVS88LeGTloCLEWl67MFMWY9U6KoXZpWhL40 eRqUhLiCwNUHpoEAUbBakuEAE2RKa+OlK1PdTbgFZGSU6shJu4ef5s3HBzjKEue10BCh UaP72LhLPnPAwjIP/0lrcR7VmeJLeBadr6kBuOisMv3a0sLliDOg1cP7hOGxwMRZjqd4 IOGkyaDIwLoLH9X+/dH6BzXl5D5dmur3c+IMW6zopQSrIza0DobJfZO/OAnCv5ZqcNn5 oyszmgqtJojMd1wJIu+uEorStzGdD/KvpdkMbeUZCx0S0fyCX+422ZIVPjWNd6EqqMj2 Yj6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787581810; x=1788186610; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jkA2C/lQgXcypv6Ly6gx3bJF+pwu7LTevogMVJJ14Qg=; b=oopV4+VEVNjybSM2WA0F0R3BmK7dt3wsEZXOy6l4xft+uFjaAYEiWNgQ3YcElzdsHB DjBUZnu0ldRwLvboAZaEUKJgf48+gInvR4nOqwuBpClY9GJZWQtgh8pUD+5Z6wd2ZXV+ mfU01RPJyymYdCiwILTSkjnby0Yi2/q7OPTgPjkedrbCiGdc1SOz27S29VvQWpeaR/k7 C1+INnPrXjuGfOY9U2f6inTHFXhvsOsrVgSIXby9fi4k8qsC/K8ubj/TTD1CLAPYxgjQ v+fGpp4V9IuHKkMEe38/vk3EYxfXQv8ziPLR7GZzgHBewZB30IqBvp8nztmFH6FWvADN 7jqg== X-Forwarded-Encrypted: i=1; AHgh+RrwtlxPMabwj9MOQC3vgzIqeJ1tFJcvMOc2WFSRXzgRHgcve+wctpVM06UvIMF0+gKRUGCfnExx8ZcLgA==@vger.kernel.org X-Gm-Message-State: AFuF++nXrfbyTmS35n9otIfZYr6vrY9APYmrLvVCjYAl80QmGev+oyee WbcHz8yH58mOZOQqh7EF0KjC846nI06rW4ZRWh/mNJQB4AFmZ8NoXjOgRqnxpJRtRQ== X-Gm-Gg: AR+sD110NuxyhGbFaZoCBqs97LtpZMwEKk31e1TZZz8bUOC6iIj0qQZaK6KssonG4Q8 +rVZTspLM57TbrQ0H9cG3uTq53Li8cgM64uZqIWabW5nWHGAo+dEwP7PJ3v/y6APvH4TZCi8fgR 2UF7P3D89XRAFEo2DBn+TkuNQANhk05/NGjPbPiRhxX8+HSDDKSTlKiGzkTFsMHVJYuIGQbpKjd /0lHndigNmUds5sSi/cjWB1Wqq6IVqaYuIPUdJVIlhC8vePw4l1GcAs0ECQcjXqtZO+oK8Uyobf MzffNq1sk87IHhd15/pR4WGqmwCVv+2px7liTjeW/xFIUX40VUiU+O0H3D14Q4pwuMdAJBS+Dgu sww3iWOmRCeR8mIQ5/0+yzxyOhYxkv2sl5yG+pmFOaJL1CzXPiUi9ZngS3IlUhCYTYOcTRV1E+K /0FPk6LFDMsrjPAoiF9D7s0YMXUWX59LRLEfEKp6ERMCZuei//F3PX6Bqffly9z5xgFpG1Ylh86 S5RcyV7LeR7si/2SVxJlWg8U8vP5lo7GGAU5pcEyYx9qUgnY6hvDPqNFj0= X-Received: by 2002:a05:690c:e29a:20b0:81e:eaaa:535b with SMTP id 00721157ae682-849f6c946f8mr72860737b3.35.1787581809761; Mon, 24 Aug 2026 07:30:09 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84caabb9e88sm34055617b3.29.2026.08.24.07.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 07:30:08 -0700 (PDT) Date: Mon, 24 Aug 2026 07:30:04 -0700 (PDT) From: Hugh Dickins To: Andrew Morton cc: Ackerley Tng , Alexander Viro , Baolin Wang , Barry Song , Binbin Wu , Christian Brauner , Christoph Hellwig , Christoph Lameter , Claudio Imbrenda , David Hildenbrand , JP Kobryn , Jan Kara , Jens Axboe , Johannes Weiner , Kairui Song , Kiryl Shutsemau , Lance Yang , Leonardo Bras , Lorenzo Stoakes , Marcelo Tosatti , Matthew Wilcox , Mel Gorman , Miaohe Lin , Michal Hocko , Minchan Kim , Muchun Song , Oscar Salvador , Peter Zijlstra , Qi Zheng , Rik van Riel , Sebastian Andrzej Siewior , Shakeel Butt , Suren Baghdasaryan , Vlastimil Babka , Yang Shi , Yu Zhao , Zach O'Keefe , Zi Yan , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 16/25] mm/fbatch: remove lru_cache_disable(() from NUMA folio migration In-Reply-To: <14a16945-529b-8bc0-ab38-3ea97e54e223@google.com> Message-ID: References: <14a16945-529b-8bc0-ab38-3ea97e54e223@google.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Remove lru_cache_disable() from mbind(MOVE), migrate_pages and move_pages syscall handling. They do not now benefit from lru_add_drain_all() first; they gain little benefit from invalidating buffer head LRUs first, since 5.0 commit 80409c65e2c6 ("mm: migrate: make buffer_migrate_page_norefs() actually succeed"); and it's a shame that (even without CAP_SYS_NICE) they can prevent concurrent tasks from enjoying the use of those caches. Signed-off-by: Hugh Dickins --- mm/mempolicy.c | 7 ------- mm/migrate.c | 3 --- 2 files changed, 10 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 501e0b80d7da..44912d707d57 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1343,8 +1343,6 @@ int do_migrate_pages(struct mm_struct *mm, const nodemask_t *from, long err = 0; nodemask_t tmp; - lru_cache_disable(); - /* * Find a 'source' bit set in 'tmp' whose corresponding 'dest' * bit in 'to' is not also set in 'tmp'. Clear the found 'source' @@ -1425,7 +1423,6 @@ int do_migrate_pages(struct mm_struct *mm, const nodemask_t *from, break; } - lru_cache_enable(); if (err < 0) return err; return (nr_failed < INT_MAX) ? nr_failed : INT_MAX; @@ -1530,8 +1527,6 @@ static long do_mbind(unsigned long start, unsigned long len, if (!new) flags |= MPOL_MF_DISCONTIG_OK; - if (flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)) - lru_cache_disable(); { NODEMASK_SCRATCH(scratch); if (scratch) { @@ -1626,8 +1621,6 @@ static long do_mbind(unsigned long start, unsigned long len, putback_movable_pages(&pagelist); mpol_out: mpol_put(new); - if (flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)) - lru_cache_enable(); return err; } diff --git a/mm/migrate.c b/mm/migrate.c index 534908a0839a..bf9fe533a5fb 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -2360,8 +2360,6 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, int start, i; int err = 0, err1; - lru_cache_disable(); - for (i = start = 0; i < nr_pages; i++) { const void __user *p; int node; @@ -2440,7 +2438,6 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, if (err >= 0) err = err1; out: - lru_cache_enable(); return err; } -- 2.51.0