All of lore.kernel.org
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: cygnus: fix irq type for arm global timer
Date: Thu, 3 May 2018 08:06:15 -0700	[thread overview]
Message-ID: <a5149af0-788a-e368-4f98-e228100360de@gmail.com> (raw)
In-Reply-To: <20180503094445.324-1-peron.clem@gmail.com>

Hi Clement,

Adding Ray, Scott, Eric and bcm-kernel-feedback-list

On 05/03/2018 02:44 AM, Cl?ment P?ron wrote:
> As per ARM documentation
> PPI(0) ID27 - global timer interrupt is rising-edge sensitive.
> 
> set IRQ triggering type to IRQ_TYPE_EDGE_RISING for ARM Global timers.

This looks right and consistent with what was done on other iProc
processors (BCM5301x, NSP etc.). Would you mind providing an appropriate
Fixes: tag such that this can get backported to stable trees as well?

Thanks!

> 
> Signed-off-by: Cl?ment P?ron <peron.clem@gmail.com>
> ---
>  arch/arm/boot/dts/bcm-cygnus.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 699fdf94d139..9fe4f5a6379e 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -69,7 +69,7 @@
>  		timer at 20200 {
>  			compatible = "arm,cortex-a9-global-timer";
>  			reg = <0x20200 0x100>;
> -			interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupts = <GIC_PPI 11 IRQ_TYPE_EDGE_RISING>;
>  			clocks = <&periph_clk>;
>  		};
>  
> 

-- 
Florian

      reply	other threads:[~2018-05-03 15:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03  9:44 [PATCH] ARM: dts: cygnus: fix irq type for arm global timer Clément Péron
2018-05-03 15:06 ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5149af0-788a-e368-4f98-e228100360de@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.