RE: [bitbake-devel] [PATCH] fetch2/git: Simplify the validation of SHA-1 revisions

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> Sent: den 14 april 2022 18:28
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; bitbake-
> devel@lists.openembedded.org
> Subject: Re: [bitbake-devel] [PATCH] fetch2/git: Simplify the validation
> of SHA-1 revisions
> 
> On Thu, 2022-04-14 at 17:42 +0200, Peter Kjellerstedt wrote:
> > Also correct two comments.
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > ---
> >  bitbake/lib/bb/fetch2/git.py | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
> > index b3eb8248d0..90104ac383 100644
> > --- a/bitbake/lib/bb/fetch2/git.py
> > +++ b/bitbake/lib/bb/fetch2/git.py
> > @@ -248,9 +248,10 @@ class Git(FetchMethod):
> >
> >          ud.setup_revisions(d)
> >
> > +        sha1_re = re.compile(r'^[0-9a-f]{40}$')
> 
> re.compile() is expensive so in general we should cache that or do it at
> the module top level...

Sure, I can move it to the module top level.

I based the use of re.compile() in that class on how it was done in 
the _revision_key() function. Do you want me to move its slash_re as 
well?

> Cheers,
> 
> Richard

//Peter