From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abdulrasaq Lawani <abdulrasaqolawani@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org
Cc: skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: sound: Convert max98088 to dtschema
Date: Wed, 12 Jun 2024 17:04:41 +0200 [thread overview]
Message-ID: <a5357897-9bb3-4297-843d-c97dadc3de4b@kernel.org> (raw)
In-Reply-To: <20240612145903.497758-1-abdulrasaqolawani@gmail.com>
On 12/06/2024 16:59, Abdulrasaq Lawani wrote:
> Convert the max98088 audio codec txt bindings to DT schema.
>
> Signed-off-by: Abdulrasaq Lawani <abdulrasaqolawani@gmail.com>
> ---
> Validated with dtschema and tested against samsung/exynos5800-peach-pi.dts.
What?
This is not a codec for this board. You are mixing now
Documentation/devicetree/bindings/sound/maxim,max98090.yaml
Whatever you validated against Peach Pi DTS is wrong or not enough. You
need to validate it against DTS using this binding.
> +
> +maintainers:
> + - Abdulrasaq Lawani <abdulrasaqolawani@gmail.com>
> +
> +properties:
> + compatible:
> + enum:
> + - maxim,max98088
> + - maxim,max98091
91? You meant 89...
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-12 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 14:59 [PATCH v2] dt-bindings: sound: Convert max98088 to dtschema Abdulrasaq Lawani
2024-06-12 15:04 ` Krzysztof Kozlowski [this message]
2024-06-12 16:26 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5357897-9bb3-4297-843d-c97dadc3de4b@kernel.org \
--to=krzk@kernel.org \
--cc=abdulrasaqolawani@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.