From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6CF3C43334 for ; Thu, 23 Jun 2022 01:54:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 508C7410BB; Thu, 23 Jun 2022 01:54:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 508C7410BB X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U_1Ls-Zkj-yW; Thu, 23 Jun 2022 01:54:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id B0C78409F0; Thu, 23 Jun 2022 01:54:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B0C78409F0 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 84C67C0032; Thu, 23 Jun 2022 01:54:56 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id C6CEFC002D for ; Thu, 23 Jun 2022 01:54:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9361D83163 for ; Thu, 23 Jun 2022 01:54:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9361D83163 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lnfi5yUf8ODH for ; Thu, 23 Jun 2022 01:54:53 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org BA19680B99 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by smtp1.osuosl.org (Postfix) with ESMTPS id BA19680B99 for ; Thu, 23 Jun 2022 01:54:52 +0000 (UTC) X-UUID: 5997c256dc0d48849e0a4781ec098522-20220623 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6, REQID:88c7e930-efc3-41f6-98bf-236f94738288, OB:0, LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:b14ad71, CLOUDID:5332cc2d-1756-4fa3-be7f-474a6e4be921, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: 5997c256dc0d48849e0a4781ec098522-20220623 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1236942881; Thu, 23 Jun 2022 09:54:46 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 23 Jun 2022 09:54:45 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 23 Jun 2022 09:54:44 +0800 Message-ID: Subject: Re: [PATCH v2 2/5] iommu/mediatek: Add error path for loop of mm_dts_parse To: Robin Murphy Date: Thu, 23 Jun 2022 09:54:44 +0800 In-Reply-To: <521ed82e-f213-f635-6f5e-3e35ff8cc020@arm.com> References: <20220616054203.11365-1-yong.wu@mediatek.com> <20220616054203.11365-3-yong.wu@mediatek.com> <521ed82e-f213-f635-6f5e-3e35ff8cc020@arm.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Cc: anan.sun@mediatek.com, chengci.xu@mediatek.com, xueqi.zhang@mediatek.com, linux-kernel@vger.kernel.org, libo.kang@mediatek.com, yf.wang@mediatek.com, Guenter Roeck , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Dan Carpenter , Matthias Brugger , Will Deacon , mingyuan.ma@mediatek.com, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Yong Wu via iommu Reply-To: Yong Wu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, 2022-06-16 at 11:31 +0100, Robin Murphy wrote: > On 2022-06-16 11:08, Yong Wu wrote: > > On Thu, 2022-06-16 at 09:59 +0100, Robin Murphy wrote: > > > On 2022-06-16 06:42, Yong Wu wrote: > > > > The mtk_iommu_mm_dts_parse will parse the smi larbs nodes. if > > > > the > > > > i+1 > > > > larb is parsed fail(return -EINVAL), we should of_node_put for > > > > the > > > > 0..i > > > > larbs. In the fail path, one of_node_put matches with > > > > of_parse_phandle in > > > > it. > > > > > > > > Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow > > > > with > > > > the MM TYPE") > > > > Signed-off-by: Yong Wu > > > > --- > > > > drivers/iommu/mtk_iommu.c | 21 ++++++++++++++++----- > > > > 1 file changed, 16 insertions(+), 5 deletions(-) [snip..] > > > > +err_larbnode_put: > > > > + while (i--) { > > > > + larbnode = of_parse_phandle(dev->of_node, > > > > "mediatek,larbs", i); > > > > + if (larbnode && > > > > of_device_is_available(larbnode)) { > > > > + of_node_put(larbnode); > > > > + of_node_put(larbnode); > > > > + } > > > > > > This looks a bit awkward - could we not just iterate through > > > data->larb_imu and put dev->of_node for each valid dev? > > > > It should work. Thanks very much. > > > > > > > > Also, of_find_device_by_node() takes a reference on the struct > > > device > > > itself, so strictly we should be doing put_device() on those as > > > well > > > if we're bailing out. > > > > Thanks for this hint. A new reference for me. I will add it. > > In fact, thinking about it some more we may as well do the > of_node_put() > unconditionally immediately after the of_find_device_by_node() call, of_node_put is called in component_release_of in the normal case, thus we shouldn't call of_node_put unconditionally. Right? (Sorry for reply late) > so > then it's *only* the device references we'd need to worry about > cleaning > up in the failure path. > > Robin. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71857C43334 for ; Thu, 23 Jun 2022 02:14:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rGGRqcgwS+LxOK6gOaMp4/oVXpHYi1OCGNbHBCXp1yQ=; b=gJpetDBFipZYe//7qAujNB9PG4 mgOqTfuvla5Q9INR/F8+19ZYFAqsQX7fd3hl2FbML42Mq31kChc8xM+i8D29EqquYgP9DTzrCdjDi lm9DzsrzNYG+o1XkDCjJLCyz7gjFcLHgPaUBuUHv5ApgWWD0Trz+BAkG0z5SyfEeelTMjX9A/1XiZ CFGNzJ0WC5PrRYZfNEOcnWI+QIOHNduZ02oynJSpQCtCjsAm8lPNXG40bSRaJh1Z8Bun2wuuUNLRR ouaDKGLGkncpXbVkgQCS6UrJaF8jWsJ2GRr3rV6RUrsy68hOAzWsLZMrL4bdFfOI4Uw0UnBRc5e5k clQYGbzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4CMJ-00Cu6e-V1; Thu, 23 Jun 2022 02:14:15 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4C3j-00Clfc-DR; Thu, 23 Jun 2022 01:55:04 +0000 X-UUID: df9ad2601bbe47b390da506d2f215e8a-20220622 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=rGGRqcgwS+LxOK6gOaMp4/oVXpHYi1OCGNbHBCXp1yQ=; b=J9qYVAPxGdpNg50Cv7efLDXDGRO3O+9eWM9s9yf2eQtl3n66AzuOONTzpObNUQG1tgL4+YjST3kPkJabwqu58M1ks4mHkinxr09441NegtmDGa3x7xAdtnu4gXgE88KBnuZNxvUIc5QfIaAFyUICnaPrDqg4ejP2w/mbjhB131Y=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:ad8ec62a-8038-405b-80f6-4957b352adb7,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:b14ad71,CLOUDID:4233cc2d-1756-4fa3-be7f-474a6e4be921,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: df9ad2601bbe47b390da506d2f215e8a-20220622 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 503366178; Wed, 22 Jun 2022 18:54:54 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Jun 2022 18:54:52 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 23 Jun 2022 09:54:45 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 23 Jun 2022 09:54:44 +0800 Message-ID: Subject: Re: [PATCH v2 2/5] iommu/mediatek: Add error path for loop of mm_dts_parse From: Yong Wu To: Robin Murphy CC: Joerg Roedel , Matthias Brugger , Will Deacon , , , , , AngeloGioacchino Del Regno , , , , , , , , Guenter Roeck , "Dan Carpenter" Date: Thu, 23 Jun 2022 09:54:44 +0800 In-Reply-To: <521ed82e-f213-f635-6f5e-3e35ff8cc020@arm.com> References: <20220616054203.11365-1-yong.wu@mediatek.com> <20220616054203.11365-3-yong.wu@mediatek.com> <521ed82e-f213-f635-6f5e-3e35ff8cc020@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220622_185503_523361_F36FC809 X-CRM114-Status: GOOD ( 26.72 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyMDIyLTA2LTE2IGF0IDExOjMxICswMTAwLCBSb2JpbiBNdXJwaHkgd3JvdGU6DQo+ IE9uIDIwMjItMDYtMTYgMTE6MDgsIFlvbmcgV3Ugd3JvdGU6DQo+ID4gT24gVGh1LCAyMDIyLTA2 LTE2IGF0IDA5OjU5ICswMTAwLCBSb2JpbiBNdXJwaHkgd3JvdGU6DQo+ID4gPiBPbiAyMDIyLTA2 LTE2IDA2OjQyLCBZb25nIFd1IHdyb3RlOg0KPiA+ID4gPiBUaGUgbXRrX2lvbW11X21tX2R0c19w YXJzZSB3aWxsIHBhcnNlIHRoZSBzbWkgbGFyYnMgbm9kZXMuIGlmDQo+ID4gPiA+IHRoZQ0KPiA+ ID4gPiBpKzENCj4gPiA+ID4gbGFyYiBpcyBwYXJzZWQgZmFpbChyZXR1cm4gLUVJTlZBTCksIHdl IHNob3VsZCBvZl9ub2RlX3B1dCBmb3INCj4gPiA+ID4gdGhlDQo+ID4gPiA+IDAuLmkNCj4gPiA+ ID4gbGFyYnMuIEluIHRoZSBmYWlsIHBhdGgsIG9uZSBvZl9ub2RlX3B1dCBtYXRjaGVzIHdpdGgN Cj4gPiA+ID4gb2ZfcGFyc2VfcGhhbmRsZSBpbg0KPiA+ID4gPiBpdC4NCj4gPiA+ID4gDQo+ID4g PiA+IEZpeGVzOiBkMmU5YTExMDJjZmMgKCJpb21tdS9tZWRpYXRlazogQ29udGFpbiBNTSBJT01N VSBmbG93DQo+ID4gPiA+IHdpdGgNCj4gPiA+ID4gdGhlIE1NIFRZUEUiKQ0KPiA+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBZb25nIFd1IDx5b25nLnd1QG1lZGlhdGVrLmNvbT4NCj4gPiA+ID4gLS0tDQo+ ID4gPiA+ICAgIGRyaXZlcnMvaW9tbXUvbXRrX2lvbW11LmMgfCAyMSArKysrKysrKysrKysrKysr LS0tLS0NCj4gPiA+ID4gICAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDUgZGVs ZXRpb25zKC0pDQoNCltzbmlwLi5dDQoNCj4gPiA+ID4gK2Vycl9sYXJibm9kZV9wdXQ6DQo+ID4g PiA+ICsJd2hpbGUgKGktLSkgew0KPiA+ID4gPiArCQlsYXJibm9kZSA9IG9mX3BhcnNlX3BoYW5k bGUoZGV2LT5vZl9ub2RlLA0KPiA+ID4gPiAibWVkaWF0ZWssbGFyYnMiLCBpKTsNCj4gPiA+ID4g KwkJaWYgKGxhcmJub2RlICYmDQo+ID4gPiA+IG9mX2RldmljZV9pc19hdmFpbGFibGUobGFyYm5v ZGUpKSB7DQo+ID4gPiA+ICsJCQlvZl9ub2RlX3B1dChsYXJibm9kZSk7DQo+ID4gPiA+ICsJCQlv Zl9ub2RlX3B1dChsYXJibm9kZSk7DQo+ID4gPiA+ICsJCX0NCj4gPiA+IA0KPiA+ID4gVGhpcyBs b29rcyBhIGJpdCBhd2t3YXJkIC0gY291bGQgd2Ugbm90IGp1c3QgaXRlcmF0ZSB0aHJvdWdoDQo+ ID4gPiBkYXRhLT5sYXJiX2ltdSBhbmQgcHV0IGRldi0+b2Zfbm9kZSBmb3IgZWFjaCB2YWxpZCBk ZXY/DQo+ID4gDQo+ID4gSXQgc2hvdWxkIHdvcmsuIFRoYW5rcyB2ZXJ5IG11Y2guDQo+ID4gDQo+ ID4gPiANCj4gPiA+IEFsc28sIG9mX2ZpbmRfZGV2aWNlX2J5X25vZGUoKSB0YWtlcyBhIHJlZmVy ZW5jZSBvbiB0aGUgc3RydWN0DQo+ID4gPiBkZXZpY2UNCj4gPiA+IGl0c2VsZiwgc28gc3RyaWN0 bHkgd2Ugc2hvdWxkIGJlIGRvaW5nIHB1dF9kZXZpY2UoKSBvbiB0aG9zZSBhcw0KPiA+ID4gd2Vs bA0KPiA+ID4gaWYgd2UncmUgYmFpbGluZyBvdXQuDQo+ID4gDQo+ID4gVGhhbmtzIGZvciB0aGlz IGhpbnQuIEEgbmV3IHJlZmVyZW5jZSBmb3IgbWUuIEkgd2lsbCBhZGQgaXQuDQo+IA0KPiBJbiBm YWN0LCB0aGlua2luZyBhYm91dCBpdCBzb21lIG1vcmUgd2UgbWF5IGFzIHdlbGwgZG8gdGhlDQo+ IG9mX25vZGVfcHV0KCkgDQo+IHVuY29uZGl0aW9uYWxseSBpbW1lZGlhdGVseSBhZnRlciB0aGUg b2ZfZmluZF9kZXZpY2VfYnlfbm9kZSgpIGNhbGwsIA0KDQpvZl9ub2RlX3B1dCBpcyBjYWxsZWQg aW4gY29tcG9uZW50X3JlbGVhc2Vfb2YgaW4gdGhlIG5vcm1hbCBjYXNlLCB0aHVzDQp3ZSBzaG91 bGRuJ3QgY2FsbCBvZl9ub2RlX3B1dCB1bmNvbmRpdGlvbmFsbHkuIFJpZ2h0Pw0KDQooU29ycnkg Zm9yIHJlcGx5IGxhdGUpDQoNCj4gc28gDQo+IHRoZW4gaXQncyAqb25seSogdGhlIGRldmljZSBy ZWZlcmVuY2VzIHdlJ2QgbmVlZCB0byB3b3JyeSBhYm91dA0KPiBjbGVhbmluZyANCj4gdXAgaW4g dGhlIGZhaWx1cmUgcGF0aC4NCj4gDQo+IFJvYmluLg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2CDBC433EF for ; Thu, 23 Jun 2022 02:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n4053fzOUy+7w5Iva3UA5YvgX/rwrmQbwNnSGd/r51E=; b=DvQD6SYQHkxHG9 RzLE6zH7CsSViMWPDYxP+DmbIwQeIIoECLCcu64XuNXRL8Q2BO2Dyn70LLbfKBP51YRV8DmV7+KFJ 6MvGJUue8ZyfAd5rci+/yDgooE+ON/nuzNHCPLiBIU+PF+DtcHGR2y6YOfQA4qAlNsz7WKfYVMWzH WOPC2z/ZjVbp3qZU5/eBBO7fFuajsVpj+FCo0nZoOM8Hr8rKZcE6M261eid5e7z8pTKaTGKQNSU5+ 2AWkr1D8t0LkWzDtQhm2C7eED/1129bVMM2xsWtZAuHBlV3u/LXHsSfpcxAZjU0ieFUqgzDXGKjb6 sOg76zr2/UnQxdTBnx9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4CMO-00Cu8V-9E; Thu, 23 Jun 2022 02:14:20 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4C3j-00Clfc-DR; Thu, 23 Jun 2022 01:55:04 +0000 X-UUID: df9ad2601bbe47b390da506d2f215e8a-20220622 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=rGGRqcgwS+LxOK6gOaMp4/oVXpHYi1OCGNbHBCXp1yQ=; b=J9qYVAPxGdpNg50Cv7efLDXDGRO3O+9eWM9s9yf2eQtl3n66AzuOONTzpObNUQG1tgL4+YjST3kPkJabwqu58M1ks4mHkinxr09441NegtmDGa3x7xAdtnu4gXgE88KBnuZNxvUIc5QfIaAFyUICnaPrDqg4ejP2w/mbjhB131Y=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:ad8ec62a-8038-405b-80f6-4957b352adb7,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:b14ad71,CLOUDID:4233cc2d-1756-4fa3-be7f-474a6e4be921,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: df9ad2601bbe47b390da506d2f215e8a-20220622 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 503366178; Wed, 22 Jun 2022 18:54:54 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Jun 2022 18:54:52 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 23 Jun 2022 09:54:45 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 23 Jun 2022 09:54:44 +0800 Message-ID: Subject: Re: [PATCH v2 2/5] iommu/mediatek: Add error path for loop of mm_dts_parse From: Yong Wu To: Robin Murphy CC: Joerg Roedel , Matthias Brugger , Will Deacon , , , , , AngeloGioacchino Del Regno , , , , , , , , Guenter Roeck , "Dan Carpenter" Date: Thu, 23 Jun 2022 09:54:44 +0800 In-Reply-To: <521ed82e-f213-f635-6f5e-3e35ff8cc020@arm.com> References: <20220616054203.11365-1-yong.wu@mediatek.com> <20220616054203.11365-3-yong.wu@mediatek.com> <521ed82e-f213-f635-6f5e-3e35ff8cc020@arm.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220622_185503_523361_F36FC809 X-CRM114-Status: GOOD ( 26.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2022-06-16 at 11:31 +0100, Robin Murphy wrote: > On 2022-06-16 11:08, Yong Wu wrote: > > On Thu, 2022-06-16 at 09:59 +0100, Robin Murphy wrote: > > > On 2022-06-16 06:42, Yong Wu wrote: > > > > The mtk_iommu_mm_dts_parse will parse the smi larbs nodes. if > > > > the > > > > i+1 > > > > larb is parsed fail(return -EINVAL), we should of_node_put for > > > > the > > > > 0..i > > > > larbs. In the fail path, one of_node_put matches with > > > > of_parse_phandle in > > > > it. > > > > > > > > Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow > > > > with > > > > the MM TYPE") > > > > Signed-off-by: Yong Wu > > > > --- > > > > drivers/iommu/mtk_iommu.c | 21 ++++++++++++++++----- > > > > 1 file changed, 16 insertions(+), 5 deletions(-) [snip..] > > > > +err_larbnode_put: > > > > + while (i--) { > > > > + larbnode = of_parse_phandle(dev->of_node, > > > > "mediatek,larbs", i); > > > > + if (larbnode && > > > > of_device_is_available(larbnode)) { > > > > + of_node_put(larbnode); > > > > + of_node_put(larbnode); > > > > + } > > > > > > This looks a bit awkward - could we not just iterate through > > > data->larb_imu and put dev->of_node for each valid dev? > > > > It should work. Thanks very much. > > > > > > > > Also, of_find_device_by_node() takes a reference on the struct > > > device > > > itself, so strictly we should be doing put_device() on those as > > > well > > > if we're bailing out. > > > > Thanks for this hint. A new reference for me. I will add it. > > In fact, thinking about it some more we may as well do the > of_node_put() > unconditionally immediately after the of_find_device_by_node() call, of_node_put is called in component_release_of in the normal case, thus we shouldn't call of_node_put unconditionally. Right? (Sorry for reply late) > so > then it's *only* the device references we'd need to worry about > cleaning > up in the failure path. > > Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel