From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1321C4332F for ; Tue, 22 Nov 2022 15:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iejRpG5xmG3AVT59k2korzV+i4h+JxFeIQ6F9nhVYVE=; b=0vbyG1gBSzE54Xd6mnLq69yQwy 8H0vYvJSNGC+2OGrCSByfWxOnX6bibIK9e4lvClFIGSywn93AHhtcgFhT2Qp05TkLIrTFrmIX3wtT gZXu80CQ4N4zFBaKLmdPE9wtMmL/W9yNrHAxLYaN7jWJaTgOrYcNNVrogRMnwqWYyNu6a6nULu6bV rxFediQrKtpvYFQddvtkWWDoDeT9bCHI9g4wl8Ls+H8EE/fTzeMkRp7QtvJDhM1s4pNpjWkLp96TF miNUahcSw6zFTvOY0LfRkA/hvKUKaikgcMA3KBn6pXHdpoPl0z2EGG5kDYlHq2y92tmAdjZnJIbNf 6n8h/0lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxVW6-00ATaw-Lj; Tue, 22 Nov 2022 15:48:58 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxVW2-00ATXe-VP; Tue, 22 Nov 2022 15:48:57 +0000 Received: by mail-wr1-x433.google.com with SMTP id z4so10759270wrr.3; Tue, 22 Nov 2022 07:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iejRpG5xmG3AVT59k2korzV+i4h+JxFeIQ6F9nhVYVE=; b=ERJaFk4RY2JkFY1qv6TQODE0AZ/ynMZlyKjqpHHZeLeGVUineTumgeSDCVdaBTDoCE k3JFmtpqgr2rwK2uCB+hzbXD4Lu+hEHgql6SJVCdw7yOg3rP2YZgXzJaDpEvv9VMzxEO envg5y6jmXVxTExN5qMcUhLl8tIAoNNfOCRXBoBRGS/MqWlfpz9kH9EYVqDHKh/deueG J9CNjTwJ5Bt6sLbAhD3sUZWhQF/yFlSocEihRmiNKnnbgdfeB+fWGAMd6rFZkji9ZWfB FDhyCf+fte3sj9Ss2mq8SnVDVPA45GnYCwfS2Gj/tGOYAEEbE2XxgXL9OmhNnlXIzQf1 FVwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iejRpG5xmG3AVT59k2korzV+i4h+JxFeIQ6F9nhVYVE=; b=A28UMkuSAr+vZtMUz16xro++Gs048+ZuSn6vlEglLtUd63aTFdVx/gGHEnRrYsM88X f+WKBTMc9PQ/X4SXiGYclxOScrEePHRvOfmTD/GruhLPCa3ROyP1RRplcSY88LPvPS8o IvS2UsAiwh1N0KBklqgrgGEf7LYMoCcQ/6Bdrm+P64homeb6Z+zeBVgtRSrzecn6JmgK jA6i/U83dzTrL6f5ohVT1mqlaYBP/EKntZBiP1q3MLdb5J4AJKMOOoqxd70P35fyOpUL sbxnZV8Z8IsWX03xfdctFguGSNkt5LN2itsAIaCEIL8jJ3L9St4KycDMoVZxguneN5j3 ZuOA== X-Gm-Message-State: ANoB5pm1uZJ2ldCHQ03zFLhGHrqxzOxeTEX+KeEkKYsVGnjpXC/dR1ND 772+XX9ykqCKdM5P41gc4As= X-Google-Smtp-Source: AA0mqf5NEgw8nrH93u2bY10c05fdm/Tx+wCnuYxy3cVf0cNE/5kLDJeWbVYnyzre7ISbHsO3k7PUGQ== X-Received: by 2002:adf:e84f:0:b0:22e:37c1:b225 with SMTP id d15-20020adfe84f000000b0022e37c1b225mr13795647wrn.428.1669132130446; Tue, 22 Nov 2022 07:48:50 -0800 (PST) Received: from [192.168.0.25] ([37.222.251.204]) by smtp.gmail.com with ESMTPSA id f28-20020a5d58fc000000b0022e36c1113fsm14161625wrd.13.2022.11.22.07.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 07:48:48 -0800 (PST) Message-ID: Date: Tue, 22 Nov 2022 16:48:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v28 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195 Content-Language: en-US To: =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "robh+dt@kernel.org" , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "chunkuang.hu@kernel.org" , "linux@roeck-us.net" , "p.zabel@pengutronix.de" , "wim@linux-watchdog.org" , "angelogioacchino.delregno@collabora.com" , "nfraprado@collabora.com" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , "nathan@kernel.org" , =?UTF-8?B?WW9uZ3FpYW5nIE5pdSAo54mb5rC45by6KQ==?= , "devicetree@vger.kernel.org" , "daniel@ffwll.ch" , "dri-devel@lists.freedesktop.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , "airlied@linux.ie" , "llvm@lists.linux.dev" , "ndesaulniers@google.com" References: <20221107072243.15748-1-nancy.lin@mediatek.com> <20221107072243.15748-2-nancy.lin@mediatek.com> From: Matthias Brugger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_074855_104675_59965B20 X-CRM114-Status: GOOD ( 30.80 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 22/11/2022 11:51, Nancy Lin (林欣螢) wrote: > Dear Matthias, > > Thanks for the review. > > On Thu, 2022-11-10 at 14:10 +0100, Matthias Brugger wrote: >> >> On 09/11/2022 06:10, Jason-JH Lin (林睿祥) wrote: >> > On Tue, 2022-11-08 at 18:46 +0100, Matthias Brugger wrote: >> > > >> > > On 07/11/2022 08:22, Nancy.Lin wrote: >> > > > Add vdosys1 mmsys compatible for MT8195 platform. >> > > > >> > > > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines >> > > > binding >> > > > to >> > > > 2 different power domains, different clock drivers and >> > > > different >> > > > mediatek-drm drivers. >> > > > >> > > > Signed-off-by: Nancy.Lin >> > > > Reviewed-by: Nícolas F. R. A. Prado >> > > > --- >> > > > >> > > > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | >> > > > 4 >> > > > +++- >> > > > 1 file changed, 3 insertions(+), 1 deletion(-) >> > > > >> > > > diff --git >> > > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > index 0711f1834fbd..aaabe2196185 100644 >> > > > --- >> > > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > +++ >> > > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > @@ -48,7 +48,9 @@ properties: >> > > > - const: syscon >> > > > >> > > > - items: >> > > > - - const: mediatek,mt8195-vdosys0 >> > > > + - enum: >> > > > + - mediatek,mt8195-vdosys0 >> > > > + - mediatek,mt8195-vdosys1 >> > > > - const: mediatek,mt8195-mmsys >> > > > - const: syscon >> > > > >> > > >> > > I think we had that several times already: >> > > >> > >> > > https://lore.kernel.org/all/6bbe9527-ae48-30e0-fb45-519223a744d7@linaro.org/ >> > > >> > > We will something like this, but please check that this does not >> > > give >> > > any >> > > errors/warnings: >> > > >> > > diff --git >> > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > index eb451bec23d3d..8e9c4f4d7c389 100644 >> > > --- >> > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > +++ >> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > @@ -32,13 +32,22 @@ properties: >> > > - mediatek,mt8183-mmsys >> > > - mediatek,mt8186-mmsys >> > > - mediatek,mt8192-mmsys >> > > - - mediatek,mt8195-mmsys >> > > - mediatek,mt8365-mmsys >> > > - const: syscon >> > > - items: >> > > - const: mediatek,mt7623-mmsys >> > > - const: mediatek,mt2701-mmsys >> > > - const: syscon >> > > + - items: >> > > + - const: mediatek,mt8195-vdosys0 >> > > + - const: syscon >> > > + - items: >> > > + - const: mediatek,mt8195-vdosys1 >> > > + - const: syscon >> > > + - items: >> > > + - const: mediatek,mt8195-mmsys >> > > + - const: syscon >> > > + deprecated: true >> > > >> > > reg: >> > > maxItems: 1 >> > >> > Hi Matthias, >> > >> > As the vdosys0 previous reviewed patch: >> > >> > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20220927152704.12018-2-jason-jh.lin@mediatek.com/__;!!CTRNKA9wMg0ARbw!zRdbIyyAsfqob2kapMAcKYATAguhEV0x0qE5cTOAcWUNhzeAbMHzZoos_2QzUCxS$ >> > >> > Should I modify the vdosys0 items format like your example? >> > >> > Or should vdosys1 add items format like vdosys0's previous patch? >> > - items: >> > - const: mediatek,mt8195-vdosys1 >> > - const: mediatek,mt8195-mmsys >> > - const: syscon >> > >> >> No, vdosys1 must not have mediatek,mt8195-mmsys fallback. >> >> Regards, >> Matthias >> > > I will fix it and add the following vdosys1 binding base on [1]. > > - description: vdosys0 and vdosys1 are 2 display HW pipelines, > so mt8195 binding should be deprecated. > deprecated: true > items: > - const: mediatek,mt8195-mmsys > - const: syscon > - items: > - const: mediatek,mt7623-mmsys > - const: mediatek,mt2701-mmsys > - const: syscon > - items: > - const: mediatek,mt8195-vdosys0 > - const: mediatek,mt8195-mmsys > - const: syscon > + - items: > + - const: mediatek,mt8195-vdosys1 > + - const: syscon > Looks good, thanks Matthias > [1] > https://kernel.googlesource.com/pub/scm/linux/kernel/git/matthias.bgg/linux/+/b237efd47df7d25b78c306e90b97c5aa0ff4c4fc/Documentation/devicetree/bindings/arm/mediatek/mediatek%2Cmmsys.yaml > > Regards, > Nancy > > >> > Regards, >> > Jason-JH.Lin >> > >> > >> > >> > ************* MEDIATEK Confidentiality Notice >> > ******************** >> > The information contained in this e-mail message (including any >> > attachments) may be confidential, proprietary, privileged, or >> > otherwise >> > exempt from disclosure under applicable laws. It is intended to be >> > conveyed only to the designated recipient(s). Any use, >> > dissemination, >> > distribution, printing, retaining or copying of this e-mail >> > (including its >> > attachments) by unintended recipient(s) is strictly prohibited and >> > may >> > be unlawful. If you are not an intended recipient of this e-mail, >> > or believe >> > >> > that you have received this e-mail in error, please notify the >> > sender >> > immediately (by replying to this e-mail), delete any and all copies >> > of >> > this e-mail (including any attachments) from your system, and do >> > not >> > disclose the content of this e-mail to any other person. Thank you! >> >> > > ************* MEDIATEK Confidentiality Notice ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35D45C433FE for ; Tue, 22 Nov 2022 15:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4Wx0uPXTMU8Eia/Igi0OZcXi84eyhmbPIst2i6+tOks=; b=tVQtpLV7ItrZya MDKBIkyeLuNxmVKEwHK7W0KmvIjiuR+CZZ5gtvGzc4RBhXYMvzUyQuczAXN6P2v+b5OniB/RdTZcq 10z6raE4nH5JyyKa/6ci49a7Z25R28wKInd6jDhxGiKQ5emAloqdHO9+ZuTjMx3RLIW4Vh0VC77gp ZAYSE/ZklRmDXMlOzvNz0FY4gPNE91tAljnQkRulXfYCywHQrVDUQi4w4CPzre3G2XX4zr8qq5Eq+ PZ894wfAXyR8BT+v3wXV2yLsTQ2hNvj8YeTwhUNNhLKWpp3TCv49vAN63bg5umzT6FXstb5jOj78Z 9ajeqHnKfdZYjO6SGdRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxVW9-00ATbK-89; Tue, 22 Nov 2022 15:49:01 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxVW2-00ATXe-VP; Tue, 22 Nov 2022 15:48:57 +0000 Received: by mail-wr1-x433.google.com with SMTP id z4so10759270wrr.3; Tue, 22 Nov 2022 07:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iejRpG5xmG3AVT59k2korzV+i4h+JxFeIQ6F9nhVYVE=; b=ERJaFk4RY2JkFY1qv6TQODE0AZ/ynMZlyKjqpHHZeLeGVUineTumgeSDCVdaBTDoCE k3JFmtpqgr2rwK2uCB+hzbXD4Lu+hEHgql6SJVCdw7yOg3rP2YZgXzJaDpEvv9VMzxEO envg5y6jmXVxTExN5qMcUhLl8tIAoNNfOCRXBoBRGS/MqWlfpz9kH9EYVqDHKh/deueG J9CNjTwJ5Bt6sLbAhD3sUZWhQF/yFlSocEihRmiNKnnbgdfeB+fWGAMd6rFZkji9ZWfB FDhyCf+fte3sj9Ss2mq8SnVDVPA45GnYCwfS2Gj/tGOYAEEbE2XxgXL9OmhNnlXIzQf1 FVwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iejRpG5xmG3AVT59k2korzV+i4h+JxFeIQ6F9nhVYVE=; b=A28UMkuSAr+vZtMUz16xro++Gs048+ZuSn6vlEglLtUd63aTFdVx/gGHEnRrYsM88X f+WKBTMc9PQ/X4SXiGYclxOScrEePHRvOfmTD/GruhLPCa3ROyP1RRplcSY88LPvPS8o IvS2UsAiwh1N0KBklqgrgGEf7LYMoCcQ/6Bdrm+P64homeb6Z+zeBVgtRSrzecn6JmgK jA6i/U83dzTrL6f5ohVT1mqlaYBP/EKntZBiP1q3MLdb5J4AJKMOOoqxd70P35fyOpUL sbxnZV8Z8IsWX03xfdctFguGSNkt5LN2itsAIaCEIL8jJ3L9St4KycDMoVZxguneN5j3 ZuOA== X-Gm-Message-State: ANoB5pm1uZJ2ldCHQ03zFLhGHrqxzOxeTEX+KeEkKYsVGnjpXC/dR1ND 772+XX9ykqCKdM5P41gc4As= X-Google-Smtp-Source: AA0mqf5NEgw8nrH93u2bY10c05fdm/Tx+wCnuYxy3cVf0cNE/5kLDJeWbVYnyzre7ISbHsO3k7PUGQ== X-Received: by 2002:adf:e84f:0:b0:22e:37c1:b225 with SMTP id d15-20020adfe84f000000b0022e37c1b225mr13795647wrn.428.1669132130446; Tue, 22 Nov 2022 07:48:50 -0800 (PST) Received: from [192.168.0.25] ([37.222.251.204]) by smtp.gmail.com with ESMTPSA id f28-20020a5d58fc000000b0022e36c1113fsm14161625wrd.13.2022.11.22.07.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 07:48:48 -0800 (PST) Message-ID: Date: Tue, 22 Nov 2022 16:48:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v28 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195 Content-Language: en-US To: =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "robh+dt@kernel.org" , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "chunkuang.hu@kernel.org" , "linux@roeck-us.net" , "p.zabel@pengutronix.de" , "wim@linux-watchdog.org" , "angelogioacchino.delregno@collabora.com" , "nfraprado@collabora.com" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , "nathan@kernel.org" , =?UTF-8?B?WW9uZ3FpYW5nIE5pdSAo54mb5rC45by6KQ==?= , "devicetree@vger.kernel.org" , "daniel@ffwll.ch" , "dri-devel@lists.freedesktop.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , "airlied@linux.ie" , "llvm@lists.linux.dev" , "ndesaulniers@google.com" References: <20221107072243.15748-1-nancy.lin@mediatek.com> <20221107072243.15748-2-nancy.lin@mediatek.com> From: Matthias Brugger In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_074855_104675_59965B20 X-CRM114-Status: GOOD ( 30.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMi8xMS8yMDIyIDExOjUxLCBOYW5jeSBMaW4gKOael+aso+ieoikgd3JvdGU6Cj4gRGVh ciBNYXR0aGlhcywKPiAKPiBUaGFua3MgZm9yIHRoZSByZXZpZXcuCj4gCj4gT24gVGh1LCAyMDIy LTExLTEwIGF0IDE0OjEwICswMTAwLCBNYXR0aGlhcyBCcnVnZ2VyIHdyb3RlOgo+PiAKPj4gT24g MDkvMTEvMjAyMiAwNjoxMCwgSmFzb24tSkggTGluICjmnpfnnb/npaUpIHdyb3RlOgo+PiA+IE9u IFR1ZSwgMjAyMi0xMS0wOCBhdCAxODo0NiArMDEwMCwgTWF0dGhpYXMgQnJ1Z2dlciB3cm90ZToK Pj4gPiA+IAo+PiA+ID4gT24gMDcvMTEvMjAyMiAwODoyMiwgTmFuY3kuTGluIHdyb3RlOgo+PiA+ ID4gPiBBZGQgdmRvc3lzMSBtbXN5cyBjb21wYXRpYmxlIGZvciBNVDgxOTUgcGxhdGZvcm0uCj4+ ID4gPiA+IAo+PiA+ID4gPiBGb3IgTVQ4MTk1LCBWRE9TWVMwIGFuZCBWRE9TWVMxIGFyZSAyIGRp c3BsYXkgSFcgcGlwZWxpbmVzCj4+ID4gPiA+IGJpbmRpbmcKPj4gPiA+ID4gdG8KPj4gPiA+ID4g MiBkaWZmZXJlbnQgcG93ZXIgZG9tYWlucywgZGlmZmVyZW50IGNsb2NrIGRyaXZlcnMgYW5kCj4+ ID4gPiA+IGRpZmZlcmVudAo+PiA+ID4gPiBtZWRpYXRlay1kcm0gZHJpdmVycy4KPj4gPiA+ID4g Cj4+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE5hbmN5LkxpbiA8bmFuY3kubGluQG1lZGlhdGVrLmNv bT4KPj4gPiA+ID4gUmV2aWV3ZWQtYnk6IE7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIDxuZnJhcHJh ZG9AY29sbGFib3JhLmNvbT4KPj4gPiA+ID4gLS0tCj4+ID4gPiA+ICAKPj4gPiA+ID4gLi4uL2Rl dmljZXRyZWUvYmluZGluZ3MvYXJtL21lZGlhdGVrL21lZGlhdGVrLG1tc3lzLnlhbWwgICAgICB8 Cj4+ID4gPiA+IDQKPj4gPiA+ID4gKysrLQo+PiA+ID4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4gPiA+ID4gCj4+ID4gPiA+IGRpZmYgLS1naXQK Pj4gPiA+ID4gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvYXJtL21lZGlhdGVr L21lZGlhdGVrLG1tc3lzCj4+ID4gPiA+IC55YW0KPj4gPiA+ID4gbAo+PiA+ID4gPiBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vbWVkaWF0ZWsvbWVkaWF0ZWssbW1zeXMK Pj4gPiA+ID4gLnlhbQo+PiA+ID4gPiBsCj4+ID4gPiA+IGluZGV4IDA3MTFmMTgzNGZiZC4uYWFh YmUyMTk2MTg1IDEwMDY0NAo+PiA+ID4gPiAtLS0KPj4gPiA+ID4gYS9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvYXJtL21lZGlhdGVrL21lZGlhdGVrLG1tc3lzCj4+ID4gPiA+IC55 YW0KPj4gPiA+ID4gbAo+PiA+ID4gPiArKysKPj4gPiA+ID4gYi9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvYXJtL21lZGlhdGVrL21lZGlhdGVrLG1tc3lzCj4+ID4gPiA+IC55YW0K Pj4gPiA+ID4gbAo+PiA+ID4gPiBAQCAtNDgsNyArNDgsOSBAQCBwcm9wZXJ0aWVzOgo+PiA+ID4g PiAgICAgICAgICAgICAtIGNvbnN0OiBzeXNjb24KPj4gPiA+ID4gICAKPj4gPiA+ID4gICAgICAg ICAtIGl0ZW1zOgo+PiA+ID4gPiAtICAgICAgICAgIC0gY29uc3Q6IG1lZGlhdGVrLG10ODE5NS12 ZG9zeXMwCj4+ID4gPiA+ICsgICAgICAgICAgLSBlbnVtOgo+PiA+ID4gPiArICAgICAgICAgICAg ICAtIG1lZGlhdGVrLG10ODE5NS12ZG9zeXMwCj4+ID4gPiA+ICsgICAgICAgICAgICAgIC0gbWVk aWF0ZWssbXQ4MTk1LXZkb3N5czEKPj4gPiA+ID4gICAgICAgICAgICAgLSBjb25zdDogbWVkaWF0 ZWssbXQ4MTk1LW1tc3lzCj4+ID4gPiA+ICAgICAgICAgICAgIC0gY29uc3Q6IHN5c2Nvbgo+PiA+ ID4gPiAgIAo+PiA+ID4gCj4+ID4gPiBJIHRoaW5rIHdlIGhhZCB0aGF0IHNldmVyYWwgdGltZXMg YWxyZWFkeToKPj4gPiA+IAo+PiA+IAo+PiA+IAo+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2Fs bC82YmJlOTUyNy1hZTQ4LTMwZTAtZmI0NS01MTkyMjNhNzQ0ZDdAbGluYXJvLm9yZy8KPj4gPiA+ IAo+PiA+ID4gV2Ugd2lsbCBzb21ldGhpbmcgbGlrZSB0aGlzLCBidXQgcGxlYXNlIGNoZWNrIHRo YXQgdGhpcyBkb2VzIG5vdAo+PiA+ID4gZ2l2ZQo+PiA+ID4gYW55IAo+PiA+ID4gZXJyb3JzL3dh cm5pbmdzOgo+PiA+ID4gCj4+ID4gPiBkaWZmIC0tZ2l0Cj4+ID4gPiBhL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vbWVkaWF0ZWsvbWVkaWF0ZWssbW1zeXMueQo+PiA+ID4g YW1sIAo+PiA+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvYXJtL21lZGlh dGVrL21lZGlhdGVrLG1tc3lzLnkKPj4gPiA+IGFtbAo+PiA+ID4gaW5kZXggZWI0NTFiZWMyM2Qz ZC4uOGU5YzRmNGQ3YzM4OSAxMDA2NDQKPj4gPiA+IC0tLQo+PiA+ID4gYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvYXJtL21lZGlhdGVrL21lZGlhdGVrLG1tc3lzLnkKPj4gPiA+ IGFtbAo+PiA+ID4gKysrCj4+ID4gPiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9hcm0vbWVkaWF0ZWsvbWVkaWF0ZWssbW1zeXMueQo+PiA+ID4gYW1sCj4+ID4gPiBAQCAtMzIs MTMgKzMyLDIyIEBAIHByb3BlcnRpZXM6Cj4+ID4gPiAgICAgICAgICAgICAgICAgLSBtZWRpYXRl ayxtdDgxODMtbW1zeXMKPj4gPiA+ICAgICAgICAgICAgICAgICAtIG1lZGlhdGVrLG10ODE4Ni1t bXN5cwo+PiA+ID4gICAgICAgICAgICAgICAgIC0gbWVkaWF0ZWssbXQ4MTkyLW1tc3lzCj4+ID4g PiAtICAgICAgICAgICAgICAtIG1lZGlhdGVrLG10ODE5NS1tbXN5cwo+PiA+ID4gICAgICAgICAg ICAgICAgIC0gbWVkaWF0ZWssbXQ4MzY1LW1tc3lzCj4+ID4gPiAgICAgICAgICAgICAtIGNvbnN0 OiBzeXNjb24KPj4gPiA+ICAgICAgICAgLSBpdGVtczoKPj4gPiA+ICAgICAgICAgICAgIC0gY29u c3Q6IG1lZGlhdGVrLG10NzYyMy1tbXN5cwo+PiA+ID4gICAgICAgICAgICAgLSBjb25zdDogbWVk aWF0ZWssbXQyNzAxLW1tc3lzCj4+ID4gPiAgICAgICAgICAgICAtIGNvbnN0OiBzeXNjb24KPj4g PiA+ICsgICAgICAtIGl0ZW1zOgo+PiA+ID4gKyAgICAgICAgICAtIGNvbnN0OiBtZWRpYXRlayxt dDgxOTUtdmRvc3lzMAo+PiA+ID4gKyAgICAgICAgICAtIGNvbnN0OiBzeXNjb24KPj4gPiA+ICsg ICAgICAtIGl0ZW1zOgo+PiA+ID4gKyAgICAgICAgICAtIGNvbnN0OiBtZWRpYXRlayxtdDgxOTUt dmRvc3lzMQo+PiA+ID4gKyAgICAgICAgICAtIGNvbnN0OiBzeXNjb24KPj4gPiA+ICsgICAgICAt IGl0ZW1zOgo+PiA+ID4gKyAgICAgICAgICAtIGNvbnN0OiBtZWRpYXRlayxtdDgxOTUtbW1zeXMK Pj4gPiA+ICsgICAgICAgICAgLSBjb25zdDogc3lzY29uCj4+ID4gPiArICAgICAgZGVwcmVjYXRl ZDogdHJ1ZQo+PiA+ID4gCj4+ID4gPiAgICAgcmVnOgo+PiA+ID4gICAgICAgbWF4SXRlbXM6IDEK Pj4gPiAKPj4gPiBIaSBNYXR0aGlhcywKPj4gPiAKPj4gPiBBcyB0aGUgdmRvc3lzMCBwcmV2aW91 cyByZXZpZXdlZCBwYXRjaDoKPj4gPiAKPj4gPiAKPiBodHRwczovL3VybGRlZmVuc2UuY29tL3Yz L19faHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L2xpbnV4LW1lZGlhdGVrL3Bh dGNoLzIwMjIwOTI3MTUyNzA0LjEyMDE4LTItamFzb24tamgubGluQG1lZGlhdGVrLmNvbS9fXzsh IUNUUk5LQTl3TWcwQVJidyF6UmRiSXl5QXNmcW9iMmthcE1BY0tZQVRBZ3VoRVYweDBxRTVjVE9B Y1dVTmh6ZUFiTUh6Wm9vc18yUXpVQ3hTJAo+PiA+ICAKPj4gPiBTaG91bGQgSSBtb2RpZnkgdGhl IHZkb3N5czAgaXRlbXMgZm9ybWF0IGxpa2UgeW91ciBleGFtcGxlPwo+PiA+IAo+PiA+IE9yIHNo b3VsZCB2ZG9zeXMxIGFkZCBpdGVtcyBmb3JtYXQgbGlrZSB2ZG9zeXMwJ3MgcHJldmlvdXMgcGF0 Y2g/Cj4+ID4gICAgICAtIGl0ZW1zOgo+PiA+ICAgICAgICAgIC0gY29uc3Q6IG1lZGlhdGVrLG10 ODE5NS12ZG9zeXMxCj4+ID4gICAgICAgICAgLSBjb25zdDogbWVkaWF0ZWssbXQ4MTk1LW1tc3lz Cj4+ID4gICAgICAgICAgLSBjb25zdDogc3lzY29uCj4+ID4gCj4+IAo+PiBObywgdmRvc3lzMSBt dXN0IG5vdCBoYXZlIG1lZGlhdGVrLG10ODE5NS1tbXN5cyBmYWxsYmFjay4KPj4gCj4+IFJlZ2Fy ZHMsCj4+IE1hdHRoaWFzCj4+IAo+IAo+IEkgd2lsbCBmaXggaXQgYW5kIGFkZCB0aGUgZm9sbG93 aW5nIHZkb3N5czEgYmluZGluZyBiYXNlIG9uIFsxXS4KPiAKPiAgICAgICAgLSBkZXNjcmlwdGlv bjogdmRvc3lzMCBhbmQgdmRvc3lzMSBhcmUgMiBkaXNwbGF5IEhXIHBpcGVsaW5lcywKPiAgICAg ICAgICAgICAgICAgICAgICAgc28gbXQ4MTk1IGJpbmRpbmcgc2hvdWxkIGJlIGRlcHJlY2F0ZWQu Cj4gICAgICAgICAgZGVwcmVjYXRlZDogdHJ1ZQo+ICAgICAgICAgIGl0ZW1zOgo+ICAgICAgICAg ICAgLSBjb25zdDogbWVkaWF0ZWssbXQ4MTk1LW1tc3lzCj4gICAgICAgICAgICAtIGNvbnN0OiBz eXNjb24KPiAgICAgICAgLSBpdGVtczoKPiAgICAgICAgICAgIC0gY29uc3Q6IG1lZGlhdGVrLG10 NzYyMy1tbXN5cwo+ICAgICAgICAgICAgLSBjb25zdDogbWVkaWF0ZWssbXQyNzAxLW1tc3lzCj4g ICAgICAgICAgICAtIGNvbnN0OiBzeXNjb24KPiAgICAgICAgLSBpdGVtczoKPiAgICAgICAgICAg IC0gY29uc3Q6IG1lZGlhdGVrLG10ODE5NS12ZG9zeXMwCj4gICAgICAgICAgICAtIGNvbnN0OiBt ZWRpYXRlayxtdDgxOTUtbW1zeXMKPiAgICAgICAgICAgIC0gY29uc3Q6IHN5c2Nvbgo+ICAgKyAg ICAtIGl0ZW1zOgo+ICAgKyAgICAgICAgLSBjb25zdDogbWVkaWF0ZWssbXQ4MTk1LXZkb3N5czEK PiAgICsgICAgICAgIC0gY29uc3Q6IHN5c2Nvbgo+IAoKTG9va3MgZ29vZCwgdGhhbmtzCk1hdHRo aWFzCgo+IFsxXQo+IGh0dHBzOi8va2VybmVsLmdvb2dsZXNvdXJjZS5jb20vcHViL3NjbS9saW51 eC9rZXJuZWwvZ2l0L21hdHRoaWFzLmJnZy9saW51eC8rL2IyMzdlZmQ0N2RmN2QyNWI3OGMzMDZl OTBiOTdjNWFhMGZmNGM0ZmMvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9t ZWRpYXRlay9tZWRpYXRlayUyQ21tc3lzLnlhbWwKPiAKPiBSZWdhcmRzLAo+IE5hbmN5Cj4gCj4g Cj4+ID4gUmVnYXJkcywKPj4gPiBKYXNvbi1KSC5MaW4KPj4gPiAKPj4gPiAKPj4gPiAKPj4gPiAq KioqKioqKioqKioqIE1FRElBVEVLIENvbmZpZGVudGlhbGl0eSBOb3RpY2UKPj4gPiAgICoqKioq KioqKioqKioqKioqKioqCj4+ID4gVGhlIGluZm9ybWF0aW9uIGNvbnRhaW5lZCBpbiB0aGlzIGUt bWFpbCBtZXNzYWdlIChpbmNsdWRpbmcgYW55Cj4+ID4gYXR0YWNobWVudHMpIG1heSBiZSBjb25m aWRlbnRpYWwsIHByb3ByaWV0YXJ5LCBwcml2aWxlZ2VkLCBvcgo+PiA+IG90aGVyd2lzZQo+PiA+ IGV4ZW1wdCBmcm9tIGRpc2Nsb3N1cmUgdW5kZXIgYXBwbGljYWJsZSBsYXdzLiBJdCBpcyBpbnRl bmRlZCB0byBiZQo+PiA+IGNvbnZleWVkIG9ubHkgdG8gdGhlIGRlc2lnbmF0ZWQgcmVjaXBpZW50 KHMpLiBBbnkgdXNlLAo+PiA+IGRpc3NlbWluYXRpb24sCj4+ID4gZGlzdHJpYnV0aW9uLCBwcmlu dGluZywgcmV0YWluaW5nIG9yIGNvcHlpbmcgb2YgdGhpcyBlLW1haWwKPj4gPiAoaW5jbHVkaW5n IGl0cwo+PiA+IGF0dGFjaG1lbnRzKSBieSB1bmludGVuZGVkIHJlY2lwaWVudChzKSBpcyBzdHJp Y3RseSBwcm9oaWJpdGVkIGFuZAo+PiA+IG1heQo+PiA+IGJlIHVubGF3ZnVsLiBJZiB5b3UgYXJl IG5vdCBhbiBpbnRlbmRlZCByZWNpcGllbnQgb2YgdGhpcyBlLW1haWwsCj4+ID4gb3IgYmVsaWV2 ZQo+PiA+ICAgCj4+ID4gdGhhdCB5b3UgaGF2ZSByZWNlaXZlZCB0aGlzIGUtbWFpbCBpbiBlcnJv ciwgcGxlYXNlIG5vdGlmeSB0aGUKPj4gPiBzZW5kZXIKPj4gPiBpbW1lZGlhdGVseSAoYnkgcmVw bHlpbmcgdG8gdGhpcyBlLW1haWwpLCBkZWxldGUgYW55IGFuZCBhbGwgY29waWVzCj4+ID4gb2YK Pj4gPiB0aGlzIGUtbWFpbCAoaW5jbHVkaW5nIGFueSBhdHRhY2htZW50cykgZnJvbSB5b3VyIHN5 c3RlbSwgYW5kIGRvCj4+ID4gbm90Cj4+ID4gZGlzY2xvc2UgdGhlIGNvbnRlbnQgb2YgdGhpcyBl LW1haWwgdG8gYW55IG90aGVyIHBlcnNvbi4gVGhhbmsgeW91IQo+PiAKPj4gCj4gCj4gKioqKioq KioqKioqKiBNRURJQVRFSyBDb25maWRlbnRpYWxpdHkgTm90aWNlICoqKioqKioqKioqKioqKioq KioqCj4gVGhlIGluZm9ybWF0aW9uIGNvbnRhaW5lZCBpbiB0aGlzIGUtbWFpbCBtZXNzYWdlIChp bmNsdWRpbmcgYW55Cj4gYXR0YWNobWVudHMpIG1heSBiZSBjb25maWRlbnRpYWwsIHByb3ByaWV0 YXJ5LCBwcml2aWxlZ2VkLCBvciBvdGhlcndpc2UKPiBleGVtcHQgZnJvbSBkaXNjbG9zdXJlIHVu ZGVyIGFwcGxpY2FibGUgbGF3cy4gSXQgaXMgaW50ZW5kZWQgdG8gYmUKPiBjb252ZXllZCBvbmx5 IHRvIHRoZSBkZXNpZ25hdGVkIHJlY2lwaWVudChzKS4gQW55IHVzZSwgZGlzc2VtaW5hdGlvbiwK PiBkaXN0cmlidXRpb24sIHByaW50aW5nLCByZXRhaW5pbmcgb3IgY29weWluZyBvZiB0aGlzIGUt bWFpbCAoaW5jbHVkaW5nIGl0cwo+IGF0dGFjaG1lbnRzKSBieSB1bmludGVuZGVkIHJlY2lwaWVu dChzKSBpcyBzdHJpY3RseSBwcm9oaWJpdGVkIGFuZCBtYXkKPiBiZSB1bmxhd2Z1bC4gSWYgeW91 IGFyZSBub3QgYW4gaW50ZW5kZWQgcmVjaXBpZW50IG9mIHRoaXMgZS1tYWlsLCBvciBiZWxpZXZl Cj4gdGhhdCB5b3UgaGF2ZSByZWNlaXZlZCB0aGlzIGUtbWFpbCBpbiBlcnJvciwgcGxlYXNlIG5v dGlmeSB0aGUgc2VuZGVyCj4gaW1tZWRpYXRlbHkgKGJ5IHJlcGx5aW5nIHRvIHRoaXMgZS1tYWls KSwgZGVsZXRlIGFueSBhbmQgYWxsIGNvcGllcyBvZgo+IHRoaXMgZS1tYWlsIChpbmNsdWRpbmcg YW55IGF0dGFjaG1lbnRzKSBmcm9tIHlvdXIgc3lzdGVtLCBhbmQgZG8gbm90Cj4gZGlzY2xvc2Ug dGhlIGNvbnRlbnQgb2YgdGhpcyBlLW1haWwgdG8gYW55IG90aGVyIHBlcnNvbi4gVGhhbmsgeW91 IQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83DB8C4332F for ; Tue, 22 Nov 2022 15:48:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 15CC189D56; Tue, 22 Nov 2022 15:48:56 +0000 (UTC) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3BF1F89D56 for ; Tue, 22 Nov 2022 15:48:52 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id d1so13237550wrs.12 for ; Tue, 22 Nov 2022 07:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iejRpG5xmG3AVT59k2korzV+i4h+JxFeIQ6F9nhVYVE=; b=ERJaFk4RY2JkFY1qv6TQODE0AZ/ynMZlyKjqpHHZeLeGVUineTumgeSDCVdaBTDoCE k3JFmtpqgr2rwK2uCB+hzbXD4Lu+hEHgql6SJVCdw7yOg3rP2YZgXzJaDpEvv9VMzxEO envg5y6jmXVxTExN5qMcUhLl8tIAoNNfOCRXBoBRGS/MqWlfpz9kH9EYVqDHKh/deueG J9CNjTwJ5Bt6sLbAhD3sUZWhQF/yFlSocEihRmiNKnnbgdfeB+fWGAMd6rFZkji9ZWfB FDhyCf+fte3sj9Ss2mq8SnVDVPA45GnYCwfS2Gj/tGOYAEEbE2XxgXL9OmhNnlXIzQf1 FVwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iejRpG5xmG3AVT59k2korzV+i4h+JxFeIQ6F9nhVYVE=; b=ZM9l9imWoJ9DlatwhDfG+EtOmCHtydtdvnWRa2ZspmXkOxLgXKvgHtrDQov6G2WB3g wCAjxtPUfCFw8pbimieEZys+jhtDUJwUbLUU2gJOF4aHoNoOGIMkftUC77pE7A1J3qeY cnuGWacUVYr563iG93TIUL6Ziu6TCM5espkWaCVgD5HbjHDYbLh6Ez5177xFkNG3vCgf 0ymqai5YPU9fD7IdXKd3l731d7A9WEmwOR9yHIckYDthTw81zUqQVfGEgiLtTDriv6Nw gzogCgQl0+ZryOCZKthvwdWPix1d7rCv5TipMx34mp2gqqn8KJeeaFQrZfl3dRh84XSZ UCmA== X-Gm-Message-State: ANoB5pkEdhWhbWRtx7aU1ClYyJ6nKaVLRSS36/4+O5f0YPRla5tYLokM a9vN/1M7dS9sznV78TzBISU= X-Google-Smtp-Source: AA0mqf5NEgw8nrH93u2bY10c05fdm/Tx+wCnuYxy3cVf0cNE/5kLDJeWbVYnyzre7ISbHsO3k7PUGQ== X-Received: by 2002:adf:e84f:0:b0:22e:37c1:b225 with SMTP id d15-20020adfe84f000000b0022e37c1b225mr13795647wrn.428.1669132130446; Tue, 22 Nov 2022 07:48:50 -0800 (PST) Received: from [192.168.0.25] ([37.222.251.204]) by smtp.gmail.com with ESMTPSA id f28-20020a5d58fc000000b0022e36c1113fsm14161625wrd.13.2022.11.22.07.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 07:48:48 -0800 (PST) Message-ID: Date: Tue, 22 Nov 2022 16:48:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v28 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195 Content-Language: en-US To: =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "robh+dt@kernel.org" , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "chunkuang.hu@kernel.org" , "linux@roeck-us.net" , "p.zabel@pengutronix.de" , "wim@linux-watchdog.org" , "angelogioacchino.delregno@collabora.com" , "nfraprado@collabora.com" References: <20221107072243.15748-1-nancy.lin@mediatek.com> <20221107072243.15748-2-nancy.lin@mediatek.com> From: Matthias Brugger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Project_Global_Chrome_Upstream_Group , "airlied@linux.ie" , =?UTF-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , "llvm@lists.linux.dev" , "ndesaulniers@google.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "nathan@kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?WW9uZ3FpYW5nIE5pdSAo54mb5rC45by6KQ==?= , "linux-arm-kernel@lists.infradead.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 22/11/2022 11:51, Nancy Lin (林欣螢) wrote: > Dear Matthias, > > Thanks for the review. > > On Thu, 2022-11-10 at 14:10 +0100, Matthias Brugger wrote: >> >> On 09/11/2022 06:10, Jason-JH Lin (林睿祥) wrote: >> > On Tue, 2022-11-08 at 18:46 +0100, Matthias Brugger wrote: >> > > >> > > On 07/11/2022 08:22, Nancy.Lin wrote: >> > > > Add vdosys1 mmsys compatible for MT8195 platform. >> > > > >> > > > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines >> > > > binding >> > > > to >> > > > 2 different power domains, different clock drivers and >> > > > different >> > > > mediatek-drm drivers. >> > > > >> > > > Signed-off-by: Nancy.Lin >> > > > Reviewed-by: Nícolas F. R. A. Prado >> > > > --- >> > > > >> > > > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | >> > > > 4 >> > > > +++- >> > > > 1 file changed, 3 insertions(+), 1 deletion(-) >> > > > >> > > > diff --git >> > > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > index 0711f1834fbd..aaabe2196185 100644 >> > > > --- >> > > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > +++ >> > > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > @@ -48,7 +48,9 @@ properties: >> > > > - const: syscon >> > > > >> > > > - items: >> > > > - - const: mediatek,mt8195-vdosys0 >> > > > + - enum: >> > > > + - mediatek,mt8195-vdosys0 >> > > > + - mediatek,mt8195-vdosys1 >> > > > - const: mediatek,mt8195-mmsys >> > > > - const: syscon >> > > > >> > > >> > > I think we had that several times already: >> > > >> > >> > > https://lore.kernel.org/all/6bbe9527-ae48-30e0-fb45-519223a744d7@linaro.org/ >> > > >> > > We will something like this, but please check that this does not >> > > give >> > > any >> > > errors/warnings: >> > > >> > > diff --git >> > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > index eb451bec23d3d..8e9c4f4d7c389 100644 >> > > --- >> > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > +++ >> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > @@ -32,13 +32,22 @@ properties: >> > > - mediatek,mt8183-mmsys >> > > - mediatek,mt8186-mmsys >> > > - mediatek,mt8192-mmsys >> > > - - mediatek,mt8195-mmsys >> > > - mediatek,mt8365-mmsys >> > > - const: syscon >> > > - items: >> > > - const: mediatek,mt7623-mmsys >> > > - const: mediatek,mt2701-mmsys >> > > - const: syscon >> > > + - items: >> > > + - const: mediatek,mt8195-vdosys0 >> > > + - const: syscon >> > > + - items: >> > > + - const: mediatek,mt8195-vdosys1 >> > > + - const: syscon >> > > + - items: >> > > + - const: mediatek,mt8195-mmsys >> > > + - const: syscon >> > > + deprecated: true >> > > >> > > reg: >> > > maxItems: 1 >> > >> > Hi Matthias, >> > >> > As the vdosys0 previous reviewed patch: >> > >> > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20220927152704.12018-2-jason-jh.lin@mediatek.com/__;!!CTRNKA9wMg0ARbw!zRdbIyyAsfqob2kapMAcKYATAguhEV0x0qE5cTOAcWUNhzeAbMHzZoos_2QzUCxS$ >> > >> > Should I modify the vdosys0 items format like your example? >> > >> > Or should vdosys1 add items format like vdosys0's previous patch? >> > - items: >> > - const: mediatek,mt8195-vdosys1 >> > - const: mediatek,mt8195-mmsys >> > - const: syscon >> > >> >> No, vdosys1 must not have mediatek,mt8195-mmsys fallback. >> >> Regards, >> Matthias >> > > I will fix it and add the following vdosys1 binding base on [1]. > > - description: vdosys0 and vdosys1 are 2 display HW pipelines, > so mt8195 binding should be deprecated. > deprecated: true > items: > - const: mediatek,mt8195-mmsys > - const: syscon > - items: > - const: mediatek,mt7623-mmsys > - const: mediatek,mt2701-mmsys > - const: syscon > - items: > - const: mediatek,mt8195-vdosys0 > - const: mediatek,mt8195-mmsys > - const: syscon > + - items: > + - const: mediatek,mt8195-vdosys1 > + - const: syscon > Looks good, thanks Matthias > [1] > https://kernel.googlesource.com/pub/scm/linux/kernel/git/matthias.bgg/linux/+/b237efd47df7d25b78c306e90b97c5aa0ff4c4fc/Documentation/devicetree/bindings/arm/mediatek/mediatek%2Cmmsys.yaml > > Regards, > Nancy > > >> > Regards, >> > Jason-JH.Lin >> > >> > >> > >> > ************* MEDIATEK Confidentiality Notice >> > ******************** >> > The information contained in this e-mail message (including any >> > attachments) may be confidential, proprietary, privileged, or >> > otherwise >> > exempt from disclosure under applicable laws. It is intended to be >> > conveyed only to the designated recipient(s). Any use, >> > dissemination, >> > distribution, printing, retaining or copying of this e-mail >> > (including its >> > attachments) by unintended recipient(s) is strictly prohibited and >> > may >> > be unlawful. If you are not an intended recipient of this e-mail, >> > or believe >> > >> > that you have received this e-mail in error, please notify the >> > sender >> > immediately (by replying to this e-mail), delete any and all copies >> > of >> > this e-mail (including any attachments) from your system, and do >> > not >> > disclose the content of this e-mail to any other person. Thank you! >> >> > > ************* MEDIATEK Confidentiality Notice ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you!