From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cP7ws-00046V-0H for ath10k@lists.infradead.org; Thu, 05 Jan 2017 13:19:19 +0000 MIME-Version: 1.0 Date: Thu, 05 Jan 2017 18:48:56 +0530 From: Tamizh chelvam Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX In-Reply-To: <1483354130.4596.5.camel@sipsolutions.net> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> <1481645351.20412.34.camel@sipsolutions.net> <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> <1481881024.27953.14.camel@sipsolutions.net> <1483354130.4596.5.camel@sipsolutions.net> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gMjAxNy0wMS0wMiAxNjoxOCwgSm9oYW5uZXMgQmVyZyB3cm90ZToKPj4gPiAxKSBkb2VzIGl0 IGV2ZW4gbWFrZSBzZW5zZSB0byBzcGxpdCBpdCBvdXQgcGVyIEFDPyB3b3VsZG4ndCBpdCBiZQo+ PiA+IHdlaXJkCj4+ID4gaWYgeW91IHN1cHBvcnRlZCB0aGlzIG9ubHkgZm9yIFZPIGFuZCBCSywg YW5kIG5vdCB0aGUgb3RoZXJzLCBvcgo+PiA+IHNvbWV0aGluZyBsaWtlIHRoYXQ/Cj4+ID4KPj4g Cj4+IEl0IGhhcyBzdXBwb3J0IGZvciBCRSwgVkksIG1hbmFnZW1lbnQgYW5kIGJlYWNvbiBmcmFt ZXMgYWxzby4KPj4gT3IgZG8geW91IG1lYW50IHRvIHNheSBsaWtlIHN1cHBvcnQgb25seSBmb3Ig Vk8gYW5kIEJLPwo+IAo+IEkgbWVhbiAtIGRvZXMgaXQgbWFrZSBzZW5zZSBmb3IgYSBwaWVjZSBv ZiBoYXJkd2FyZSB0byBzdXBwb3J0IG9ubHkKPiBWTy9CSywgd2l0aG91dCB0aGUgb3RoZXJzPyBJ IGRvbid0IHJlYWxseSBzZWUgaG93IHRoYXQgd291bGQgbWFrZQo+IHNlbnNlLCBidXQgbWF5YmUg SSdtIG1pc3Npbmcgc29tZXRoaW5nPwo+IAo+IElPVyAtIHdoeSBoYXZlIGFsbCB0aGVzZSBiaXRz IHJhdGhlciB0aGFuIGp1c3Qgb25lPwoKSGFyZHdhcmUgc3VwcG9ydHMgZGF0YSBhY3Jvc3MgYWxs IHRoZSBhY2Nlc3MgY2F0ZWdvcmllcywgdGhpcyBpcyBqdXN0IAptZWFudCBmb3IgcHJpb3JpdGlz aW5nIHRoZSB0cmFmZmljLgpmLmUsIElmIHRoZSBmdy90YXJnZXQgaGFzIGJvdGggd2xhbiBhbmQg YnQgdHJhZmZpYyBxdWV1ZWQgYW5kIGlmIFZPIGlzIApzZXQgYXMgcHJpb3JpdHksIHRoZW4gd2xh biBWTyBwYWNrZXRzCndpbGwgYmUgcHVzaGVkIG91dCBvZiB0aGUgcmFkaW8gZmlyc3QgYW5kIHRo ZW4gdGhlIGJ0IHRyYWZmaWMuCgpIZXJlIHdlIGRvIG5vdCBibG9jayB0cmFmZmljIGVpdGhlciBm cm9tIHdsYW4gb3IgQlQsIHBhY2tldHMgd2lsbCAKZGVmaW5pdGVseSBnbyBvdXQgb2YgdGhlIHJh ZGlvIGJ1dCB0cmFmZmljCmFyYml0cmF0aW9uIHdpbGwgaGFwcGVuIGJhc2VkIG9uIHRoZSBwcmlv cml0aWVzIHNldC4KCj4gCj4+ID4gMikgV291bGRuJ3QgaXQgbWFrZSBtb3JlIHNlbnNlIHRvIGRl ZmluZSB0aGlzIGluIG5sODAyMTEgYW5kIGp1c3QKPj4gPiBwYXNzIHRoZSBiaXRtYXAgdGhyb3Vn aCB0byB1c2Vyc3BhY2U/IFRoYXQgd291bGQgc2F2ZSBxdWl0ZSBhIGJpdAo+PiA+IG9mIG5ldGxp bmsgbWFuZ2xpbmcgY29tcGxleGl0eS4KPj4gPgo+PiAKPj4gUGxlYXNlIGxldCBtZSBrbm93IGlm IHRoZSBiZWxvdyBkZXNpZ24vdGhvdWdodCBpcyBmaW5lIHRvIHlvdS4KPj4gCj4+IGl3IHBoeVgg c2V0IGJ0Y29leF9wcmlvcml0eSA8W3ZpLCB2bywgYmUsIGJrLCBtZ210LCBiZWFjb25dPgo+IAo+ IFRoYXQgc2VlbXMgZmluZSwgYnV0IEkgZG9uJ3Qgc2VlIGhvdyB0aGUgaXcgY29tbWFuZCBsaW5l IGlzIHJlbGV2YW50IHRvCj4gdGhlIHF1ZXN0aW9uIG9mIHdoZXRoZXIgd2UgcGFzcyBmbGFnIGF0 dHJpYnV0ZXMgb3IgYSBiaXRtYXA/Pwo+IAo+PiBCeSB0aGlzIGNvbW1hbmQgdXNlciBzaG91bGQg Z2l2ZSBvbmUgb3IgbW9yZSB0aGFuIG9uZSBmcmFtZSB0eXBlcwo+PiBmb3LCoAo+PiB0aGlzIGJ0 Y29leCBwcmlvcml0eSwKPj4gd2Ugd2lsbCBwYXJzZSB0aGF0IGluICJpdyIgYW5kIHNlbmQgYXMg YSBzaW5nbGUgYml0bWFwKGxlc3MgdGhhbgo+PiAweDY0KcKgIHRvIHRoZSBkcml2ZXI/Cj4gCj4g UmlnaHQsIGFuZCBhbHNvIHRvIG5sODAyMTEuIFdoeSBub3Q/CgpZZXMgdXNlciBzcGFjZSB0byBu bDgwMjExIGFuZCB0byBkcml2ZXIKCj4gCj4gam9oYW5uZXMKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:49546 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033838AbdAENS6 (ORCPT ); Thu, 5 Jan 2017 08:18:58 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Thu, 05 Jan 2017 18:48:56 +0530 From: Tamizh chelvam To: Johannes Berg Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX In-Reply-To: <1483354130.4596.5.camel@sipsolutions.net> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> <1481645351.20412.34.camel@sipsolutions.net> <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> <1481881024.27953.14.camel@sipsolutions.net> <1483354130.4596.5.camel@sipsolutions.net> Message-ID: (sfid-20170105_141902_636418_0B02EF30) Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2017-01-02 16:18, Johannes Berg wrote: >> > 1) does it even make sense to split it out per AC? wouldn't it be >> > weird >> > if you supported this only for VO and BK, and not the others, or >> > something like that? >> > >> >> It has support for BE, VI, management and beacon frames also. >> Or do you meant to say like support only for VO and BK? > > I mean - does it make sense for a piece of hardware to support only > VO/BK, without the others? I don't really see how that would make > sense, but maybe I'm missing something? > > IOW - why have all these bits rather than just one? Hardware supports data across all the access categories, this is just meant for prioritising the traffic. f.e, If the fw/target has both wlan and bt traffic queued and if VO is set as priority, then wlan VO packets will be pushed out of the radio first and then the bt traffic. Here we do not block traffic either from wlan or BT, packets will definitely go out of the radio but traffic arbitration will happen based on the priorities set. > >> > 2) Wouldn't it make more sense to define this in nl80211 and just >> > pass the bitmap through to userspace? That would save quite a bit >> > of netlink mangling complexity. >> > >> >> Please let me know if the below design/thought is fine to you. >> >> iw phyX set btcoex_priority <[vi, vo, be, bk, mgmt, beacon]> > > That seems fine, but I don't see how the iw command line is relevant to > the question of whether we pass flag attributes or a bitmap?? > >> By this command user should give one or more than one frame types >> for  >> this btcoex priority, >> we will parse that in "iw" and send as a single bitmap(less than >> 0x64)  to the driver? > > Right, and also to nl80211. Why not? Yes user space to nl80211 and to driver > > johannes