All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Khem Raj" <raj.khem@gmail.com>
To: Michael Opdenacker <michael.opdenacker@bootlin.com>,
	openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH 1/2] cve-check: fix comments
Date: Thu, 5 Aug 2021 07:39:14 -0700	[thread overview]
Message-ID: <a55a4cc3-9b7c-ba72-9406-7d9516cc85cd@gmail.com> (raw)
In-Reply-To: <20210805102729.32575-1-michael.opdenacker@bootlin.com>

Hi Michael

Please send these patches to openembedded-core mailing list since these 
are for core layer.

On 8/5/21 3:27 AM, Michael Opdenacker wrote:
> This implements various fixes in comments in cve-check.bbclass
> In particular, the "whitlisted" typo is important as the "whitelisted"
> word is going to be replaced in a near future.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> ---
>   meta/classes/cve-check.bbclass | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
> index a3fc9c2623..acdf005a72 100644
> --- a/meta/classes/cve-check.bbclass
> +++ b/meta/classes/cve-check.bbclass
> @@ -20,7 +20,7 @@
>   # the only method to check against CVEs. Running this tool
>   # doesn't guarantee your packages are free of CVEs.
>   
> -# The product name that the CVE database uses.  Defaults to BPN, but may need to
> +# The product name that the CVE database uses defaults to BPN, but may need to
>   # be overriden per recipe (for example tiff.bb sets CVE_PRODUCT=libtiff).
>   CVE_PRODUCT ??= "${BPN}"
>   CVE_VERSION ??= "${PV}"
> @@ -56,11 +56,11 @@ CVE_CHECK_WHITELIST ?= ""
>   # Layers to be excluded
>   CVE_CHECK_LAYER_EXCLUDELIST ??= ""
>   
> -# Layers to be included
> +# Layers to be included
>   CVE_CHECK_LAYER_INCLUDELIST ??= ""
>   
>   
> -# set to "alphabetical" for version using single alphabetical character as increament release
> +# set to "alphabetical" for version using single alphabetical character as increment release
>   CVE_VERSION_SUFFIX ??= ""
>   
>   python cve_save_summary_handler () {
> @@ -230,7 +230,7 @@ def check_cves(d, patched_cves):
>           return ([], [], [])
>       pv = d.getVar("CVE_VERSION").split("+git")[0]
>   
> -    # If the recipe has been whitlisted we return empty lists
> +    # If the recipe has been whitelisted we return empty lists
>       if pn in d.getVar("CVE_CHECK_PN_WHITELIST").split():
>           bb.note("Recipe has been whitelisted, skipping check")
>           return ([], [], [])
> 
> 
> 
> 
> 

  parent reply	other threads:[~2021-08-05 14:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 10:27 [PATCH 1/2] cve-check: fix comments Michael Opdenacker
2021-08-05 10:27 ` [PATCH 2/2] cve-check: update link to NVD website for CVE details Michael Opdenacker
2021-08-05 14:39 ` Khem Raj [this message]
2021-08-05 15:49   ` [oe] [PATCH 1/2] cve-check: fix comments Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a55a4cc3-9b7c-ba72-9406-7d9516cc85cd@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=michael.opdenacker@bootlin.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.