From: "Maxime Ripard" <mripard@kernel.org>
To: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"David Airlie" <airlied@gmail.com>,
"Hui Pu" <Hui.Pu@gehealthcare.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Simona Vetter" <simona@ffwll.ch>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Subject: Re: [PATCH 2/3] drm/bridge: select_bus_fmt_recursive(): put the bridge obtained by drm_bridge_get_prev_bridge()
Date: Thu, 10 Jul 2025 07:54:45 +0000 [thread overview]
Message-ID: <a599626ffe0fff92bead9f693c1a0090@kernel.org> (raw)
In-Reply-To: <20250709-drm-bridge-alloc-getput-drm_bridge_get_prev_bridge-v1-2-34ba6f395aaa@bootlin.com>
On Wed, 9 Jul 2025 17:59:38 +0200, Luca Ceresoli wrote:
> The bridge returned by drm_bridge_get_prev_bridge() is refcounted. Put it
> when done.
>
> select_bus_fmt_recursive() has several return points, and ensuring
> drm_bridge_put() is always called in the right place would be error-prone
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
next prev parent reply other threads:[~2025-07-10 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 15:59 [PATCH 0/3] drm/bridge: get/put the bridge returned by drm_bridge_get_prev_bridge() Luca Ceresoli
2025-07-09 15:59 ` [PATCH 1/3] drm/bridge: get " Luca Ceresoli
2025-07-10 7:54 ` Maxime Ripard
2025-07-09 15:59 ` [PATCH 2/3] drm/bridge: select_bus_fmt_recursive(): put the bridge obtained " Luca Ceresoli
2025-07-10 7:54 ` Maxime Ripard [this message]
2025-07-09 15:59 ` [PATCH 3/3] drm/bridge: display-connector: " Luca Ceresoli
2025-07-10 7:54 ` Maxime Ripard
2025-07-23 11:10 ` [PATCH 0/3] drm/bridge: get/put the bridge returned " Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a599626ffe0fff92bead9f693c1a0090@kernel.org \
--to=mripard@kernel.org \
--cc=Hui.Pu@gehealthcare.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.