Re: [Buildroot] [PATCH] freescale_imx93evk_defconfig: Add OP-TEE OS support

[Julien Olivain via buildroot <buildroot@buildroot.org>]

Hi Fabio, Breno,

Thanks for the patch.  I have few comments.

In order to match other commits in "configs", could you reword the
title as: "configs/freescale_imx93evk: Add OP-TEE OS support"

Also, this patch enables BR2_TARGET_OPTEE_OS=y in this defconfig
which also has BR2_DOWNLOAD_FORCE_CHECK_HASHES=y.

So running the commands:

     make freescale_imx93evk_defconfig
     make source

Are failing with error:

     ERROR: No hash found for imx-optee-os-lf-6.12.3-1.0.0.tar.gz

This commit should also add optee-os hashes in
board/freescale/imx93evk/patches (which is the path set in
BR2_GLOBAL_PATCH_DIR).

Could you send an updated patch fixing those issues, please?

On 13/08/2025 01:14, Fabio Estevam wrote:
> From: Breno Lima <breno.lima@nxp.com>
> 
> Add OP-TEE OS Support from the NXP BSP lf-6.12.3-1.0.0 version.
> 
> The i.MX93 Boot Container requires a raw TEE binary without a TEE 
> header.
> Update the imx9-bootloader-prepare.sh script and Config.in accordingly
> to ensure compatibility with this requirement.
> 
> Signed-off-by: Breno Lima <breno.lima@nxp.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  board/freescale/common/imx/imx9-bootloader-prepare.sh | 2 +-
>  boot/optee-os/Config.in                               | 2 +-
>  configs/freescale_imx93evk_defconfig                  | 7 +++++++
>  3 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/board/freescale/common/imx/imx9-bootloader-prepare.sh 
> b/board/freescale/common/imx/imx9-bootloader-prepare.sh
> index 2db887a785..a267114d43 100755
> --- a/board/freescale/common/imx/imx9-bootloader-prepare.sh
> +++ b/board/freescale/common/imx/imx9-bootloader-prepare.sh
> @@ -20,7 +20,7 @@ main ()
>  		"${HOST_DIR}/bin/mkimage_imx8" -soc IMX9 -c \
>  			-ap "${BINARIES_DIR}/bl31.bin" a55 ${ATF_LOAD_ADDR} \
>  			-ap "${BINARIES_DIR}/u-boot-hash.bin" a55 0x80200000 \
> -			-ap "${BINARIES_DIR}/tee.bin" a55 0x96000000 \
> +			-ap "${BINARIES_DIR}/tee-raw.bin" a55 0x96000000 \
>  			-out "${BINARIES_DIR}/u-boot-atf-container.img"
>  	else
>  		"${HOST_DIR}/bin/mkimage_imx8" -soc IMX9 -c \
> diff --git a/boot/optee-os/Config.in b/boot/optee-os/Config.in
> index 433dae90d8..e737d2a0ac 100644
> --- a/boot/optee-os/Config.in
> +++ b/boot/optee-os/Config.in
> @@ -167,7 +167,7 @@ config BR2_TARGET_OPTEE_OS_ADDITIONAL_VARIABLES
> 
>  config BR2_TARGET_OPTEE_OS_CORE_IMAGES
>  	string "Binary boot images"
> -	default "tee.bin tee-*_v2.bin"
> +	default "tee.bin tee-raw.bin tee-*_v2.bin"
>  	help
>  	  Names of generated image files that are installed in the
>  	  output images/ directory.
> diff --git a/configs/freescale_imx93evk_defconfig 
> b/configs/freescale_imx93evk_defconfig
> index 1140747825..0a39859342 100644
> --- a/configs/freescale_imx93evk_defconfig
> +++ b/configs/freescale_imx93evk_defconfig
> @@ -25,6 +25,13 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL=y
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION="$(call 
> github,nxp-imx,imx-atf,lf-6.12.3-1.0.0)/imx-atf-lf-6.12.3-1.0.0.tar.gz"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="imx93"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE=y
> +BR2_TARGET_OPTEE_OS=y
> +BR2_TARGET_OPTEE_OS_CUSTOM_TARBALL=y
> +BR2_TARGET_OPTEE_OS_CUSTOM_TARBALL_LOCATION="$(call 
> github,nxp-imx,imx-optee-os,lf-6.12.3-1.0.0)/imx-optee-os-lf-6.12.3-1.0.0.tar.gz"
> +BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY=y
> +BR2_TARGET_OPTEE_OS_PLATFORM="imx"
> +BR2_TARGET_OPTEE_OS_PLATFORM_FLAVOR="mx93evk"
>  BR2_TARGET_UBOOT=y
>  BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>  BR2_TARGET_UBOOT_CUSTOM_TARBALL=y
> --
> 2.34.1

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot