Re: [PATCH v3 2/4] dt-bindings: sound: bindings for tac5x1x family of codecs

["Holalu Yogendra, Niranjan" <niranjan.hy@ti.com>]

Hi Krzysztof,

Thanks for the detailed review comments. 
Request you to take a look at comments below. 

On Fri, Jun 27, 2025 at 1:18 PM +0530, Krzysztof Kozlowski wrote:
> On Thu, Jun 26, 2025 at 11:43:31PM +0530, Niranjan H Y wrote:
> > +  ti,vref:
> > +    description: VREF required voltage. If node is omitted then VREF is
> Voltage is in microvolt. Use proper suffix/values.
Is this convention ? Is there any document on these I can refer ?
> 
> > +    oneOf:
> > +      - const: 0
> > +        description: VREF output is powered to 2.75V.
> > +      - const: 1
> > +        description: VREF output is powered to 2.5V.
> > +      - const: 2
> > +        description: VREF output is powered to 1.375V.

> > +  ti,gpios-func:
> > +    description: |
> > +      Array indicating the GPIO1, GPIO2, GPO1 Functionality in the same order.
> > +      Each integer elemnent in the array represent the following
> > +      - 0  TAC5X1X_GPIO_DISABLE        - GPIO is Disabled
> > +      - 1  TAC5X1X_GPIO_GPI            - General Purpose Input
> > +      - 2  ADC3XXX_GPIO_GPO            - General Purpose Output
> > +      - 3  TAC5X1X_GPIO_IRQ            - Chip Interrupt
> > +      - 4  TAC5X1X_GPIO_PDMCLK         - PDM CLK Output
> > +      - 5  TAC5X1X_GPIO_P_DOUT         - Primary ASI DOUT
> > +      - 6  TAC5X1X_GPIO_P_DOUT2        - Primary ASI DOUT2
> > +      - 7  TAC5X1X_GPIO_S_DOUT         - Secondary ASI DOUT
> > +      - 8  TAC5X1X_GPIO_S_DOUT2        - Secondary ASI DOUT2
> > +      - 9  TAC5X1X_GPIO_S_BCLK         - Secondary BCLK Output
> > +      - 10 TAC5X1X_GPIO_S_FSYNC       - Secondary FSYNC Output
> > +      - 11 TAC5X1X_GPIO_CLKOUT        - General Purpose Output
> > +      - 12 TAC5X1X_GPIO_DOUT_MUX
> > +      - 13 TAC5X1X_GPIO_DAISY_OUT
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> > +    minItems: 3
> > +    maxItems: 3
> 
> Don't encode gpios and pins as some custom properties.
Could you please suggest what is the alternative.
Please suggest some example which I can refer ? 

Regards
Niranjan