All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>,
	u-boot@lists.denx.de, Sumit Garg <sumit.garg@kernel.org>,
	u-boot-qcom@groups.io
Cc: Tom Rini <trini@konsulko.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Rasmus Villemoes <ravi@prevas.dk>, Simon Glass <sjg@chromium.org>,
	Javier Tia <floss@jetm.me>,
	Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
	Varadarajan Narayanan <quic_varada@quicinc.com>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Richard Genoud <richard.genoud@bootlin.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	David Lechner <dlechner@baylibre.com>,
	Casey Connolly <casey.connolly@linaro.org>,
	Marek Vasut <marek.vasut+renesas@mailbox.org>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Michael Walle <mwalle@kernel.org>,
	Sumit Garg <sumit.garg@oss.qualcomm.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Aswin Murugan <aswin.murugan@oss.qualcomm.com>,
	Jerome Forissier <jerome.forissier@arm.com>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>
Subject: Re: [PATCH v4 1/8] disk: Add partition lookup by type GUID functionality
Date: Thu, 7 May 2026 15:42:14 +0200	[thread overview]
Message-ID: <a5c42652-7346-4775-a13e-e9d74c393ee6@cherry.de> (raw)
In-Reply-To: <20260428-type-v4-1-b7051dc45a88@oss.qualcomm.com>

Hi Balaji,

On 4/28/26 9:31 AM, Balaji Selvanathan wrote:
> Introduce part_get_info_by_type_guid() function to enable partition
> lookup using partition type GUID. This complements the existing UUID
> lookup functionality and provides more flexible partition discovery
> mechanisms.
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
> ---
> Changes in v4:
> - No changes
> 
> Changes in v3:
> - Addressed minor corrections in part_get_info_by_type_guid function
> 
> Changes in v2:
> - No changes
> ---
> ---
>   disk/part.c    | 37 +++++++++++++++++++++++++++++++++++++
>   include/part.h | 21 +++++++++++++++++++++
>   2 files changed, 58 insertions(+)
> 
> diff --git a/disk/part.c b/disk/part.c
> index 4923dc44593..4cb3204ac6e 100644
> --- a/disk/part.c
> +++ b/disk/part.c
> @@ -731,6 +731,43 @@ int part_get_info_by_uuid(struct blk_desc *desc, const char *uuid,
>   	return -ENOENT;
>   }
>   
> +int part_get_info_by_type_guid(struct blk_desc *desc, const char *type_guid,
> +			       struct disk_partition *info)
> +{
> +	struct part_driver *part_drv;
> +	int ret;
> +	int i;
> +
> +	if (!CONFIG_IS_ENABLED(PARTITION_TYPE_GUID))

We don't have an xPL symbols for PARTITION_TYPE_GUID so you need to use 
IS_ENABLED(CONFIG_...) here otherwise it won't work in xPL stages.

Or you need to add an xPL symbol for that (see PARTITION_UUIDS and 
SPL_PARTITION_UUIDS).

Cheers,
Quentin

  reply	other threads:[~2026-05-07 13:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28  7:31 [PATCH v4 0/8] Add partition type GUID support for environment Balaji Selvanathan
2026-04-28  7:31 ` [PATCH v4 1/8] disk: Add partition lookup by type GUID functionality Balaji Selvanathan
2026-05-07 13:42   ` Quentin Schulz [this message]
2026-04-28  7:31 ` [PATCH v4 2/8] scsi: Add partition lookup by type GUID for SCSI devices Balaji Selvanathan
2026-05-01  2:12   ` Simon Glass
2026-04-28  7:31 ` [PATCH v4 3/8] scsi: Optimize scsi_get_blk_by_uuid() loop iteration Balaji Selvanathan
2026-04-28  7:31 ` [PATCH v4 4/8] env: scsi: Fix ENV_SCSI_HW_PARTITION default value type Balaji Selvanathan
2026-04-28  7:31 ` [PATCH v4 5/8] env: scsi: Add partition type GUID support and choice-based selection Balaji Selvanathan
2026-04-28  7:31 ` [PATCH v4 6/8] env: scsi: Implement partition type GUID lookup Balaji Selvanathan
2026-04-28  7:31 ` [PATCH v4 7/8] configs: Enable partition type GUID for QCS9100/QCM6490/QCS615 boards Balaji Selvanathan
2026-05-01  8:02   ` Sumit Garg
2026-04-28  7:31 ` [PATCH v4 8/8] test: dm: Add partition type GUID lookup test Balaji Selvanathan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5c42652-7346-4775-a13e-e9d74c393ee6@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=ansuelsmth@gmail.com \
    --cc=aswin.murugan@oss.qualcomm.com \
    --cc=balaji.selvanathan@oss.qualcomm.com \
    --cc=casey.connolly@linaro.org \
    --cc=dlechner@baylibre.com \
    --cc=floss@jetm.me \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jan.kiszka@siemens.com \
    --cc=javierm@redhat.com \
    --cc=jerome.forissier@arm.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    --cc=mkorpershoek@kernel.org \
    --cc=mwalle@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_varada@quicinc.com \
    --cc=ravi@prevas.dk \
    --cc=richard.genoud@bootlin.com \
    --cc=sjg@chromium.org \
    --cc=sumit.garg@kernel.org \
    --cc=sumit.garg@oss.qualcomm.com \
    --cc=trini@konsulko.com \
    --cc=u-boot-qcom@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.