Re: [PATCH] hw/xen: Fix trace_xs_node_read() params

[Richard Henderson <richard.henderson@linaro.org>]

On 5/26/25 19:10, Philippe Mathieu-Daudé wrote:
> Alternatively, since this is an error path:
> 
> -- >8 --
> diff --git a/hw/xen/xen-bus-helper.c b/hw/xen/xen-bus-helper.c
> index 288fad422be..1e49e60e147 100644
> --- a/hw/xen/xen-bus-helper.c
> +++ b/hw/xen/xen-bus-helper.c
> @@ -143,7 +143,8 @@ char *xs_node_read(struct qemu_xs_handle *h, xs_transaction_t tid,
>                      unsigned int *len, Error **errp,
>                      const char *path_fmt, ...)
>   {
> -    char *path, *value;
> +    g_autofree char *value;
> +    char *path;
>       va_list ap;
> 
>       va_start(ap, path_fmt);
> @@ -151,12 +152,11 @@ char *xs_node_read(struct qemu_xs_handle *h, xs_transaction_t tid,
>       va_end(ap);
> 
>       value = qemu_xen_xs_read(h, tid, path, len);
> -    trace_xs_node_read(path, value);
>       if (!value) {
>           error_setg_errno(errp, errno, "failed to read from '%s'", path);
> +        return NULL;
>       }

Auto-free variables must be initialized.


r~