From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail29.static.mailgun.info ([104.130.122.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI8wz-00053G-AV for ath11k@lists.infradead.org; Tue, 15 Sep 2020 11:16:42 +0000 MIME-Version: 1.0 Date: Tue, 15 Sep 2020 19:16:38 +0800 From: Wen Gong Subject: Re: [PATCH v5 2/8] ath11k: add support for 6GHz radio in driver In-Reply-To: <20200603001724.12161-3-pradeepc@codeaurora.org> References: <20200603001724.12161-1-pradeepc@codeaurora.org> <20200603001724.12161-3-pradeepc@codeaurora.org> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Pradeep Kumar Chitrapu Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org On 2020-06-03 08:17, Pradeep Kumar Chitrapu wrote: > This patch adds 6GHz band support and mac80211 registration for > the 6G phy radio. > > Signed-off-by: Pradeep Kumar Chitrapu > --- > v5: > - do not add ht/vht caps in 6ghz band. > v3: > - update 6GHz starting frequency as defined in IEEE P802.11ax/D6.1 > > drivers/net/wireless/ath/ath11k/core.h | 6 +- > drivers/net/wireless/ath/ath11k/mac.c | 93 +++++++++++++++++++++----- > drivers/net/wireless/ath/ath11k/wmi.c | 16 ++++- > 3 files changed, 94 insertions(+), 21 deletions(-) > [...] > @@ -3482,7 +3494,7 @@ static void ath11k_mac_setup_ht_vht_cap(struct > ath11k *ar, > rate_cap_rx_chainmask); > } > > - if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP) { > + if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP && > !ar->supports_6ghz) { > band = &ar->mac.sbands[NL80211_BAND_5GHZ]; > ht_cap = cap->band[NL80211_BAND_5GHZ].ht_cap_info; > if (ht_cap_info) After this change, when 6G is support, it removed HT/VHT of 5G band from "iw list", when connect to an 11AX AP of 5G, it used non-HT. caused together with this commit 75e296e9b22aef6fa467523ace87ef623dac1fad(mac80211: simplify and improve HT/VHT/HE disable code) + /* disable HT/VHT/HE if we don't support them */ + if (!sband->ht_cap.ht_supported) { + ifmgd->flags |= IEEE80211_STA_DISABLE_HT; + ifmgd->flags |= IEEE80211_STA_DISABLE_VHT; + ifmgd->flags |= IEEE80211_STA_DISABLE_HE; + } after remove this change in ath11k, it become correct to HE iw wls1 station dump: rx bitrate: 149.7 MBit/s HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0 [...] -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B268C43461 for ; Tue, 15 Sep 2020 11:18:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F76C21D1B for ; Tue, 15 Sep 2020 11:18:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="q76G++n1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726249AbgIOLSC (ORCPT ); Tue, 15 Sep 2020 07:18:02 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:64225 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726133AbgIOLQk (ORCPT ); Tue, 15 Sep 2020 07:16:40 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600168599; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=oLLGnUAlXBsPg+aGu1U6kXPPViE30lxfIpUEFZ6mAak=; b=q76G++n1yQxlS4YjWHIhmBM07UB/2D3xVSSdWgQCgAa4UhkYjsdfHlWsOaVlnDxx9pcENufo mOluCcYABeazLs+R3bWJ1ehE2mmfqePw459bS8FW4k3B7Uxz48SU6Ahvfd97P3pmoMDQ8Vjv FXFaKf+ZVjEhXc5t7PM/a2iCqbk= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 5f60a297252c5224408c8663 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 15 Sep 2020 11:16:39 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 2B544C433F0; Tue, 15 Sep 2020 11:16:39 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id CB77AC433CA; Tue, 15 Sep 2020 11:16:38 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 15 Sep 2020 19:16:38 +0800 From: Wen Gong To: Pradeep Kumar Chitrapu Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH v5 2/8] ath11k: add support for 6GHz radio in driver In-Reply-To: <20200603001724.12161-3-pradeepc@codeaurora.org> References: <20200603001724.12161-1-pradeepc@codeaurora.org> <20200603001724.12161-3-pradeepc@codeaurora.org> Message-ID: X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-06-03 08:17, Pradeep Kumar Chitrapu wrote: > This patch adds 6GHz band support and mac80211 registration for > the 6G phy radio. > > Signed-off-by: Pradeep Kumar Chitrapu > --- > v5: > - do not add ht/vht caps in 6ghz band. > v3: > - update 6GHz starting frequency as defined in IEEE P802.11ax/D6.1 > > drivers/net/wireless/ath/ath11k/core.h | 6 +- > drivers/net/wireless/ath/ath11k/mac.c | 93 +++++++++++++++++++++----- > drivers/net/wireless/ath/ath11k/wmi.c | 16 ++++- > 3 files changed, 94 insertions(+), 21 deletions(-) > [...] > @@ -3482,7 +3494,7 @@ static void ath11k_mac_setup_ht_vht_cap(struct > ath11k *ar, > rate_cap_rx_chainmask); > } > > - if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP) { > + if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP && > !ar->supports_6ghz) { > band = &ar->mac.sbands[NL80211_BAND_5GHZ]; > ht_cap = cap->band[NL80211_BAND_5GHZ].ht_cap_info; > if (ht_cap_info) After this change, when 6G is support, it removed HT/VHT of 5G band from "iw list", when connect to an 11AX AP of 5G, it used non-HT. caused together with this commit 75e296e9b22aef6fa467523ace87ef623dac1fad(mac80211: simplify and improve HT/VHT/HE disable code) + /* disable HT/VHT/HE if we don't support them */ + if (!sband->ht_cap.ht_supported) { + ifmgd->flags |= IEEE80211_STA_DISABLE_HT; + ifmgd->flags |= IEEE80211_STA_DISABLE_VHT; + ifmgd->flags |= IEEE80211_STA_DISABLE_HE; + } after remove this change in ath11k, it become correct to HE iw wls1 station dump: rx bitrate: 149.7 MBit/s HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0 [...]