Re: [GITGRUB] New menu interface (implementation)

[Michal Suchanek <hramrach@centrum.cz>]

2009/10/8 Bean <bean123ch@gmail.com>:
> On Thu, Oct 8, 2009 at 5:13 AM, Michal Suchanek <hramrach@centrum.cz> wrote:
>> 2009/10/7 Michal Suchanek <hramrach@centrum.cz>:
>>> 2009/10/7 Bean <bean123ch@gmail.com>:
>>>> On Wed, Oct 7, 2009 at 4:54 PM, Michal Suchanek <hramrach@centrum.cz> wrote:
>>>>> This might make switching the direction of a panel more difficult but
>>>>> there may be other issues. Either way the method with margin does not
>>>>> work either.
>>>>
>>>> Hi,
>>>>
>>>> The latest version should work now, although there is a small issue,
>>>> the margin_*, padding_* property only works for panel widget for now,
>>>> so you should replace padding_* of the term with margin_* of parent
>>>> panel.
>>
>> I tired the latest code and there is still some alignment issue.
>>
>> In graphics mode the top and bottom part of border is missing.
>>
>> The problem with zero width panels is fixed but a layout with a
>> "toolbar" does not really work for me.
>
> Hi,
>
> Some issue of the config:
>
> 1, Don't add the c suffix , now default unit is character, just use

It should be possible to use the c suffix even if it is the default.

> number. Also, if you set height/width directly, it should include the
> border size, so minimum value is 2 (for top and bottom rect).

Indeed, the width should include the border which is currently quite large.

>
> 2, You should use far position as you want to extend the widget at the
> far side (top).

This dependency is a problem. The rules for creating a working layout
are then complicated and hard to understand.

Also I have no idea why I should set position on the screen, it is
never positioned.

>
> 3, border_width only draws left/right border, to draw top/bottom
> border, you need to add border_height as well.

That's quite surprising. In other layout systems I have seen so far there is
 - border width (of all borders)
 - border top/left/bottom/right width (for particular borders,
sometimes not available)

It would be useful to have aliases for margin and padding so that
vertical./horizontal/all can be set in one assignment.

Thanks

Michal